Skip to content

Commit be4ed40

Browse files
committed
Merge branch 'dev' into gobigfoot-feature/addDescriptionToDynamicForm
2 parents fb403e3 + 8b72820 commit be4ed40

File tree

94 files changed

+2241
-42
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

94 files changed

+2241
-42
lines changed

CHANGELOG.JSON

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,8 @@
44
"version": "3.3.0",
55
"changes": {
66
"new": [
7-
"`LivePersona`: New Control LivePersona [#969](https://github.com/pnp/sp-dev-fx-controls-react/pull/969)"
7+
"`LivePersona`: New Control LivePersona [#969](https://github.com/pnp/sp-dev-fx-controls-react/pull/969)",
8+
"`ListItemComments`: New Control ListItemComments [#979](https://github.com/pnp/sp-dev-fx-controls-react/pull/979)"
89
],
910
"enhancements": [
1011
"`FilePicker`: spanish translation for Stock Images labels [#946](https://github.com/pnp/sp-dev-fx-controls-react/pull/946)",
@@ -14,12 +15,14 @@
1415
"`ListItemPicker`: add property to show all options by default [#955](https://github.com/pnp/sp-dev-fx-controls-react/issues/955)",
1516
"`ListItemPicker`: Missing translation keys, improved FI, NL translation [#957](https://github.com/pnp/sp-dev-fx-controls-react/pull/957)",
1617
"`TaxonomyPicker`: Added onNewTerm called when enter is pressed [#967](https://github.com/pnp/sp-dev-fx-controls-react/pull/967)",
17-
"`DynamicForm`: Principal Types support [#956](https://github.com/pnp/sp-dev-fx-controls-react/pull/956)"
18+
"`DynamicForm`: Principal Types support [#956](https://github.com/pnp/sp-dev-fx-controls-react/pull/956)",
19+
"`DateTimePicker`: Expose allowTextInput from the underlying date picker [#928](https://github.com/pnp/sp-dev-fx-controls-react/issues/928)"
1820
],
1921
"fixes": [
2022
"`RichText`: Image button is checked when hyperlink is added to the text [#948](https://github.com/pnp/sp-dev-fx-controls-react/issues/948)",
2123
"`RichText`: impossible to display link with the text equal to the url [#949](https://github.com/pnp/sp-dev-fx-controls-react/issues/949)",
22-
"`ComboBoxListItemPicker`: defaultSelectedItems not working [#954](https://github.com/pnp/sp-dev-fx-controls-react/issues/954)"
24+
"`ComboBoxListItemPicker`: defaultSelectedItems not working [#954](https://github.com/pnp/sp-dev-fx-controls-react/issues/954)",
25+
"`Dynamic Form`: query items in a folder (managed metadata field) [#973](https://github.com/pnp/sp-dev-fx-controls-react/issues/973)"
2326
]
2427
},
2528
"contributions": [
@@ -28,7 +31,8 @@
2831
"[Sergio Ortega Martín](https://github.com/sortegamartin)",
2932
"[João Mendes](https://github.com/joaojmendes)",
3033
"[Gautam Sheth](https://github.com/gautamdsheth)",
31-
"[Dennis Kuhn](https://github.com/DennisKuhn)"
34+
"[Dennis Kuhn](https://github.com/DennisKuhn)",
35+
"[Modern Dev Dude](https://github.com/modern-dev-dude)"
3236
]
3337
},
3438
{

CHANGELOG.md

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,21 +2,31 @@
22

33
## 3.3.0
44

5+
### New control(s)
6+
7+
- `LivePersona`: New Control LivePersona [#969](https://github.com/pnp/sp-dev-fx-controls-react/pull/969)
8+
59
### Enhancements
610

711
- `FilePicker`: spanish translation for Stock Images labels [#946](https://github.com/pnp/sp-dev-fx-controls-react/pull/946)
812
- `FilePicker`: Add support for a defaultFolderAbsolutePath prop [#947](https://github.com/pnp/sp-dev-fx-controls-react/pull/947)
913
- `DynamicForm`: Returning PnPJS `IItem` in `onSubmitted` event based on `returnListItemInstanceOnSubmit` property [#944](https://github.com/pnp/sp-dev-fx-controls-react/pull/944)
1014
- `DateTimePicker`: Add property for minutes dropdown increment [#939](https://github.com/pnp/sp-dev-fx-controls-react/issues/939)
15+
- `ListItemPicker`: add property to show all options by default [#955](https://github.com/pnp/sp-dev-fx-controls-react/issues/955)
16+
- `ListItemPicker`: Missing translation keys, improved FI, NL translation [#957](https://github.com/pnp/sp-dev-fx-controls-react/pull/957)
17+
- `TaxonomyPicker`: Added onNewTerm called when enter is pressed [#967](https://github.com/pnp/sp-dev-fx-controls-react/pull/967)
18+
- `DynamicForm`: Principal Types support [#956](https://github.com/pnp/sp-dev-fx-controls-react/pull/956)
1119

1220
### Fixes
1321

1422
- `RichText`: Image button is checked when hyperlink is added to the text [#948](https://github.com/pnp/sp-dev-fx-controls-react/issues/948)
1523
- `RichText`: impossible to display link with the text equal to the url [#949](https://github.com/pnp/sp-dev-fx-controls-react/issues/949)
24+
- `ComboBoxListItemPicker`: defaultSelectedItems not working [#954](https://github.com/pnp/sp-dev-fx-controls-react/issues/954)
25+
- `Dynamic Form`: query items in a folder (managed metadata field) [#973](https://github.com/pnp/sp-dev-fx-controls-react/issues/973)
1626

1727
### Contributors
1828

19-
Special thanks to our contributors (in alphabetical order): [Ketill Antoníus Ágústsson](https://github.com/Katli95), [Ravichandran Krishnasamy](https://github.com/ravichandran-blog), [Sergio Ortega Martín](https://github.com/sortegamartin).
29+
Special thanks to our contributors (in alphabetical order): [Ketill Antoníus Ágústsson](https://github.com/Katli95), [Ravichandran Krishnasamy](https://github.com/ravichandran-blog), [Sergio Ortega Martín](https://github.com/sortegamartin), [João Mendes](https://github.com/joaojmendes), [Gautam Sheth](https://github.com/gautamdsheth), [Dennis Kuhn](https://github.com/DennisKuhn).
2030

2131
## 3.2.1
2232

docs/documentation/docs/about/release-notes.md

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,21 +2,31 @@
22

33
## 3.3.0
44

5+
### New control(s)
6+
7+
- `LivePersona`: New Control LivePersona [#969](https://github.com/pnp/sp-dev-fx-controls-react/pull/969)
8+
59
### Enhancements
610

711
- `FilePicker`: spanish translation for Stock Images labels [#946](https://github.com/pnp/sp-dev-fx-controls-react/pull/946)
812
- `FilePicker`: Add support for a defaultFolderAbsolutePath prop [#947](https://github.com/pnp/sp-dev-fx-controls-react/pull/947)
913
- `DynamicForm`: Returning PnPJS `IItem` in `onSubmitted` event based on `returnListItemInstanceOnSubmit` property [#944](https://github.com/pnp/sp-dev-fx-controls-react/pull/944)
1014
- `DateTimePicker`: Add property for minutes dropdown increment [#939](https://github.com/pnp/sp-dev-fx-controls-react/issues/939)
15+
- `ListItemPicker`: add property to show all options by default [#955](https://github.com/pnp/sp-dev-fx-controls-react/issues/955)
16+
- `ListItemPicker`: Missing translation keys, improved FI, NL translation [#957](https://github.com/pnp/sp-dev-fx-controls-react/pull/957)
17+
- `TaxonomyPicker`: Added onNewTerm called when enter is pressed [#967](https://github.com/pnp/sp-dev-fx-controls-react/pull/967)
18+
- `DynamicForm`: Principal Types support [#956](https://github.com/pnp/sp-dev-fx-controls-react/pull/956)
1119

1220
### Fixes
1321

1422
- `RichText`: Image button is checked when hyperlink is added to the text [#948](https://github.com/pnp/sp-dev-fx-controls-react/issues/948)
1523
- `RichText`: impossible to display link with the text equal to the url [#949](https://github.com/pnp/sp-dev-fx-controls-react/issues/949)
24+
- `ComboBoxListItemPicker`: defaultSelectedItems not working [#954](https://github.com/pnp/sp-dev-fx-controls-react/issues/954)
25+
- `Dynamic Form`: query items in a folder (managed metadata field) [#973](https://github.com/pnp/sp-dev-fx-controls-react/issues/973)
1626

1727
### Contributors
1828

19-
Special thanks to our contributors (in alphabetical order): [Ketill Antoníus Ágústsson](https://github.com/Katli95), [Ravichandran Krishnasamy](https://github.com/ravichandran-blog), [Sergio Ortega Martín](https://github.com/sortegamartin).
29+
Special thanks to our contributors (in alphabetical order): [Ketill Antoníus Ágústsson](https://github.com/Katli95), [Ravichandran Krishnasamy](https://github.com/ravichandran-blog), [Sergio Ortega Martín](https://github.com/sortegamartin), [João Mendes](https://github.com/joaojmendes), [Gautam Sheth](https://github.com/gautamdsheth), [Dennis Kuhn](https://github.com/DennisKuhn).
2030

2131
## 3.2.1
2232

17.6 MB
Loading
439 KB
Loading
272 KB
Loading
290 KB
Loading
264 KB
Loading

docs/documentation/docs/controls/DateTimePicker.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -103,6 +103,7 @@ Interface `IDateTimePickerStrings` extends [IDatePickerStrings](https://develope
103103
| timeSeparator | string | no | Separator between time of day components (hours, minutes, seconds). |
104104
| amDesignator | string | no | Used as AM designator when 12-hour clock is used. |
105105
| pmDesignator | string | no | Used as PM designator when 12-hour clock is used. |
106+
| textErrorMessage | string | no | Error message when text is entered in the date picker. |
106107

107108
Type `MinutesIncrement`
108109
```typescript
Lines changed: 59 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,59 @@
1+
# ListItemComments control
2+
3+
This control allows you to manage list item comments, you can add or delete comments to an item. The comments are listed in tile view.
4+
user can scroll to load more comments if they exist (infinite scroll);
5+
6+
7+
Here is an example of the control:
8+
9+
![ListItemComments](../assets/ListItemComments.gif)
10+
11+
![ListItemComments](../assets/ListItemComments01.png)
12+
13+
![ListItemComments](../assets/ListItemComments02.png)
14+
15+
![ListItemComments](../assets/ListItemComments03.png)
16+
17+
![ListItemComments](../assets/ListItemComments04.png)
18+
19+
## How to use this control in your solutions
20+
21+
- Check that you installed the `@pnp/spfx-controls-react` dependency. Check out the [getting started](../../#getting-started) page for more information about installing the dependency.
22+
- Import the control into your component:
23+
24+
```TypeScript
25+
import { ListItemComments } from '@pnp/spfx-controls-react/lib/ListItemComments';
26+
```
27+
- Use the `ListItemComments` control in your code as follows:
28+
29+
```TypeScript
30+
<ListItemComments webUrl='{"https://contoso.sharepoint.com/sites/ThePerspective"}'
31+
listId='dfa283f4-5faf-4d54-b6b8-5bcaf2725af5'
32+
itemId={1}
33+
serviceScope={serviceScope}
34+
numberCommentsPerPage={10}
35+
label="ListItem Comments"
36+
/>
37+
```
38+
39+
40+
## Implementation
41+
42+
The `ListItemComments` control can be configured with the following properties:
43+
44+
45+
| Property | Type | Required | Description |
46+
| ---- | ---- | ---- | ---- |
47+
| serviceScope | ServiceScope | yes | SPFx Service Scope |
48+
| itemId | number | yes | List Item Id |
49+
| listId | string | yes | Guid of the list. |
50+
| webUrl | string | no | URL of the site. By default it uses the current site URL. |
51+
| label | string | no | Label for control |
52+
| numberCommentsPerPage | number | no | number of comments per page possible values 5 | 10 | 15 | 20 default 10 |
53+
54+
## MSGraph Permissions required
55+
56+
This control required the flowing scopes:
57+
at least : People.Read
58+
59+
![](https://telemetry.sharepointpnp.com/sp-dev-fx-controls-react/wiki/controls/ListItemComments)

0 commit comments

Comments
 (0)