Skip to content

Commit c4f6b3a

Browse files
committed
Implemented IconProps and code formatting
1 parent 92c26ea commit c4f6b3a

File tree

4 files changed

+30
-45
lines changed

4 files changed

+30
-45
lines changed

src/controls/treeView/DropdownTreeItemAction.tsx

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,9 @@
11
import * as React from 'react';
22
import { IContextualMenuItem, IContextualMenuProps } from 'office-ui-fabric-react/lib/ContextualMenu';
3-
import { IconButton, IIconProps } from 'office-ui-fabric-react';
4-
3+
import { IconButton } from 'office-ui-fabric-react/lib/Button';
54
import { ITreeItem } from './ITreeItem';
65
import { ITreeItemAction, IConcreteTreeItemActionProps } from './ITreeItemActions';
76
import styles from './TreeView.module.scss';
8-
import { DefaultButton } from 'office-ui-fabric-react/lib/Button';
97

108
/**
119
* Renders the controls for Dropdown TreeItem action component
@@ -93,7 +91,7 @@ export class DropdownTreeItemAction extends React.Component<IConcreteTreeItemAct
9391

9492
return (
9593
<div>
96-
<DefaultButton
94+
<IconButton
9795
menuProps={contextualMenuProps}
9896
menuIconProps={{ iconName: 'MoreVertical' }}
9997
className={styles.actionMore}

src/controls/treeView/ITreeViewProps.ts

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -28,23 +28,19 @@ export interface ITreeViewProps {
2828
* By default this is set to Single.
2929
*/
3030
selectionMode?: TreeViewSelectionMode;
31-
3231
/**
3332
* Specify if the childrens should be selected when parent is selected.
3433
* By default this is set to false.
3534
*/
3635
selectChildrenIfParentSelected?: boolean;
37-
3836
/**
3937
* Specify if the checkboxes should be displayed for selection.
4038
*/
4139
showCheckboxes?: boolean;
42-
4340
/**
4441
* Display mode of the tree item actions.
4542
*/
4643
treeItemActionsDisplayMode?: TreeItemActionsDisplayMode;
47-
4844
/**
4945
* Keys of items selected by default
5046
*/
@@ -56,13 +52,11 @@ export interface ITreeViewProps {
5652
* @argument isExpanded The status of item (expanded / collapsed).
5753
*/
5854
onExpandCollapse?: (item: ITreeItem, isExpanded: boolean) => void;
59-
6055
/**
6156
* Callback function called after an item is selected.
6257
* @argument items The selected items.
6358
*/
6459
onSelect?: (items: ITreeItem[]) => void;
65-
6660
/**
6761
* Customize how items are rendered.
6862
* @argument item The tree item.

src/controls/treeView/TreeItem.tsx

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@ export interface ITreeItemProps {
4242
* Stores the selected tree items
4343
*/
4444
activeItems: ITreeItem[];
45-
4645
/**
4746
* Display mode of the tree item actions.
4847
*/
@@ -160,27 +159,27 @@ export default class TreeItem extends React.Component<ITreeItemProps, ITreeItemS
160159
// Default rendering of tree item
161160
<span>
162161
{
163-
this.props.showCheckboxes && item.selectable == false && !item.children &&
162+
this.props.showCheckboxes && item.selectable == false && !item.children &&
164163
<span className={styles.blankspace}>&nbsp;</span>
165164
}
166165
{
167166
// Rendering when item has iconProps
168167
item.iconProps &&
169-
<span>
168+
<span>
170169
<Icon className={styles.icon} iconName={item.iconProps.iconName} style={item.iconProps.style} />
171170
&nbsp;
172171
</span>
173172
}
174173
<div
175174
className={styles.labels}
176175
onClick={(e) => {
177-
debugger;
178176
if (this.props.selectionMode != TreeViewSelectionMode.None && item.selectable != false) {
179-
e.stopPropagation();
180-
if (!item.disabled) {
181-
this._itemSelected(e, !this.state.selected);
177+
e.stopPropagation();
178+
if (!item.disabled) {
179+
this._itemSelected(e, !this.state.selected);
180+
}
182181
}
183-
}}}>
182+
}}>
184183
<span>{item.label}</span>
185184
{
186185
// Render sublabel
@@ -190,7 +189,7 @@ export default class TreeItem extends React.Component<ITreeItemProps, ITreeItemS
190189
</div>
191190
}
192191
</div>
193-
</span>
192+
</span>
194193
);
195194
}
196195
}
@@ -283,11 +282,12 @@ export default class TreeItem extends React.Component<ITreeItemProps, ITreeItemS
283282
style={contentStyles}
284283
onClick={(e) => {
285284
if (this.props.selectionMode != TreeViewSelectionMode.None && treeItem.selectable != false) {
286-
e.stopPropagation();
287-
if (!treeItem.disabled && e.currentTarget === e.target) {
288-
this._itemSelected(e, !this.state.selected);
285+
e.stopPropagation();
286+
if (!treeItem.disabled && e.currentTarget === e.target) {
287+
this._itemSelected(e, !this.state.selected);
288+
}
289289
}
290-
}}}
290+
}}
291291
>
292292
{
293293
// Render checkbox (if item is selectable, Selection mode is not None, and showCheckboxes property is set to true)
@@ -325,7 +325,7 @@ export default class TreeItem extends React.Component<ITreeItemProps, ITreeItemS
325325
: null
326326
}
327327
</div>
328-
</div>
328+
</div>
329329
);
330330
}
331331
}

src/webparts/controlsTest/components/ControlsTest.tsx

Lines changed: 14 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -37,11 +37,8 @@ import { Carousel, CarouselButtonsLocation, CarouselButtonsDisplay } from '../..
3737
import { TimeDisplayControlType } from '../../../controls/dateTimePicker/TimeDisplayControlType';
3838
import { GridLayout } from '../../../GridLayout';
3939
import { ComboBoxListItemPicker } from '../../../';
40-
import {TreeView,ITreeItem,TreeItemActionsDisplayMode,TreeViewSelectionMode} from '../../../controls/treeView';
41-
//import { ITreeItem } from '../../../controls/treeView/ITreeItem';
40+
import { TreeView, ITreeItem, TreeItemActionsDisplayMode, TreeViewSelectionMode } from '../../../controls/treeView';
4241
import { IIconProps } from 'office-ui-fabric-react/lib/Icon';
43-
44-
4542
import { ISize } from 'office-ui-fabric-react/lib/Utilities';
4643

4744
// Used to render document cards
@@ -937,19 +934,17 @@ export default class ControlsTest extends React.Component<IControlsTestProps, IC
937934
</div>
938935

939936
<div>
940-
Demo of Tree View
941-
<TreeView items={this.treeitems}
942-
defaultExpanded={false}
943-
selectionMode={TreeViewSelectionMode.Multiple}
944-
showCheckboxes={false}
945-
treeItemActionsDisplayMode={TreeItemActionsDisplayMode.ContextualMenu}
946-
defaultSelectedKeys={['R2', '6']}
947-
onExpandCollapse={this.onExpandCollapseTree}
948-
onSelect={this.onItemSelected}
949-
>
950-
951-
</TreeView>
952-
</div>
937+
<h3>TreeView:</h3>
938+
<TreeView items={this.treeitems}
939+
defaultExpanded={false}
940+
selectionMode={TreeViewSelectionMode.Multiple}
941+
showCheckboxes={false}
942+
treeItemActionsDisplayMode={TreeItemActionsDisplayMode.ContextualMenu}
943+
defaultSelectedKeys={['R2', '6']}
944+
onExpandCollapse={this.onExpandCollapseTree}
945+
onSelect={this.onItemSelected}>
946+
</TreeView>
947+
</div>
953948
</div>
954949
);
955950
}
@@ -962,10 +957,8 @@ export default class ControlsTest extends React.Component<IControlsTestProps, IC
962957
console.log("items selected: " + items.length);
963958
}
964959

965-
966-
967960
private skypeCheckIcon: IIconProps = { iconName: 'SkypeCheck' };
968-
private treeitems = [
961+
private treeitems = [
969962
{
970963
key: "R1",
971964
label: "Root",
@@ -995,7 +988,7 @@ export default class ControlsTest extends React.Component<IControlsTestProps, IC
995988
label: "Child 1",
996989
subLabel: "This is a sub label for node",
997990
actions: [{
998-
title:"Share",
991+
title: "Share",
999992
iconProps: {
1000993
iconName: 'Share'
1001994
},

0 commit comments

Comments
 (0)