Skip to content

Commit c652fcf

Browse files
authored
Merge pull request #33 from SharePoint/dev
Bug fixes for version 1.1.2
2 parents 8fc6c95 + 2969370 commit c652fcf

File tree

8 files changed

+22
-16
lines changed

8 files changed

+22
-16
lines changed

.github/ISSUE_TEMPLATE.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
Thank you for reporting an issue, suggesting an enhancement, or asking a question. We appreciate your feedback - to help the team understand your
22
needs please complete the below template to ensure we have the details to help. Thanks!
33

4-
**Please check out the [documentation](https://github.com/SharePoint/sp-dev-fx-controls-react/wiki) to see if your question is already addressed there. This will help us ensure our documentation is up to date.**
4+
**Please check out the [documentation](https://sharepoint.github.io/sp-dev-fx-controls-react/) to see if your question is already addressed there. This will help us ensure our documentation is up to date.**
55

66
#### Category
77
[ ] Enhancement

CHANGELOG.md

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
11
# Releases
22

3+
## 1.1.2
4+
5+
- Fix for WebPartTitle control to inherit color
6+
- Improved telemetry with some object checks
7+
38
## 1.1.1
49

510
- Removed operation name from telemetry
@@ -9,7 +14,7 @@
914
- Telemetry added
1015

1116
## 1.0.0
12-
- **New control**: WebPartTilte control got added.
17+
- **New control**: WebPartTitle control got added.
1318
- **Enhancement**: ListView control got extended with the ability to specify a set of preselected items.
1419

1520
## Beta 1.0.0-beta.8

docs/documentation/docs/about/release-notes.md

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
11
# Releases
22

3+
## 1.1.2
4+
5+
- Fix for WebPartTitle control to inherit color
6+
- Improved telemetry with some object checks
7+
38
## 1.1.1
49

510
- Removed operation name from telemetry
@@ -9,7 +14,7 @@
914
- Telemetry added
1015

1116
## 1.0.0
12-
- **New control**: WebPartTilte control got added.
17+
- **New control**: WebPartTitle control got added.
1318
- **Enhancement**: ListView control got extended with the ability to specify a set of preselected items.
1419

1520
## Beta 1.0.0-beta.8

docs/guides/mpa.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ Before you start contributing to this project, you will need Node.js. This proje
1717

1818
### Documentation
1919

20-
SharePoint Framework Property Controls uses [MkDocs](http://www.mkdocs.org) to publish documentation pages. See more information about installing MkDocs on your operating system at http://www.mkdocs.org/#installation.
20+
SharePoint Framework React Controls uses [MkDocs](http://www.mkdocs.org) to publish documentation pages. See more information about installing MkDocs on your operating system at http://www.mkdocs.org/#installation.
2121

2222
Also, documentation uses custom MkDocs theme that should be installed as well. See [Material theme for MkDocs](https://squidfunk.github.io/mkdocs-material/).
2323

package.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "@pnp/spfx-controls-react",
33
"description": "Reusable React controls for SharePoint Framework solutions",
4-
"version": "1.1.1",
4+
"version": "1.1.2",
55
"engines": {
66
"node": ">=0.10.0"
77
},
@@ -57,5 +57,7 @@
5757
"bugs": {
5858
"url": "https://github.com/SharePoint/sp-dev-fx-controls-react/issues"
5959
},
60+
"main":"lib/index.js",
61+
6062
"homepage": "https://github.com/SharePoint/sp-dev-fx-controls-react"
6163
}

src/common/appInsights/index.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,9 @@ import {Environment,EnvironmentType} from "@microsoft/sp-core-library";
55
AppInsights.downloadAndSetup({ instrumentationKey: "9f59b81e-d2ed-411e-a961-8bcf3f7f04d0" });
66

77
// Remove operation name from the telemetry
8-
AppInsights.context.operation.name = null;
8+
if (AppInsights.context && AppInsights.context.operation && AppInsights.context.operation.name) {
9+
AppInsights.context.operation.name = null;
10+
}
911

1012
export function track(componentName: string, properties: any = {}): void {
1113
AppInsights.trackEvent(componentName, {

src/controls/webPartTitle/WebPartTitle.module.scss

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
background-color: transparent;
99
border: none;
1010
box-sizing: border-box;
11+
color: inherit;
1112
display: block;
1213
font-family: inherit;
1314
font-size: inherit;

src/controls/webPartTitle/WebPartTitle.tsx

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ export class WebPartTitle extends React.Component<IWebPartTitleProps, {}> {
4242
*/
4343
public render(): React.ReactElement<IWebPartTitleProps> {
4444
return (
45-
<div className={`${styles.webPartTitle} ${this.props.className}` }>
45+
<div className={`${styles.webPartTitle} ${this.props.className ? this.props.className : ''}` }>
4646
{
4747
this.props.displayMode === DisplayMode.Edit && <textarea placeholder={strings.WebPartTitlePlaceholder} aria-label={strings.WebPartTitleLabel} onChange={this._onChange} defaultValue={this.props.title}></textarea>
4848
}
@@ -54,12 +54,3 @@ export class WebPartTitle extends React.Component<IWebPartTitleProps, {}> {
5454
);
5555
}
5656
}
57-
58-
59-
60-
61-
62-
63-
/*
64-
65-
*/

0 commit comments

Comments
 (0)