PR review

Author: milanholemans

src/common/SPEntities.ts

@@ -7,7 +7,7 @@
 /**
  * Represents SP List ContentType
  */
-export interface ISPContentType {
+export interface ISPListContentType {
     Id: ISPContentTypeId;
     Name?: string;
     Description?: string;
@@ -19,6 +19,10 @@ export interface ISPContentType {
     DocumentTemplateUrl?: string;
     SchemaXml?: string;
 }
+
+// Alias for ISPListContentType
+export interface ISPContentType extends ISPListContentType {}
+
 /**
  * Represents SP List
  */

src/controls/contentTypePicker/ContentTypePicker.tsx

@@ -3,8 +3,9 @@ import React from 'react';
 import { IContentTypePickerProps, IContentTypePickerState } from './IContentTypePicker';
 import { ISPService } from '../../services/ISPService';
 import { SPServiceFactory } from '../../services/SPServiceFactory';
-import { cloneDeep } from 'lodash';
-import { Dropdown, IDropdownOption, IDropdownProps, Spinner, SpinnerSize } from 'office-ui-fabric-react';
+import cloneDeep from 'lodash/cloneDeep';
+import { Dropdown, IDropdownOption, IDropdownProps } from 'office-ui-fabric-react/lib/Dropdown';
+import { Spinner, SpinnerSize } from 'office-ui-fabric-react/lib/Spinner';
 
 const EMPTY_CONTENTTYPE_KEY = 'NO_CONTENTTYPE_SELECTED';
 

src/services/SPService.ts

@@ -23,12 +23,7 @@ export default class SPService implements ISPService {
 
   public async getContentTypes(options?: IContentTypesOptions): Promise<ISPContentType[]> {
     try {
-      let queryUrlString: string = `${this._webAbsoluteUrl}/_api/web`;
-      if (options.listId) {
-        queryUrlString += `/lists('${options.listId}')`;
-      }
-      queryUrlString += `/ContentTypes?`;
-
+      const queryUrlString: string = options.listId ? `${this._webAbsoluteUrl}/_api/web/lists('${options.listId}')/ContentTypes?` : `${this._webAbsoluteUrl}/_api/web/ContentTypes?`;
       const queryUrl = new URL(queryUrlString);
 
       if (options.orderBy) {