Skip to content

Commit d75a98c

Browse files
Placeholder: fix failing tests
1 parent f5cf944 commit d75a98c

File tree

1 file changed

+14
-9
lines changed

1 file changed

+14
-9
lines changed

src/controls/placeholder/PlaceholderComponent.test.tsx

Lines changed: 14 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
/// <reference types="sinon" />
22

33
import * as React from 'react';
4-
import { assert, expect } from 'chai';
4+
import { expect } from 'chai';
55
import { mount, ReactWrapper } from 'enzyme';
6+
import { setIconOptions } from 'office-ui-fabric-react/lib/Styling';
67
import { Placeholder } from './PlaceholderComponent';
7-
import { IPlaceholderProps } from './IPlaceholderComponent';
88
import styles from './PlaceholderComponent.module.scss';
99

1010
declare const sinon;
@@ -18,19 +18,26 @@ describe('<Placeholder />', () => {
1818
const dummyLabel = "Dummy label";
1919
const dummyOnConfigure = sinon.spy((evt) => { /* Nothing to do here */ });
2020

21+
before(() => {
22+
// Suppress icon warnings.
23+
setIconOptions({
24+
disableWarnings: true
25+
});
26+
})
27+
2128
afterEach(() => {
2229
placeholder.unmount();
2330
});
2431

25-
it('Test placeholder without button', (done) => {
32+
it('Test that placeholder renders', (done) => {
2633
placeholder = mount(<Placeholder description={dummyDescription} iconName={dummyIcon} iconText={dummyText} />);
2734
done();
2835
});
2936

3037
it('Test placeholder without button', (done) => {
3138
placeholder = mount(<Placeholder description={dummyDescription} iconName={dummyIcon} iconText={dummyText} />);
3239

33-
expect(placeholder.find('i.ms-Icon--Add')).to.have.length(1);
40+
expect(placeholder.find('i[data-icon-name="Add"]')).to.have.length(1);
3441

3542
expect(placeholder.find(`.${styles.placeholderText}`)).to.have.length(1);
3643
expect(placeholder.find(`.${styles.placeholderText}`).text()).to.be.equal(dummyText);
@@ -45,24 +52,22 @@ describe('<Placeholder />', () => {
4552
it('Test placeholder with custom classname', (done) => {
4653
placeholder = mount(<Placeholder description={dummyDescription} iconName={dummyIcon} iconText={dummyText} contentClassName={dummyClass} />);
4754

48-
expect(placeholder.find(`div.${dummyClass}`)).to.have.length(1);
49-
expect(placeholder.find(`div.${dummyClass} .ms-Icon`)).to.have.length(1);
50-
51-
expect(placeholder.find(`div.${dummyClass} button`)).to.have.length(0);
55+
expect(placeholder.find(`div.${styles.placeholder}.${dummyClass}`)).to.have.length(1);
5256
done();
5357
});
5458

5559
it('Test placeholder with null values', (done) => {
5660
placeholder = mount(<Placeholder description={null} iconName={null} iconText={null} />);
5761

58-
expect(placeholder.find(`div .ms-Icon`)).to.have.length(0);
62+
expect(placeholder.find('i[data-icon-name="Add"]')).to.have.length(0);
5963

6064
expect(placeholder.find(`div .${styles.placeholderText}`)).to.have.length(1);
6165
expect(placeholder.find(`div .${styles.placeholderText}`).text()).to.be.equal('');
6266

6367
expect(placeholder.find(`div .${styles.placeholderDescriptionText}`)).to.have.length(1);
6468
expect(placeholder.find(`div .${styles.placeholderDescriptionText}`).text()).to.be.equal('');
6569

70+
expect(placeholder.find('button')).to.have.length(0);
6671
done();
6772
});
6873

0 commit comments

Comments
 (0)