in the process of updating to 1.15.2

Author: AJIXuMuK

.eslintrc.js

@@ -6,7 +6,6 @@ const fs = require('fs');
 const BundleAnalyzerPlugin = require('webpack-bundle-analyzer').BundleAnalyzerPlugin;
 
 build.addSuppression(`Warning - [sass] The local CSS class 'ms-Grid' is not camelCase and will not be type-safe.`);
-build.addSuppression(/Warning/gi);
 
 // Update the version number in the version.ts file
 gulp.task('versionUpdater', (done) => {

gulpfile.js

@@ -66,7 +66,6 @@
     "@microsoft/eslint-config-spfx": "1.15.2",
     "@microsoft/eslint-plugin-spfx": "1.15.2",
     "@microsoft/microsoft-graph-types": "^2.1.0",
-    "@microsoft/rush-stack-compiler-3.9": "0.4.47",
     "@microsoft/rush-stack-compiler-4.5": "0.2.2",
     "@microsoft/sp-build-web": "1.15.2",
     "@microsoft/sp-module-interfaces": "1.15.2",
@@ -91,7 +90,6 @@
     "codecov": "3.8.3",
     "enzyme": "^3.11.0",
     "enzyme-adapter-react-16": "^1.15.6",
-    "eslint": "8.7.0",
     "eslint-plugin-react-hooks": "4.3.0",
     "gulp": "4.0.2",
     "husky": "^6.0.0",

package-lock.json

@@ -4,7 +4,7 @@ export class RequestClientMock extends SPHttpClient {
     public Requests: { url: string, method: string, options?: ISPHttpClientOptions, resultString: string }[] = [];
     public OnRequest: (url: string, method: string, options?: ISPHttpClientOptions) => void;
     public fetch(url: string, configuration: SPHttpClientConfiguration, options: ISPHttpClientOptions): Promise<SPHttpClientResponse> {
-        let mockedResponse = this.Requests.filter(req => req.method === options.method && req.url == url)[0];
+        let mockedResponse = this.Requests.filter(req => req.method === options.method && req.url === url)[0];
         let response: Response;
         if (mockedResponse) {
             response = new Response(mockedResponse.resultString, {

package.json

@@ -39,7 +39,7 @@ export class GeneralHelper {
         let result: string = null;
         let placeholdersString: string = null;
 
-        if (formatParts[0] == '0')
+        if (formatParts[0] === '0')
             return format.substring(2);
         const isFuture: boolean = formatParts[1] === '1';
         const formatType: string = formatParts[2];
@@ -60,7 +60,7 @@ export class GeneralHelper {
                 result = isFuture ? strings.DateTime['L_RelativeDateTime_AboutAnHourFuture'] : strings.DateTime['L_RelativeDateTime_AboutAnHour'];
                 break;
             case '5':
-                if (timeString == null) {
+                if (timeString === null) {
                     result = isFuture ? strings.DateTime['L_RelativeDateTime_Tomorrow'] : strings.DateTime['L_RelativeDateTime_Yesterday'];
                 }
                 else {
@@ -74,7 +74,7 @@ export class GeneralHelper {
                     Number(timeString));
                 break;
             case '7':
-                if (dayString == null) {
+                if (dayString === null) {
                     result = timeString;
                 }
                 else {
@@ -90,9 +90,9 @@ export class GeneralHelper {
             case '9':
                 result = strings.DateTime['L_RelativeDateTime_Today'];
         }
-        if (placeholdersString != null) {
+        if (placeholdersString !== null) {
             result = placeholdersString.replace("{0}", timeString);
-            if (dayString != null) {
+            if (dayString !== null) {
                 result = result.replace("{1}", dayString);
             }
         }
@@ -104,7 +104,7 @@ export class GeneralHelper {
      * I've tried to rename all the vars to have meaningful names... but some were too unclear
      */
     public static getLocalizedCountValue(format: string, first: string, second: number): string {
-        if (format == undefined || first == undefined || second == undefined)
+        if (format === undefined || first === undefined || second === undefined)
             return null;
         let result: string = '';
         let a = -1;
@@ -113,19 +113,19 @@ export class GeneralHelper {
         for (let firstOperandOptionsIdx = 0, firstOperandOptionsLen = firstOperandOptions.length; firstOperandOptionsIdx < firstOperandOptionsLen; firstOperandOptionsIdx++) {
             const firstOperandOption: string = firstOperandOptions[firstOperandOptionsIdx];
 
-            if (firstOperandOption == null || firstOperandOption === '')
+            if (firstOperandOption === null || firstOperandOption === '')
                 continue;
             let optionParts: string[] = firstOperandOption.split(',');
 
             for (var optionPartsIdx = 0, optionPartsLen = optionParts.length; optionPartsIdx < optionPartsLen; optionPartsIdx++) {
                 const optionPart: string = optionParts[optionPartsIdx];
 
-                if (optionPart == null || optionPart === '')
+                if (optionPart === null || optionPart === '')
                     continue;
                 if (isNaN(optionPart.parseNumberInvariant())) {
                     const dashParts: string[] = optionPart.split('-');
 
-                    if (dashParts == null || dashParts.length !== 2)
+                    if (dashParts === null || dashParts.length !== 2)
                         continue;
                     var j, n;
 
@@ -165,7 +165,7 @@ export class GeneralHelper {
         if (a !== -1) {
             var e = format.split('||');
 
-            if (e != null && e[a] != null && e[a] != '')
+            if (e !== null && e[a] !== null && e[a] !== '')
                 result = e[a];
         }
         return result;
@@ -206,7 +206,7 @@ export class GeneralHelper {
      * @param value value
      */
     public static isDefined(value): boolean {
-        return value != null;
+        return value !== null;
     }
 
     /**
@@ -263,7 +263,7 @@ export class GeneralHelper {
     }
 
     public static formatBytes(bytes, decimals) {
-      if (bytes == 0) {
+      if (bytes === 0) {
         return strings.EmptyFileSize;
       }
 

src/common/mocks/RequestClientMock.ts

@@ -111,7 +111,7 @@ export const AdaptiveCardDesigner = (props: IAdaptiveCardDesignerHostProps) => {
             CardDesigner.ToolbarCommands.NewCard,
             (sender) => {
                 let text = 'Do you want to create a new Card?';
-                if (confirm(text) == true) {
+                if (confirm(text) === true) {
                     cardDesigner.setCard((props.newCardPayload) ? props.newCardPayload : EmptyCard);
                     cardDesigner.clearUndoStack();
                     cardDesigner.designerSurface.updateLayout(true);

src/common/utilities/GeneralHelper.ts

@@ -47,7 +47,7 @@ export class NameValuePairPropertyEditor extends PropertySheetEntry {
             );
         }
 
-        if (nameValuePairs.length == 0) {
+        if (nameValuePairs.length === 0) {
             let messageTextBlock = new Adaptive.TextBlock();
             messageTextBlock.spacing = Adaptive.Spacing.Small;
             messageTextBlock.text = this.messageIfEmpty;
@@ -136,4 +136,4 @@ export class NameValuePairPropertyEditor extends PropertySheetEntry {
         readonly messageIfEmpty: string = "This collection is empty") {
         super(targetVersion);
     }
-}
+}

src/controls/adaptiveCardDesignerHost/AdaptiveCardDesigner.tsx

@@ -247,13 +247,13 @@ const ActionButton = (props: IActionButtonProps) => {
                 </div>
             </CompoundButton>;
     } else {
-        if (props.style.toLocaleLowerCase().trim() == 'positive') {
+        if (props.style.toLocaleLowerCase().trim() === 'positive') {
             control = <PrimaryButton
                 className={props.className}
                 text={props.text}
                 theme={theme}
                 onClick={props.actionClickHandler} />;
-        } else if (props.style.toLocaleLowerCase().trim() == 'destructive') {
+        } else if (props.style.toLocaleLowerCase().trim() === 'destructive') {
             const dangerButtonTheme: ITheme = createTheme({ palette: redPalette });
             control = <PrimaryButton
                 className={props.className}

src/controls/adaptiveCardDesignerHost/fluentUI/peers/Shared.ts

@@ -122,7 +122,7 @@ export class FluentUIChoiceSetInput extends Input {
 
         let control = () =>
             <>
-                {this.isMultiSelect == false && this.style === "expanded" &&
+                {this.isMultiSelect === false && this.style === "expanded" &&
                     <ThemeProvider theme={theme} style={{ backgroundColor: "transparent" }}>
                         <ChoiceGroup
                             defaultSelectedKey={this.defaultValue}
@@ -136,7 +136,7 @@ export class FluentUIChoiceSetInput extends Input {
                     </ThemeProvider>
                 }
 
-                {this.isMultiSelect == true && this.style === "expanded" &&
+                {this.isMultiSelect === true && this.style === "expanded" &&
                     <Stack tokens={{ childrenGap: this.hostConfig.spacing.default }}>
                         {this.choices.map((x, index) => {
                             let defaultChecked = this.defaultSelectedValues.indexOf(x.value) > -1;
@@ -150,7 +150,7 @@ export class FluentUIChoiceSetInput extends Input {
                                         this.valueChanged();
                                     }}
                                     componentRef={(input) => {
-                                        if (index == 0)
+                                        if (index === 0)
                                             this.refControl = input;
                                     }}
                                 />
@@ -849,7 +849,7 @@ export class FluentUIToggleInput extends Input {
     }
 
     public get value(): string | undefined {
-        if (this._value != null && this._value != undefined) {
+        if (this._value !== null && this._value !== undefined) {
             return this._value ? this.valueOn : this.valueOff;
         } else {
             if (this.isRequired) {