[DynamicForm] Creating a document set sometimes throws a 409 save conflict.

[martinlingstuyl]

Category

[ ] Enhancement

[X] Bug

[ ] Question

Version

Please specify what version of the library you are using: [3.20]

Expected / Desired Behavior / Question

When creating a document set using a dynamic form, this should just work.

Observed Behavior

For some tenants, and only sometimes, a 409 save conflict exception is thrown when submitting the form. It appears the folder is created still, but not updated to be a docset with all the filled in metadata.

The issue occurs on this line:

sp-dev-fx-controls-react/src/controls/dynamicForm/DynamicForm.tsx

Line 614 in 873aa00

const iur = await library.items.getById(folderId).update(objects);

Steps to Reproduce

It's hard to reproduce unfortunately. My customer has it all the time (in two M365 tenants), but in my tenant I haven't seen the issue occur yet.

Fix

What we could do is add some intelligence to retry updating the list item based on the error that's returned.

[martinlingstuyl]

Hi guys, I'm not sure if you like my implementation, but I needed to do fix this for a customer, so I've created a PR for it as well. Let me know if you've got thoughts on how this could be better. I know it's problematic because the issue is so hard to reproduce reliably.

[joelfmrodrigues]

PR merged and will be fixed in the next release. The fix will be available in the beta release within a few minutes

[aminezemzemi]

Is it possible to create Document Set by using this api ?

await spHttpClient.post(
${webUrl}/_api/SP.DocumentSet.DocumentSet.Create,
{
parentFolder: { ServerRelativeUrl: parentPath },
name: folderName,
contentTypeId: documentSetContentTypeId
}
);

I tested the component in a document set and it doesn't work

      const library = await sp.web.lists.getById(listId);
      const folderFileName = this.getFolderName(objects);
      const folder = !this.props.folderPath ? library.rootFolder : await this.getFolderByPath(this.props.folderPath, library.rootFolder);
      const newFolder = await folder.addSubFolderUsingPath(folderFileName);
      const fields = await newFolder.listItemAllFields();

      if (fields[idField]) {
        // Read the ID of the just created folder or Document Set
        const folderId = fields[idField];

        // Set the content type ID for the target item
        objects[contentTypeIdField] = contentTypeId;
        // Update the just created folder or Document Set
        const iur = await this.updateListItemRetry(library, folderId, objects);