Skip to content

Commit 30ac1de

Browse files
authored
Merge pull request #1473 from HarminderSethi/main
bug fix for root site file path in copy path command
2 parents 1c1edab + c86fbc0 commit 30ac1de

File tree

11 files changed

+7541
-30971
lines changed

11 files changed

+7541
-30971
lines changed

.gitignore

Lines changed: 43 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -327,3 +327,46 @@ samples/react-application-my-lists-notifications/release/assets/my-lists-notific
327327
samples/react-application-my-lists-notifications/release/assets/MyListsNotificationsApplicationCustomizerStrings_en-us_f40e9d8f16425c3069e4c6998aa3fc70.js
328328
samples/react-application-my-lists-notifications/release/component-dependency-audit/react-application-my-lists-notifications.json
329329
samples/react-application-my-lists-notifications/release/manifests/c1a3cdb7-6581-4966-832a-49952eb1feb7.manifest.json
330+
samples/react-application-chatbubble-copilot/lib/index.d.ts
331+
samples/react-application-chatbubble-copilot/lib/index.d.ts.map
332+
samples/react-application-chatbubble-copilot/lib/index.js
333+
samples/react-application-chatbubble-copilot/lib/index.js.map
334+
samples/react-application-chatbubble-copilot/lib/extensions/pvaSso/PvaSsoApplicationCustomizer.d.ts
335+
samples/react-application-chatbubble-copilot/lib/extensions/pvaSso/PvaSsoApplicationCustomizer.d.ts.map
336+
samples/react-application-chatbubble-copilot/lib/extensions/pvaSso/PvaSsoApplicationCustomizer.js
337+
samples/react-application-chatbubble-copilot/lib/extensions/pvaSso/PvaSsoApplicationCustomizer.js.map
338+
samples/react-application-chatbubble-copilot/lib/extensions/pvaSso/PvaSsoApplicationCustomizer.manifest.json
339+
samples/react-application-chatbubble-copilot/lib/extensions/pvaSso/components/ChatBot.d.ts
340+
samples/react-application-chatbubble-copilot/lib/extensions/pvaSso/components/ChatBot.d.ts.map
341+
samples/react-application-chatbubble-copilot/lib/extensions/pvaSso/components/ChatBot.js
342+
samples/react-application-chatbubble-copilot/lib/extensions/pvaSso/components/ChatBot.js.map
343+
samples/react-application-chatbubble-copilot/lib/extensions/pvaSso/components/ChatbotContainer.d.ts
344+
samples/react-application-chatbubble-copilot/lib/extensions/pvaSso/components/ChatbotContainer.d.ts.map
345+
samples/react-application-chatbubble-copilot/lib/extensions/pvaSso/components/ChatbotContainer.js
346+
samples/react-application-chatbubble-copilot/lib/extensions/pvaSso/components/ChatbotContainer.js.map
347+
samples/react-application-chatbubble-copilot/lib/extensions/pvaSso/components/ChatToggleButton.d.ts
348+
samples/react-application-chatbubble-copilot/lib/extensions/pvaSso/components/ChatToggleButton.d.ts.map
349+
samples/react-application-chatbubble-copilot/lib/extensions/pvaSso/components/ChatToggleButton.js
350+
samples/react-application-chatbubble-copilot/lib/extensions/pvaSso/components/ChatToggleButton.js.map
351+
samples/react-application-chatbubble-copilot/lib/extensions/pvaSso/components/PVAChatbotDialog.d.ts
352+
samples/react-application-chatbubble-copilot/lib/extensions/pvaSso/components/PVAChatbotDialog.d.ts.map
353+
samples/react-application-chatbubble-copilot/lib/extensions/pvaSso/components/PVAChatbotDialog.js
354+
samples/react-application-chatbubble-copilot/lib/extensions/pvaSso/components/PVAChatbotDialog.js.map
355+
samples/react-application-chatbubble-copilot/lib/extensions/pvaSso/loc/en-us.js
356+
samples/react-application-chatbubble-copilot/lib/extensions/pvaSso/services/ConfigurationService.d.ts
357+
samples/react-application-chatbubble-copilot/lib/extensions/pvaSso/services/ConfigurationService.d.ts.map
358+
samples/react-application-chatbubble-copilot/lib/extensions/pvaSso/services/ConfigurationService.js
359+
samples/react-application-chatbubble-copilot/lib/extensions/pvaSso/services/ConfigurationService.js.map
360+
samples/react-application-chatbubble-copilot/lib/extensions/pvaSso/services/MSALWrapper.d.ts
361+
samples/react-application-chatbubble-copilot/lib/extensions/pvaSso/services/MSALWrapper.d.ts.map
362+
samples/react-application-chatbubble-copilot/lib/extensions/pvaSso/services/MSALWrapper.js
363+
samples/react-application-chatbubble-copilot/lib/extensions/pvaSso/services/MSALWrapper.js.map
364+
samples/react-application-chatbubble-copilot/lib/extensions/pvaSso/styles/PvaSsoApplicationCustomizer.module.css
365+
samples/react-application-chatbubble-copilot/lib/extensions/pvaSso/styles/PvaSsoApplicationCustomizer.module.scss.d.ts
366+
samples/react-application-chatbubble-copilot/lib/extensions/pvaSso/styles/PvaSsoApplicationCustomizer.module.scss.d.ts.map
367+
samples/react-application-chatbubble-copilot/lib/extensions/pvaSso/styles/PvaSsoApplicationCustomizer.module.scss.js
368+
samples/react-application-chatbubble-copilot/lib/extensions/pvaSso/styles/PvaSsoApplicationCustomizer.module.scss.js.map
369+
samples/react-application-chatbubble-copilot/lib/extensions/pvaSso/types/IChatBotProps.d.ts
370+
samples/react-application-chatbubble-copilot/lib/extensions/pvaSso/types/IChatBotProps.d.ts.map
371+
samples/react-application-chatbubble-copilot/lib/extensions/pvaSso/types/IChatBotProps.js
372+
samples/react-application-chatbubble-copilot/lib/extensions/pvaSso/types/IChatBotProps.js.map

.metadata/samples.json

Lines changed: 12 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -7348,18 +7348,16 @@
73487348
]
73497349
},
73507350
{
7351-
"name": "pnp-sp-dev-spfx-extensions-react-utility-extensions",
7351+
"name": "pnp-sp-dev-spfx-extensions-react-YOUR-SOLUTION-NAME-GOES-HERE",
73527352
"source": "pnp",
73537353
"title": "Copy Path and Copy Name List view command set extensions",
7354-
"shortDescription": "List view command set extensions with below functionalities: Copy Path and Copy Name.",
7355-
"url": "https://github.com/pnp/sp-dev-fx-extensions/tree/main/samples/react-utility-extensions",
7354+
"shortDescription": "List view command set extensions with below functionalities",
7355+
"url": "https://github.com/pnp/sp-dev-fx-extensions/tree/main/samples/YOUR-SOLUTION-NAME-GOES-HERE",
73567356
"longDescription": [
7357-
"List view command set extensions with below functionalities:",
7358-
"1. Copy Path allows to copy the path of the document without breaking the permission inheritance.",
7359-
"2. Copy Name allows to copy the name of the document without using the currently available rename functionality."
7357+
"List view command set extensions with below functionalities"
73607358
],
7361-
"creationDateTime": "2023-10-04",
7362-
"updateDateTime": "2024-08-28",
7359+
"creationDateTime": "2023-10-22",
7360+
"updateDateTime": "2025-02-27",
73637361
"products": [
73647362
"SharePoint"
73657363
],
@@ -7370,24 +7368,25 @@
73707368
},
73717369
{
73727370
"key": "SPFX-VERSION",
7373-
"value": "1.19.0"
7371+
"value": "1.20.0"
73747372
}
73757373
],
73767374
"tags": [],
73777375
"categories": [
7378-
"SPFX-COMMAND-EXTENSION"
7376+
"SPFX-APPLICATION-EXTENSION"
73797377
],
73807378
"thumbnails": [
73817379
{
7380+
"name": "CopyPathCopyNameExtenstions.png",
73827381
"type": "image",
73837382
"order": 100,
7384-
"url": "https://github.com/pnp/sp-dev-fx-extensions/raw/main/samples/react-utility-extensions/assets/CopyPathCopyNameExtenstions.png",
7385-
"alt": "Preview"
7383+
"url": "https://github.com/pnp/sp-dev-fx-webparts/raw/main/samples/react-utility-extensions/assets/CopyPathCopyNameExtenstions.png",
7384+
"alt": "Web Part Preview"
73867385
}
73877386
],
73887387
"authors": [
73897388
{
7390-
"gitHubAccount": "HarminderSethi",
7389+
"gitHubAccount": "https://github.com/HarminderSethi",
73917390
"pictureUrl": "https://github.com/HarminderSethi.png",
73927391
"name": "Harminder Singh"
73937392
}

samples/react-utility-extensions/.devcontainer/devcontainer.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
// For more information on how to run this SPFx project in a VS Code Remote Container, please visit https://aka.ms/spfx-devcontainer
22
{
3-
"name": "SPFx 1.19.0",
4-
"image": "docker.io/m365pnp/spfx:1.19.0",
3+
"name": "SPFx 1.20.0",
4+
"image": "docker.io/m365pnp/spfx:1.20.0",
55
// Set *default* container specific settings.json values on container create.
66
"settings": {},
77
// Add the IDs of extensions you want installed when the container is created.

samples/react-utility-extensions/.eslintrc.js

Lines changed: 1 addition & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -20,39 +20,7 @@ module.exports = {
2020
'@rushstack/security/no-unsafe-regexp': 1,
2121
// STANDARDIZED BY: @typescript-eslint\eslint-plugin\dist\configs\recommended.json
2222
'@typescript-eslint/adjacent-overload-signatures': 1,
23-
// STANDARDIZED BY: @typescript-eslint\eslint-plugin\dist\configs\recommended.json
24-
//
25-
// CONFIGURATION: By default, these are banned: String, Boolean, Number, Object, Symbol
26-
'@typescript-eslint/ban-types': [
27-
1,
28-
{
29-
'extendDefaults': false,
30-
'types': {
31-
'String': {
32-
'message': 'Use \'string\' instead',
33-
'fixWith': 'string'
34-
},
35-
'Boolean': {
36-
'message': 'Use \'boolean\' instead',
37-
'fixWith': 'boolean'
38-
},
39-
'Number': {
40-
'message': 'Use \'number\' instead',
41-
'fixWith': 'number'
42-
},
43-
'Object': {
44-
'message': 'Use \'object\' instead, or else define a proper TypeScript type:'
45-
},
46-
'Symbol': {
47-
'message': 'Use \'symbol\' instead',
48-
'fixWith': 'symbol'
49-
},
50-
'Function': {
51-
'message': 'The \'Function\' type accepts any function-like value.\nIt provides no type safety when calling the function, which can be a common source of bugs.\nIt also accepts things like class declarations, which will throw at runtime as they will not be called with \'new\'.\nIf you are expecting the function to accept certain arguments, you should explicitly define the function shape.'
52-
}
53-
}
54-
}
55-
],
23+
5624
// RATIONALE: Code is more readable when the type of every variable is immediately obvious.
5725
// Even if the compiler may be able to infer a type, this inference will be unavailable
5826
// to a person who is reviewing a GitHub diff. This rule makes writing code harder,

samples/react-utility-extensions/README.md

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -45,11 +45,12 @@ N/A
4545

4646
## Version history
4747

48-
| Version | Date | Comments |
49-
| ------- | ------------ | ----------------------- |
50-
| 1.0 | Oct 22, 2023 | Initial release |
51-
| 1.1 | Aug 28, 2024 | Upgraded to SPFx 1.19.0 |
52-
| 1.2 | Oct 11, 2024 | Upgraded to SPFx 1.20.0 |
48+
| Version | Date | Comments |
49+
| ------- | ------------ | ---------------------------------------------- |
50+
| 1.0 | Oct 22, 2023 | Initial release |
51+
| 1.1 | Aug 28, 2024 | Upgraded to SPFx 1.19.0 |
52+
| 1.2 | Oct 11, 2024 | Upgraded to SPFx 1.20.0 |
53+
| 1.3 | Oct 11, 2024 | Bug fix for missing site address for root site |
5354

5455
## Help
5556

samples/react-utility-extensions/assets/sample.json

Lines changed: 12 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,15 @@
11
[
22
{
3-
"name": "pnp-sp-dev-spfx-extensions-react-utility-extensions",
3+
"name": "pnp-sp-dev-spfx-extensions-react-YOUR-SOLUTION-NAME-GOES-HERE",
44
"source": "pnp",
55
"title": "Copy Path and Copy Name List view command set extensions",
6-
"shortDescription": "List view command set extensions with below functionalities: Copy Path and Copy Name.",
7-
"url": "https://github.com/pnp/sp-dev-fx-extensions/tree/main/samples/react-utility-extensions",
6+
"shortDescription": "List view command set extensions with below functionalities",
7+
"url": "https://github.com/pnp/sp-dev-fx-extensions/tree/main/samples/YOUR-SOLUTION-NAME-GOES-HERE",
88
"longDescription": [
9-
"List view command set extensions with below functionalities:",
10-
"1. Copy Path allows to copy the path of the document without breaking the permission inheritance.",
11-
"2. Copy Name allows to copy the name of the document without using the currently available rename functionality."
9+
"List view command set extensions with below functionalities"
1210
],
13-
"creationDateTime": "2023-10-04",
14-
"updateDateTime": "2024-08-28",
11+
"creationDateTime": "2023-10-22",
12+
"updateDateTime": "2025-02-27",
1513
"products": [
1614
"SharePoint"
1715
],
@@ -22,24 +20,25 @@
2220
},
2321
{
2422
"key": "SPFX-VERSION",
25-
"value": "1.19.0"
23+
"value": "1.20.0"
2624
}
2725
],
2826
"tags": [],
2927
"categories": [
30-
"SPFX-COMMAND-EXTENSION"
28+
"SPFX-APPLICATION-EXTENSION"
3129
],
3230
"thumbnails": [
3331
{
32+
"name": "CopyPathCopyNameExtenstions.png",
3433
"type": "image",
3534
"order": 100,
36-
"url": "https://github.com/pnp/sp-dev-fx-extensions/raw/main/samples/react-utility-extensions/assets/CopyPathCopyNameExtenstions.png",
37-
"alt": "Preview"
35+
"url": "https://github.com/pnp/sp-dev-fx-webparts/raw/main/samples/react-utility-extensions/assets/CopyPathCopyNameExtenstions.png",
36+
"alt": "Web Part Preview"
3837
}
3938
],
4039
"authors": [
4140
{
42-
"gitHubAccount": "HarminderSethi",
41+
"gitHubAccount": "https://github.com/HarminderSethi",
4342
"pictureUrl": "https://github.com/HarminderSethi.png",
4443
"name": "Harminder Singh"
4544
}

0 commit comments

Comments
 (0)