fix: opts.extraBinPaths should not get mutated

zkochan · zkochan · commit 38bc83b8e975 · 2019-06-10T23:22:02.000+03:00
diff --git a/index.js b/index.js
@@ -101,7 +101,7 @@ function _incorrectWorkingDirectory (wd, pkg) {
 }
 
 function lifecycle_ (pkg, stage, wd, opts, env, cb) {
-  const pathArr = opts.extraBinPaths || []
+  const pathArr = [...opts.extraBinPaths || []]
   const p = wd.split(/[\\/]node_modules[\\/]/)
   let acc = path.resolve(p.shift())
 

Original file line number	Diff line number	Diff line change
`@@ -101,7 +101,7 @@ function _incorrectWorkingDirectory (wd, pkg) {`
`101`	`101`	`}`
`102`	`102`
`103`	`103`	`function lifecycle_ (pkg, stage, wd, opts, env, cb) {`
`104`		`- const pathArr = opts.extraBinPaths \|\| []`
	`104`	`+ const pathArr = [...opts.extraBinPaths \|\| []]`
`105`	`105`	`const p = wd.split(/[\\/]node_modules[\\/]/)`
`106`	`106`	`let acc = path.resolve(p.shift())`
`107`	`107`