refactor: remove _incorrectWorkingDirectory (#38)

* refactor: trust docker and ci and code spaces environment

* refactor: remove _incorrectWorkingDirectory

Author: BlackHole1

index.js

@@ -2,7 +2,6 @@
 
 exports = module.exports = lifecycle
 exports.makeEnv = makeEnv
-exports._incorrectWorkingDirectory = _incorrectWorkingDirectory
 
 const spawn = require('./lib/spawn')
 const { execute } = require('@yarnpkg/shell')
@@ -75,12 +74,6 @@ function lifecycle (pkg, stage, wd, opts) {
       validWd(wd || path.resolve(opts.dir, pkg.name), (er, wd) => {
         if (er) return reject(er)
 
-        if ((wd.indexOf(opts.dir) !== 0 || _incorrectWorkingDirectory(wd, pkg)) &&
-            !opts.unsafePerm && pkg.scripts[stage]) {
-          opts.log.warn(`"${stage}" script of "${pkg._id}" inside "${wd}" is skipped as the working directory seems suspicious. To run this lifecycle script anyway, use "--unsafe-perm".`)
-          return resolve()
-        }
-
         // set the env variables, then run scripts as a child process.
         const env = makeEnv(pkg, opts)
         env.npm_lifecycle_event = stage
@@ -114,10 +107,6 @@ function lifecycle (pkg, stage, wd, opts) {
   })
 }
 
-function _incorrectWorkingDirectory (wd, pkg) {
-  return wd.lastIndexOf(pkg.name) !== wd.length - pkg.name.length
-}
-
 function lifecycle_ (pkg, stage, wd, opts, env, cb) {
   env[PATH] = extendPath(wd, env[PATH], path.join(__dirname, 'node-gyp-bin'), opts)
 

test/index.js

@@ -7,32 +7,6 @@ const path = require('path')
 
 function noop () {}
 
-test('_incorrectWorkingDirectory: accepts wd for package that matches project\'s name', function (t) {
-  const wd = '/opt/my-time/node_modules/time'
-  const pkg = { name: 'time' }
-
-  t.equal(lifecycle._incorrectWorkingDirectory(wd, pkg), false)
-  t.end()
-})
-
-test('_incorrectWorkingDirectory: accepts wd for package that doesn\'t match project\'s name', function (t) {
-  const wd = '/opt/my-project/node_modules/time'
-  const pkg = { name: 'time' }
-
-  t.equal(lifecycle._incorrectWorkingDirectory(wd, pkg), false)
-  t.end()
-})
-
-test('_incorrectWorkingDirectory: rejects wd from other packages', function (t) {
-  const wd = '/opt/my-time/node_modules/time/invalid'
-  const pkg = {
-    name: 'time'
-  }
-
-  t.equal(lifecycle._incorrectWorkingDirectory(wd, pkg), true)
-  t.end()
-})
-
 test('runs scripts from .hooks directory even if no script is present in package.json', function (t) {
   const fixture = path.join(__dirname, 'fixtures', 'has-hooks')