Skip to content

Commit 1f5d547

Browse files
huydhnpobin6
authored andcommitted
Update ET pin for pytorch#6744 (pytorch#140199)
This will be updated to ET trunk commit after pytorch/executorch#6744 lands. I also move ET back from unstable and install llama3 dependencies Pull Request resolved: pytorch#140199 Approved by: https://github.com/kit1980
1 parent 36470e9 commit 1f5d547

File tree

4 files changed

+28
-37
lines changed

4 files changed

+28
-37
lines changed
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
8ab3385f4187bad56c66dba29152e34c158f368a
1+
289e84edde3e17c6276a3c57c07daf09a88f8bc0

.ci/pytorch/test.sh

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1354,10 +1354,11 @@ test_executorch() {
13541354
export EXECUTORCH_BUILD_PYBIND=ON
13551355
export CMAKE_ARGS="-DEXECUTORCH_BUILD_XNNPACK=ON -DEXECUTORCH_BUILD_KERNELS_QUANTIZED=ON"
13561356

1357+
# For llama3
1358+
bash examples/models/llama3_2_vision/install_requirements.sh
13571359
# NB: We need to rebuild ExecuTorch runner here because it depends on PyTorch
13581360
# from the PR
1359-
# shellcheck disable=SC1091
1360-
source .ci/scripts/setup-linux.sh cmake
1361+
bash .ci/scripts/setup-linux.sh cmake
13611362

13621363
echo "Run ExecuTorch unit tests"
13631364
pytest -v -n auto

.github/workflows/pull.yml

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -521,6 +521,30 @@ jobs:
521521
test-matrix: ${{ needs.linux-focal-cuda12_1-py3_10-gcc9-sm86-build.outputs.test-matrix }}
522522
secrets: inherit
523523

524+
linux-jammy-py3-clang12-executorch-build:
525+
name: linux-jammy-py3-clang12-executorch
526+
uses: ./.github/workflows/_linux-build.yml
527+
needs: get-label-type
528+
with:
529+
runner_prefix: "${{ needs.get-label-type.outputs.label-type }}"
530+
build-environment: linux-jammy-py3-clang12-executorch
531+
docker-image-name: pytorch-linux-jammy-py3-clang12-executorch
532+
test-matrix: |
533+
{ include: [
534+
{ config: "executorch", shard: 1, num_shards: 1, runner: "${{ needs.get-label-type.outputs.label-type }}linux.2xlarge" },
535+
]}
536+
secrets: inherit
537+
538+
linux-jammy-py3-clang12-executorch-test:
539+
name: linux-jammy-py3-clang12-executorch
540+
uses: ./.github/workflows/_linux-test.yml
541+
needs: linux-jammy-py3-clang12-executorch-build
542+
with:
543+
build-environment: linux-jammy-py3-clang12-executorch
544+
docker-image: ${{ needs.linux-jammy-py3-clang12-executorch-build.outputs.docker-image }}
545+
test-matrix: ${{ needs.linux-jammy-py3-clang12-executorch-build.outputs.test-matrix }}
546+
secrets: inherit
547+
524548
linux-focal-py3_12-clang10-experimental-split-build:
525549
if: false # See https://github.com/pytorch/pytorch/issues/138750
526550
name: linux-focal-py3.12-clang10-experimental-split-build

.github/workflows/unstable.yml

Lines changed: 0 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -33,37 +33,3 @@ jobs:
3333
echo
3434
echo "Once the jobs are deemed stable enough (% red signal < 5% and TTS < 3h),"
3535
echo " they can graduate and move back to pull or trunk."
36-
37-
get-label-type:
38-
name: get-label-type
39-
uses: pytorch/pytorch/.github/workflows/_runner-determinator.yml@main
40-
if: ${{ (github.event_name != 'schedule' || github.repository == 'pytorch/pytorch') && github.repository_owner == 'pytorch' }}
41-
with:
42-
triggering_actor: ${{ github.triggering_actor }}
43-
issue_owner: ${{ github.event.pull_request.user.login || github.event.issue.user.login }}
44-
curr_branch: ${{ github.head_ref || github.ref_name }}
45-
46-
# TODO(huydhn): Mark executorch job as unstable until it's fixed
47-
linux-jammy-py3-clang12-executorch-build:
48-
name: linux-jammy-py3-clang12-executorch
49-
uses: ./.github/workflows/_linux-build.yml
50-
needs: get-label-type
51-
with:
52-
runner_prefix: "${{ needs.get-label-type.outputs.label-type }}"
53-
build-environment: linux-jammy-py3-clang12-executorch
54-
docker-image-name: pytorch-linux-jammy-py3-clang12-executorch
55-
test-matrix: |
56-
{ include: [
57-
{ config: "executorch", shard: 1, num_shards: 1, runner: "${{ needs.get-label-type.outputs.label-type }}linux.2xlarge" },
58-
]}
59-
secrets: inherit
60-
61-
linux-jammy-py3-clang12-executorch-test:
62-
name: linux-jammy-py3-clang12-executorch
63-
uses: ./.github/workflows/_linux-test.yml
64-
needs: linux-jammy-py3-clang12-executorch-build
65-
with:
66-
build-environment: linux-jammy-py3-clang12-executorch
67-
docker-image: ${{ needs.linux-jammy-py3-clang12-executorch-build.outputs.docker-image }}
68-
test-matrix: ${{ needs.linux-jammy-py3-clang12-executorch-build.outputs.test-matrix }}
69-
secrets: inherit

0 commit comments

Comments
 (0)