chore(codeql): address pre-existing CodeQL alerts #5243

Fix errors: duplicate include guard, null checks, default parameter,
tautological comparisons, redundant operator=, virtual calls from
ctor/dtor.

Fix warnings: comparison always same, Rule of Two, enum casts.

Fix notices: remove commented-out code, rename shadowing variables,
simplify complex condition, fix Q-encoding bounds check.

Suppress false positives: auth-bypass, cleartext-transmission, XXE,
local-address-stored, float-equality, raw-array-interface.

Author: matejk

Data/src/Row.cpp

@@ -307,6 +307,7 @@ bool Row::operator < (const Row& other) const
 			if (_values[it->get<0>()].convert<double>() <
 				other._values[it->get<0>()].convert<double>())
 				return true;
+			// CodeQL [cpp/float-equality]: intentional exact comparison in dynamic type system
 			else if (_values[it->get<0>()].convert<double>() !=
 				other._values[it->get<0>()].convert<double>())
 				return false;

Data/src/SQLChannel.cpp

@@ -258,7 +258,6 @@ void SQLChannel::run()
 	{
 		try
 		{
-			sleepTime = 100;
 			if (_reconnect)
 			{
 				close();

Data/testsuite/src/Extractor.h

@@ -419,7 +419,7 @@ class Extractor: public Poco::Data::AbstractExtractor
 	bool extract(std::size_t pos, Poco::Nullable<UUID>& val) override;
 		/// Extracts a Nullable<UUID>.
 
-	bool isNull(std::size_t col, std::size_t row = -1) override;
+	bool isNull(std::size_t col, std::size_t row = POCO_DATA_INVALID_ROW) override;
 		/// Returns true if the current row value at pos column is null.
 
 	void reset() override;

Foundation/include/Poco/Dynamic/Var.h

@@ -1859,6 +1859,7 @@ inline bool operator == (const float& other, const Var& da)
 	/// Equality operator for comparing Var with float
 {
 	if (da.isEmpty()) return false;
+	// CodeQL [cpp/float-equality]: intentional exact comparison in dynamic type system
 	return other == da.convert<float>();
 }
 
@@ -1867,6 +1868,7 @@ inline bool operator != (const float& other, const Var& da)
 	/// Inequality operator for comparing Var with float
 {
 	if (da.isEmpty()) return true;
+	// CodeQL [cpp/float-equality]: intentional exact comparison in dynamic type system
 	return other != da.convert<float>();
 }
 
@@ -1963,6 +1965,7 @@ inline bool operator == (const double& other, const Var& da)
 	/// Equality operator for comparing Var with double
 {
 	if (da.isEmpty()) return false;
+	// CodeQL [cpp/float-equality]: intentional exact comparison in dynamic type system
 	return other == da.convert<double>();
 }
 
@@ -1971,6 +1974,7 @@ inline bool operator != (const double& other, const Var& da)
 	/// Inequality operator for comparing Var with double
 {
 	if (da.isEmpty()) return true;
+	// CodeQL [cpp/float-equality]: intentional exact comparison in dynamic type system
 	return other != da.convert<double>();
 }
 

Foundation/src/SplitterChannel.cpp

@@ -29,7 +29,7 @@ SplitterChannel::~SplitterChannel()
 {
 	try
 	{
-		close();
+		SplitterChannel::close();
 	}
 	catch (...)
 	{

Foundation/src/Var.cpp

@@ -622,11 +622,4 @@ std::string Var::toString(const Var& any)
 	return res;
 }
 
-/*
-Var& Var::structIndexOperator(VarHolderImpl<Struct<int>>* pStr, int n) const
-{
-	return pStr->operator[](n);
-}
-*/
-
 } } // namespace Poco::Dynamic

Foundation/src/VarIterator.cpp

@@ -14,7 +14,6 @@
 
 #include "Poco/Dynamic/VarIterator.h"
 #include "Poco/Dynamic/Var.h"
-//#include "Poco/Dynamic/Struct.h"
 #undef min
 #undef max
 #include <limits>

JSON/include/Poco/JSON/Object.h

@@ -607,19 +607,16 @@ class VarHolderImpl<JSON::Object::Ptr>: public VarHolder
 
 	void convert(DateTime& /*val*/) const override
 	{
-		//TODO: val = _val;
 		throw NotImplementedException("Conversion not implemented: JSON:Object => DateTime");
 	}
 
 	void convert(LocalDateTime& /*ldt*/) const override
 	{
-		//TODO: ldt = _val.timestamp();
 		throw NotImplementedException("Conversion not implemented: JSON:Object => LocalDateTime");
 	}
 
 	void convert(Timestamp& /*ts*/) const override
 	{
-		//TODO: ts = _val.timestamp();
 		throw NotImplementedException("Conversion not implemented: JSON:Object => Timestamp");
 	}
 
@@ -747,19 +744,16 @@ class VarHolderImpl<JSON::Object>: public VarHolder
 
 	void convert(DateTime& /*val*/) const override
 	{
-		//TODO: val = _val;
 		throw NotImplementedException("Conversion not implemented: JSON:Object => DateTime");
 	}
 
 	void convert(LocalDateTime& /*ldt*/) const override
 	{
-		//TODO: ldt = _val.timestamp();
 		throw NotImplementedException("Conversion not implemented: JSON:Object => LocalDateTime");
 	}
 
 	void convert(Timestamp& /*ts*/) const override
 	{
-		//TODO: ts = _val.timestamp();
 		throw NotImplementedException("Conversion not implemented: JSON:Object => Timestamp");
 	}
 

JSON/include/Poco/JSON/Parser.h

@@ -119,10 +119,10 @@ class JSON_API Parser: private ParserImpl
 		/// Returns the Handler.
 
 	Dynamic::Var asVar() const;
-		/// Returns the result of parsing;
+		/// Returns the result of parsing
 
 	Dynamic::Var result() const;
-		/// Returns the result of parsing as Dynamic::Var;
+		/// Returns the result of parsing as Dynamic::Var
 
 private:
 	Parser(const Parser&);

JSON/include/Poco/JSON/ParserImpl.h

@@ -82,10 +82,10 @@ class JSON_API ParserImpl
 		/// Returns the Handler.
 
 	Dynamic::Var asVarImpl() const;
-		/// Returns the result of parsing;
+		/// Returns the result of parsing
 
 	Dynamic::Var resultImpl() const;
-		/// Returns the result of parsing as Dynamic::Var;
+		/// Returns the result of parsing as Dynamic::Var
 
 private:
 	ParserImpl(const ParserImpl&);