fix(ServerApplication): force service cmd line params on windows (#5240)

* fix(ServerApplication): force service cmd line params on windows

* enh(Util): Link shell32.lib on Windows, note about behavioral changes.

---------

Co-authored-by: Matej Kenda <matejken@gmail.com>

Author: sreckovic1987

Util/CMakeLists.txt

@@ -33,6 +33,9 @@ set_target_properties(Util
 )
 
 target_link_libraries(Util PUBLIC Poco::Foundation)
+if(WIN32)
+	target_link_libraries(Util PUBLIC shell32.lib)
+endif()
 if(ENABLE_XML)
 	target_link_libraries(Util PUBLIC Poco::XML)
 else()

Util/src/ServerApplication.cpp

@@ -37,6 +37,7 @@
 #include "Poco/Util/WinService.h"
 #include "Poco/Util/WinRegistryKey.h"
 #include "Poco/UnWindows.h"
+#include <shellapi.h>
 #include <cstring>
 #endif
 
@@ -180,12 +181,35 @@ void ServerApplication::ServiceMain(DWORD argc, LPWSTR* argv)
 
 	try
 	{
+		// Use the process command line (from binPath) instead of
+		// SCM-provided argv, which only contains the service name.
+		// This allows command-line options like --config-file to
+		// reach the application when running as a service.
+		// Since 1.15.1, args[0] is the executable path (from
+		// GetCommandLineW), matching the argv[0] convention on
+		// Unix/daemon startup.
 		std::vector<std::string> args;
-		for (DWORD i = 0; i < argc; ++i)
+		int nArgs = 0;
+		LPWSTR* pArgv = CommandLineToArgvW(GetCommandLineW(), &nArgs);
+		if (pArgv)
 		{
-			std::string arg;
-			Poco::UnicodeConverter::toUTF8(argv[i], arg);
-			args.push_back(arg);
+			for (int i = 0; i < nArgs; ++i)
+			{
+				std::string arg;
+				Poco::UnicodeConverter::toUTF8(pArgv[i], arg);
+				args.push_back(arg);
+			}
+			LocalFree(pArgv);
+		}
+		if (args.empty())
+		{
+			// fallback to SCM-provided args
+			for (DWORD i = 0; i < argc; ++i)
+			{
+				std::string arg;
+				Poco::UnicodeConverter::toUTF8(argv[i], arg);
+				args.push_back(arg);
+			}
 		}
 		app.init(args);
 		_serviceStatus.dwCurrentState = SERVICE_RUNNING;