Environment::nodeId Should Throw SystemException When Node ID is 0? #4326
Closed
andrewauclair
started this conversation in
General
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
We've had a few issues with this recently. If the Environment_UNIX.cpp EnvironmentImpl::nodeIdImpl fails to find a node ID it simply leaves the node ID as all 0's. A similar thing appears to happen on Windows. We then assume that this is a valid ID and use it. Some parts of our system end up getting 0's and other parts get a valid node ID and fail to communicate.
I think that this would work better if a SystemException was thrown when nodeIdImpl fails to set a value.
Beta Was this translation helpful? Give feedback.
All reactions