test(Thing): split up observeTypes tests

Author: jg10-mastodon-social

core/src/thing/Thing.types.spec.ts

@@ -2,6 +2,7 @@ import { graph, sym, IndexedFormula, quad } from "rdflib";
 import { PodOsSession } from "../authentication";
 import { Thing } from "./Thing";
 import { Store } from "../Store";
+import { Subscription } from "rxjs";
 
 describe("Thing", function () {
   describe("types", () => {
@@ -84,124 +85,138 @@ describe("Thing", function () {
   });
 
   describe("observeTypes", () => {
-    it("pushes existing value immediately and changed values until unsubscribe unless irrelevant", () => {
-      const internalStore = graph();
+    let internalStore: IndexedFormula,
+      uri: string,
+      subscriber: jest.Mock,
+      subscription: Subscription;
+
+    beforeEach(() => {
+      // Given a store with a type statement about a URI
+      internalStore = graph();
+      const mockSession = {} as unknown as PodOsSession;
+      const store = new Store(mockSession, undefined, undefined, internalStore);
+      uri = "http://recipe.test/0";
       internalStore.add(
         quad(
-          sym("http://recipe.test/0"),
+          sym(uri),
           sym("http://www.w3.org/1999/02/22-rdf-syntax-ns#type"),
           sym("http://schema.org/Recipe"),
         ),
       );
-      const store = new Store(
-        {} as PodOsSession,
-        undefined,
-        undefined,
-        internalStore,
-      );
-      const subscriber = jest.fn();
-      const thing = new Thing("http://recipe.test/0", store);
+
+      // and a Thing
+      const thing = new Thing(uri, store);
+
+      // and a subscription to changes in types
+      subscriber = jest.fn();
       const observable = thing.observeTypes();
-      const subscription = observable.subscribe(subscriber);
+      subscription = observable.subscribe(subscriber);
+    });
 
-      // Existing value
+    it("pushes existing value immediately", () => {
       expect(subscriber).toHaveBeenCalledTimes(1);
+      expect(subscriber.mock.calls).toEqual([
+        [
+          [
+            {
+              uri: "http://schema.org/Recipe",
+              label: "Recipe",
+            },
+          ],
+        ],
+      ]);
+    });
+
+    it("ignores irrelevant statements about another resource", () => {
       internalStore.add(
         quad(
-          sym("http://recipe.test/0"),
+          sym("http://recipe.test/a-different-recipe"),
           sym("http://www.w3.org/1999/02/22-rdf-syntax-ns#type"),
-          sym("http://example.com/Recipe2"),
+          sym("http://schema.org/Recipe"),
         ),
       );
-      // Irrelevant statement about another resource
+      expect(subscriber).toHaveBeenCalledTimes(1);
+    });
+
+    it("updates value when added", () => {
       internalStore.add(
         quad(
-          sym("http://recipe.test/a-different-recipe"),
+          sym(uri),
           sym("http://www.w3.org/1999/02/22-rdf-syntax-ns#type"),
-          sym("http://schema.org/Recipe"),
+          sym("http://example.com/Recipe2"),
         ),
       );
       expect(subscriber).toHaveBeenCalledTimes(2);
-      // Changed by removal
+      expect(subscriber.mock.lastCall).toEqual([
+        [
+          {
+            uri: "http://schema.org/Recipe",
+            label: "Recipe",
+          },
+          {
+            uri: "http://example.com/Recipe2",
+            label: "Recipe2",
+          },
+        ],
+      ]);
+    });
+
+    it("updates value when removed", () => {
       internalStore.removeStatement(
         quad(
-          sym("http://recipe.test/0"),
+          sym(uri),
           sym("http://www.w3.org/1999/02/22-rdf-syntax-ns#type"),
-          sym("http://example.com/Recipe2"),
+          sym("http://schema.org/Recipe"),
         ),
       );
-      expect(subscriber).toHaveBeenCalledTimes(3);
-      // Changed by added subclass
+      expect(subscriber).toHaveBeenCalledTimes(2);
+      expect(subscriber.mock.lastCall).toEqual([[]]);
+    });
+
+    it("updates when a subclass is added", () => {
       internalStore.add(
         quad(
           sym("http://schema.org/Recipe"),
           sym("http://www.w3.org/2000/01/rdf-schema#subClassOf"),
           sym("http://schema.org/Thing"),
         ),
       );
-      expect(subscriber).toHaveBeenCalledTimes(4);
-      // Irrelevant subclass doesn't change types
+      expect(subscriber).toHaveBeenCalledTimes(2);
+      expect(subscriber.mock.lastCall).toEqual([
+        [
+          {
+            uri: "http://schema.org/Recipe",
+            label: "Recipe",
+          },
+          {
+            uri: "http://schema.org/Thing",
+            label: "Thing",
+          },
+        ],
+      ]);
+    });
+
+    it("does not update if a new subclass is irrelevant", () => {
       internalStore.add(
         quad(
           sym("http://schema.org/Video"),
           sym("http://www.w3.org/2000/01/rdf-schema#subClassOf"),
           sym("http://schema.org/Thing"),
         ),
       );
-      expect(subscriber).toHaveBeenCalledTimes(4);
-      expect(subscriber.mock.calls).toEqual([
-        [
-          [
-            {
-              uri: "http://schema.org/Recipe",
-              label: "Recipe",
-            },
-          ],
-        ],
-        [
-          [
-            {
-              uri: "http://schema.org/Recipe",
-              label: "Recipe",
-            },
-            {
-              uri: "http://example.com/Recipe2",
-              label: "Recipe2",
-            },
-          ],
-        ],
-        [
-          [
-            {
-              uri: "http://schema.org/Recipe",
-              label: "Recipe",
-            },
-          ],
-        ],
-        [
-          [
-            {
-              uri: "http://schema.org/Recipe",
-              label: "Recipe",
-            },
-            {
-              uri: "http://schema.org/Thing",
-              label: "Thing",
-            },
-          ],
-        ],
-      ]);
+      expect(subscriber).toHaveBeenCalledTimes(1);
+    });
 
-      // Stop listening to ignore future changes
+    it("does not update after unsubscribe", () => {
       subscription.unsubscribe();
       internalStore.removeStatement(
         quad(
-          sym("http://recipe.test/0"),
+          sym(uri),
           sym("http://www.w3.org/1999/02/22-rdf-syntax-ns#type"),
           sym("http://schema.org/Recipe"),
         ),
       );
-      expect(subscriber).toHaveBeenCalledTimes(4);
+      expect(subscriber).toHaveBeenCalledTimes(1);
     });
   });
 });