Is json shouldn't do the slicing, that's an implementation detail the logs should have

Signed-off-by: Adameska <[email protected]>

Author: adameska

packages/webview/src/component/pods/PodLogs.spec.ts

@@ -258,6 +258,45 @@ describe('PodLogs', () => {
       const nineSpaces = '         '; // 9 spaces to pad 'a' to length of 'longername'
       expect(writtenLog).equals(nineSpaces + '\u001b[36ma\u001b[0m|short name log\r');
     });
+
+    test('should only sample first 20 lines for JSON detection', () => {
+      const pod = createPod(['containerName']);
+      const mockedTerminal = createMockTerminal();
+      setupTerminalMock(mockedTerminal);
+
+      render(PodLogs, { object: pod });
+
+      // Send 20 JSON lines followed by non-JSON lines
+      // If sampling is limited to 20 lines, JSON detection should return true (100% JSON)
+      // If all lines are checked, it would be ~71% JSON and fail the 80% threshold
+      const jsonLines = Array.from(
+        { length: 20 },
+        (_, i) => `{"timestamp":"2025-11-18T10:00:0${i}Z","level":"info","message":"Line ${i + 1}"}`,
+      ).join('\n');
+
+      const nonJsonLines = Array.from({ length: 8 }, (_, i) => `Not JSON line ${i + 1}`).join('\n');
+
+      // Send JSON lines first (should fill buffer and detect as JSON)
+      streamPodLogsMock.sendData({
+        podName: 'podName',
+        namespace: 'namespace',
+        containerName: 'containerName',
+        data: jsonLines,
+      });
+
+      // Send non-JSON lines (should be ignored for detection since buffer already filled)
+      streamPodLogsMock.sendData({
+        podName: 'podName',
+        namespace: 'namespace',
+        containerName: 'containerName',
+        data: nonJsonLines,
+      });
+
+      // The non-JSON lines should still be colorized as JSON since detection happened on first 20 lines
+      const calls = vi.mocked(mockedTerminal.write).mock.calls;
+      // First call should have JSON colorization (yellow braces)
+      expect(calls[0][0]).toContain('\u001b[33m{\u001b[0m');
+    });
   });
 
   describe('terminal initialization', () => {

packages/webview/src/component/terminal/json-colorizer.spec.ts

@@ -276,41 +276,6 @@ describe('detectJsonLogs', () => {
     expect(detectJsonLogs(logs)).toBe(true);
   });
 
-  test('should only check first 20 non-empty lines', () => {
-    const logs = [
-      '{"timestamp":"2025-11-18T10:00:00Z","level":"info","message":"Line 1"}',
-      '{"timestamp":"2025-11-18T10:00:01Z","level":"info","message":"Line 2"}',
-      '{"timestamp":"2025-11-18T10:00:02Z","level":"info","message":"Line 3"}',
-      '{"timestamp":"2025-11-18T10:00:03Z","level":"info","message":"Line 4"}',
-      '{"timestamp":"2025-11-18T10:00:04Z","level":"info","message":"Line 5"}',
-      '{"timestamp":"2025-11-18T10:00:05Z","level":"info","message":"Line 6"}',
-      '{"timestamp":"2025-11-18T10:00:06Z","level":"info","message":"Line 7"}',
-      '{"timestamp":"2025-11-18T10:00:07Z","level":"info","message":"Line 8"}',
-      '{"timestamp":"2025-11-18T10:00:08Z","level":"info","message":"Line 9"}',
-      '{"timestamp":"2025-11-18T10:00:09Z","level":"info","message":"Line 11"}',
-      '{"timestamp":"2025-11-18T10:00:09Z","level":"info","message":"Line 12"}',
-      '{"timestamp":"2025-11-18T10:00:09Z","level":"info","message":"Line 13"}',
-      '{"timestamp":"2025-11-18T10:00:09Z","level":"info","message":"Line 14"}',
-      '{"timestamp":"2025-11-18T10:00:09Z","level":"info","message":"Line 15"}',
-      '{"timestamp":"2025-11-18T10:00:09Z","level":"info","message":"Line 16"}',
-      '{"timestamp":"2025-11-18T10:00:09Z","level":"info","message":"Line 17"}',
-      '{"timestamp":"2025-11-18T10:00:09Z","level":"info","message":"Line 18"}',
-      '{"timestamp":"2025-11-18T10:00:09Z","level":"info","message":"Line 19"}',
-      '{"timestamp":"2025-11-18T10:00:09Z","level":"info","message":"Line 20"}',
-      // These lines after the 20th should be ignored
-      'Not JSON line 1',
-      'Not JSON line 2',
-      'Not JSON line 3',
-      'Not JSON line 4',
-      'Not JSON line 5',
-      'Not JSON line 6',
-      'Not JSON line 7',
-      'Not JSON line 8',
-    ];
-
-    expect(detectJsonLogs(logs)).toBe(true);
-  });
-
   test('should detect JSON with nested objects', () => {
     const logs = [
       '{"user":{"id":123,"name":"John"},"action":"login"}',