Skip to content

Commit bd4ca97

Browse files
committed
jobs: avoid blocking job which doesn't always run
As bentheelder said on Slack (https://kubernetes.slack.com/archives/C2C40FMNF/p1734418617113169?thread_ts=1734417601.687079&cid=C2C40FMNF), "adding blocking tests that only sometimes run is confusing and doesn't work well". That's because a regression might get merged without running the job. Then any PR where the job gets run is blocked, whether it is related to the failure or not. Therefore pull-kubernetes-e2e-gce-network-proxy-http-connect should not be blocking.
1 parent d4a63b0 commit bd4ca97

File tree

2 files changed

+1
-3
lines changed

2 files changed

+1
-3
lines changed

config/jobs/kubernetes/sig-api-machinery/sig-api-machinery-config.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,7 @@ presubmits:
8080
cluster: k8s-infra-prow-build
8181
always_run: false
8282
run_if_changed: '^(cluster/gce/manifests/konnectivity-server.yaml$|cluster/gce/addons/konnectivity-agent)'
83+
optional: true # Doesn't always run and regressions shouldn't block merging PRs where it gets run.
8384
labels:
8485
preset-service-account: "true"
8586
preset-k8s-ssh: "true"

config/testgrids/kubernetes/presubmits/config.yaml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,9 +48,6 @@ dashboards:
4848
- name: pull-kubernetes-dependencies
4949
test_group_name: pull-kubernetes-dependencies
5050
base_options: width=10
51-
- name: pull-kubernetes-e2e-gce-network-proxy-http-connect
52-
test_group_name: pull-kubernetes-e2e-gce-network-proxy-http-connect
53-
base_options: width=10
5451
- name: pull-kubernetes-conformance-kind-ga-only-parallel
5552
test_group_name: pull-kubernetes-conformance-kind-ga-only-parallel
5653
base_options: width=10

0 commit comments

Comments
 (0)