Clean up sync metadata when unrecognizable table is deleted. (#236)

* Clean up sync metadata when unrecognizable table is deleted.

* clean up tests

Author: mbrandonw

Sources/SQLiteData/CloudKit/SyncEngine.swift

@@ -1243,6 +1243,14 @@
           }
         } else {
           // NB: Deleting a record from a table we do not currently recognize.
+          await withErrorReporting(.sqliteDataCloudKitFailure) {
+            try await userDatabase.write { db in
+              try SyncMetadata
+                .findAll(recordIDs)
+                .delete()
+                .execute(db)
+            }
+          }
         }
       }
 

Tests/SQLiteDataTests/CloudKitTests/NextRecordZoneChangeBatchTests.swift

@@ -4,6 +4,7 @@
   import Foundation
   import InlineSnapshotTesting
   import SQLiteData
+  import SQLiteDataTestSupport
   import SnapshotTestingCustomDump
   import Testing
 
@@ -65,6 +66,49 @@
         }
       }
 
+      // * CloudKit sends record for table we do not recognize.
+      // * CloudKit deletes that record
+      // => Local sync metadata should be deleted for that record.
+      @available(iOS 17, macOS 14, tvOS 17, watchOS 10, *)
+      @Test func cloudKitSendsNonExistentTable() async throws {
+        let record = CKRecord(
+          recordType: UnrecognizedTable.tableName,
+          recordID: UnrecognizedTable.recordID(for: 1)
+        )
+        record.setValue(1, forKey: "id", at: now)
+        try await syncEngine.modifyRecords(scope: .private, saving: [record]).notify()
+
+        assertQuery(SyncMetadata.select(\.recordName), database: syncEngine.metadatabase) {
+          """
+          ┌────────────────────────┐
+          │ "1:unrecognizedTables" │
+          └────────────────────────┘
+          """
+        }
+
+        try await syncEngine.modifyRecords(scope: .private, deleting: [record.recordID]).notify()
+
+        assertQuery(SyncMetadata.select(\.recordName), database: syncEngine.metadatabase) {
+          """
+          (No results)
+          """
+        }
+        assertInlineSnapshot(of: container, as: .customDump) {
+          """
+          MockCloudContainer(
+            privateCloudDatabase: MockCloudDatabase(
+              databaseScope: .private,
+              storage: []
+            ),
+            sharedCloudDatabase: MockCloudDatabase(
+              databaseScope: .shared,
+              storage: []
+            )
+          )
+          """
+        }
+      }
+
       @available(iOS 17, macOS 14, tvOS 17, watchOS 10, *)
       @Test func metadataRowWithNoCorrespondingRecordRow() async throws {
         try await userDatabase.userWrite { db in
@@ -223,6 +267,6 @@
   }
 
   @Table struct UnrecognizedTable {
-    let id: UUID
+    let id: Int
   }
 #endif