Compute statement hashability from underlying query fragment #245
+42
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently depend directly on the hashability of `Statement` in the various fetch property wrappers, but this conformance has been found to be problematic and so we should remove it. We can make this change today, though, before removing it, by computing the hashability of a statement from its query fragment data.
stephencelis
added a commit
to pointfreeco/swift-structured-queries
that referenced
this pull request
Oct 7, 2025
We made `Statement: Hashable` for convenience in holding onto statements in a shared key for SQLiteData, but that isn't really necessary, since we can always call out to the underlying query fragment to get a hashable value. This conformance unfortunately can cause bugs, including `==` resolving to the equality operator when a query operator was expected. Another bug is that `@Table @Selection` types conform to `Statement`, and this equatable implementation was preferred over the default synthesized version, making `Table` values equatable strictly by the underlying query, which meant `@Ephemeral` fields weren't taken into account at all. With 0.20.0, all `@Table` applications introduced a `Statement` conformance, and so this issue becomes much more widespread. While this change can break SQLiteData if someone upgrades StructuredQueries before upgrading SQLiteData with the changes from pointfreeco/sqlite-data#245.
stephencelis
commented
Oct 8, 2025
mbrandonw
approved these changes
Oct 8, 2025
stephencelis
added a commit
to pointfreeco/swift-structured-queries
that referenced
this pull request
Oct 8, 2025
* `Statement` shouldn't inherit from `Hashable` We made `Statement: Hashable` for convenience in holding onto statements in a shared key for SQLiteData, but that isn't really necessary, since we can always call out to the underlying query fragment to get a hashable value. This conformance unfortunately can cause bugs, including `==` resolving to the equality operator when a query operator was expected. Another bug is that `@Table @Selection` types conform to `Statement`, and this equatable implementation was preferred over the default synthesized version, making `Table` values equatable strictly by the underlying query, which meant `@Ephemeral` fields weren't taken into account at all. With 0.20.0, all `@Table` applications introduced a `Statement` conformance, and so this issue becomes much more widespread. While this change can break SQLiteData if someone upgrades StructuredQueries before upgrading SQLiteData with the changes from pointfreeco/sqlite-data#245. * fix
bok-
pushed a commit
to bok-/swift-structured-queries-with-traits
that referenced
this pull request
Oct 12, 2025
* `Statement` shouldn't inherit from `Hashable` We made `Statement: Hashable` for convenience in holding onto statements in a shared key for SQLiteData, but that isn't really necessary, since we can always call out to the underlying query fragment to get a hashable value. This conformance unfortunately can cause bugs, including `==` resolving to the equality operator when a query operator was expected. Another bug is that `@Table @Selection` types conform to `Statement`, and this equatable implementation was preferred over the default synthesized version, making `Table` values equatable strictly by the underlying query, which meant `@Ephemeral` fields weren't taken into account at all. With 0.20.0, all `@Table` applications introduced a `Statement` conformance, and so this issue becomes much more widespread. While this change can break SQLiteData if someone upgrades StructuredQueries before upgrading SQLiteData with the changes from pointfreeco/sqlite-data#245. * fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently depend directly on the hashability of
Statementin the various fetch property wrappers, but this conformance has been found to be problematic and so we should remove it. We can make this change today, though, before removing it, by computing the hashability of a statement from its query fragment data.