RootCore crash (#3638)

* fix crash deinit outside MainActor

* Alternative: Mark AnyCancellable closures as sendable.

---------

Co-authored-by: Brandon Williams <[email protected]>

Author: arnauddorgans

Sources/ComposableArchitecture/Core.swift

@@ -128,7 +128,7 @@ final class RootCore<Root: Reducer>: Core {
           }
           boxedTask.wrappedValue = task
           tasks.withValue { $0.append(task) }
-          self.effectCancellables[uuid] = AnyCancellable {
+          self.effectCancellables[uuid] = AnyCancellable { @Sendable in
             task.cancel()
           }
         }
@@ -169,7 +169,7 @@ final class RootCore<Root: Reducer>: Core {
             self?.effectCancellables[uuid] = nil
           }
           tasks.withValue { $0.append(task) }
-          self.effectCancellables[uuid] = AnyCancellable {
+          self.effectCancellables[uuid] = AnyCancellable { @Sendable in
             task.cancel()
           }
         }

Sources/ComposableArchitecture/Effects/Cancellation.swift

@@ -58,7 +58,7 @@ extension Effect {
 
               let cancellable = LockIsolated<AnyCancellable?>(nil)
               cancellable.setValue(
-                AnyCancellable {
+                AnyCancellable { @Sendable in
                   _cancellationCancellables.withValue {
                     cancellationSubject.send(())
                     cancellationSubject.send(completion: .finished)
@@ -179,7 +179,7 @@ extension Effect {
           $0.cancel(id: id, path: navigationIDPath)
         }
         let task = Task { try await operation() }
-        let cancellable = AnyCancellable { task.cancel() }
+        let cancellable = AnyCancellable { @Sendable in task.cancel() }
         $0.insert(cancellable, at: id, path: navigationIDPath)
         return (cancellable, task)
       }

Sources/ComposableArchitecture/Effects/Publisher.swift

@@ -36,7 +36,7 @@ public struct _EffectPublisher<Action>: Publisher {
           defer { subscriber.send(completion: .finished) }
           await operation(Send { subscriber.send($0) })
         }
-        return AnyCancellable {
+        return AnyCancellable { @Sendable in
           task.cancel()
         }
       }

Tests/ComposableArchitectureTests/StoreLifetimeTests.swift

@@ -69,7 +69,7 @@ final class StoreLifetimeTests: BaseTCATestCase {
     }
 
     @MainActor
-    func testStoreDeinit_RunningEffect() async {
+    func testStoreDeinit_RunningEffect_MainActor() async {
       Logger.shared.isEnabled = true
       let effectFinished = self.expectation(description: "Effect finished")
       do {
@@ -95,6 +95,24 @@ final class StoreLifetimeTests: BaseTCATestCase {
       await self.fulfillment(of: [effectFinished], timeout: 0.5)
     }
 
+  func testStoreDeinit_RunningEffect() async {
+    let effectFinished = self.expectation(description: "Effect finished")
+    do {
+      let store = await Store<Void, Void>(initialState: ()) {
+        Reduce { state, _ in
+          .run { _ in
+            try? await Task.never()
+            effectFinished.fulfill()
+          }
+        }
+      }
+      await store.send(())
+      _ = store
+    }
+
+    await self.fulfillment(of: [effectFinished], timeout: 0.5)
+  }
+
     @MainActor
     func testStoreDeinit_RunningCombineEffect() async {
       Logger.shared.isEnabled = true