Remove schedulers in favor of using combine-schedulers (#184)

* Start using combine-schedulers.

* fixes

* wip

Author: mbrandonw

Examples/MotionManager/MotionManager/MotionManagerView.swift

@@ -146,9 +146,10 @@ struct AppView_Previews: PreviewProvider {
                 userAcceleration: .init(x: -cos(-3 * t), y: sin(2 * t), z: -cos(t))
               )
             )
-          }
-          .eraseToEffect()
-      },
+        }
+        .setFailureType(to: MotionClient.Error.self)
+        .eraseToEffect()
+    },
       startDeviceMotionUpdates: { _ in .fireAndForget { isStarted = true } },
       stopDeviceMotionUpdates: { _ in .fireAndForget { isStarted = false } }
     )

Package.swift

@@ -21,18 +21,21 @@ let package = Package(
     ),
   ],
   dependencies: [
-    .package(url: "https://github.com/pointfreeco/swift-case-paths", from: "0.1.1")
+    .package(url: "https://github.com/pointfreeco/combine-schedulers", from: "0.1.0"),
+    .package(url: "https://github.com/pointfreeco/swift-case-paths", from: "0.1.1"),
   ],
   targets: [
     .target(
       name: "ComposableArchitecture",
       dependencies: [
-        "CasePaths"
+        "CasePaths",
+        "CombineSchedulers",
       ]
     ),
     .testTarget(
       name: "ComposableArchitectureTests",
       dependencies: [
+        "CombineSchedulers",
         "ComposableArchitecture",
       ]
     ),

Sources/ComposableArchitecture/Effects/Timer.swift

@@ -1,7 +1,7 @@
 import Combine
-import Foundation
+import CombineSchedulers
 
-extension Effect {
+extension Effect where Failure == Never {
   /// Returns an effect that repeatedly emits the current time of the given
   /// scheduler on the given interval.
   ///
@@ -35,24 +35,10 @@ extension Effect {
     options: S.SchedulerOptions? = nil
   ) -> Effect where S: Scheduler, S.SchedulerTimeType == Output {
 
-    Deferred { () -> Publishers.HandleEvents<PassthroughSubject<Output, Failure>> in
-      let subject = PassthroughSubject<S.SchedulerTimeType, Failure>()
-
-      let cancellable = scheduler.schedule(
-        after: scheduler.now.advanced(by: interval),
-        interval: interval,
-        tolerance: tolerance ?? .seconds(.max),
-        options: options
-      ) {
-        subject.send(scheduler.now)
-      }
-
-      return subject.handleEvents(
-        receiveCompletion: { _ in cancellable.cancel() },
-        receiveCancel: cancellable.cancel
-      )
-    }
-    .eraseToEffect()
-    .cancellable(id: id)
+    Publishers.Timer(every: interval, tolerance: tolerance, scheduler: scheduler, options: options)
+      .autoconnect()
+      .setFailureType(to: Failure.self)
+      .eraseToEffect()
+      .cancellable(id: id)
   }
 }

Sources/ComposableArchitecture/Internal/Exports.swift

@@ -1 +1,2 @@
 @_exported import CasePaths
+@_exported import CombineSchedulers

Sources/ComposableArchitecture/Scheduling/AnyScheduler.swift

@@ -1,4 +1,5 @@
 import Combine
+import CombineSchedulers
 import ComposableArchitecture
 import XCTest
 

Sources/ComposableArchitecture/Scheduling/TestScheduler.swift

@@ -1,4 +1,5 @@
 import Combine
+import CombineSchedulers
 import ComposableArchitecture
 import XCTest
 import os.signpost