Revert "Deprecate non-writable scopes"

This reverts commit 95570eb.

Author: stephencelis

Sources/ComposableArchitecture/Observation/IdentifiedArray+Observation.swift

@@ -67,34 +67,7 @@ extension Store where State: ObservableState {
   ///   - filePath: The filePath.
   ///   - line: The line.
   /// - Returns: An collection of stores of child state.
-  public func scope<ElementID, ElementState, ElementAction>(
-    state: WritableKeyPath<State, IdentifiedArray<ElementID, ElementState>>,
-    action: CaseKeyPath<Action, IdentifiedAction<ElementID, ElementAction>>,
-    fileID: StaticString = #fileID,
-    filePath: StaticString = #filePath,
-    line: UInt = #line,
-    column: UInt = #column
-  ) -> some RandomAccessCollection<Store<ElementState, ElementAction>> {
-    if !core.canStoreCacheChildren {
-      reportIssue(
-        uncachedStoreWarning(self),
-        fileID: fileID,
-        filePath: filePath,
-        line: line,
-        column: column
-      )
-    }
-    return _StoreCollection(self.scope(state: state, action: action))
-  }
-
-  @available(
-    *,
-    deprecated,
-    message: """
-      Scoped 'state' must be a writable key path. For more information on this change, see the migration guide: https://pointfreeco.github.io/swift-composable-architecture/main/documentation/composablearchitecture/migratingto1.19#TODO
-      """
-  )
-  @_documentation(visibility: private)
+  @_disfavoredOverload
   public func scope<ElementID, ElementState, ElementAction>(
     state: KeyPath<State, IdentifiedArray<ElementID, ElementState>>,
     action: CaseKeyPath<Action, IdentifiedAction<ElementID, ElementAction>>,
@@ -123,7 +96,7 @@ public struct _StoreCollection<ID: Hashable & Sendable, State, Action>: RandomAc
   #if swift(<5.10)
     @MainActor(unsafe)
   #else
-    @preconcurrency @MainActor
+    @preconcurrency@MainActor
   #endif
   fileprivate init(_ store: Store<IdentifiedArray<ID, State>, IdentifiedAction<ID, Action>>) {
     self.store = store
@@ -162,8 +135,8 @@ public struct _StoreCollection<ID: Hashable & Sendable, State, Action>: RandomAc
           IfLetCore(
             base: core,
             cachedState: self.data[position],
-            stateKeyPath: \.[id: elementID],
-            actionKeyPath: \.[id: elementID]
+            stateKeyPath: \.[id:elementID],
+            actionKeyPath: \.[id:elementID]
           )
         }
         return self.store.scope(id: scopeID, childCore: open(self.store.core))

Sources/ComposableArchitecture/Observation/NavigationStack+Observation.swift

@@ -61,27 +61,6 @@ extension Binding {
   #else
     @MainActor(unsafe)
   #endif
-  public func scope<State: ObservableState, Action, ElementState, ElementAction>(
-    state: WritableKeyPath<State, StackState<ElementState>>,
-    action: CaseKeyPath<Action, StackAction<ElementState, ElementAction>>
-  ) -> Binding<Store<StackState<ElementState>, StackAction<ElementState, ElementAction>>>
-  where Value == Store<State, Action> {
-    self[state: state, action: action]
-  }
-
-  @available(
-    *,
-    deprecated,
-    message: """
-      Scoped 'state' must be a writable key path. For more information on this change, see the migration guide: https://pointfreeco.github.io/swift-composable-architecture/main/documentation/composablearchitecture/migratingto1.19#TODO
-      """
-  )
-  @_documentation(visibility: private)
-  #if swift(>=5.10)
-    @preconcurrency@MainActor
-  #else
-    @MainActor(unsafe)
-  #endif
   public func scope<State: ObservableState, Action, ElementState, ElementAction>(
     state: KeyPath<State, StackState<ElementState>>,
     action: CaseKeyPath<Action, StackAction<ElementState, ElementAction>>
@@ -102,27 +81,6 @@ extension SwiftUI.Bindable {
   #else
     @MainActor(unsafe)
   #endif
-  public func scope<State: ObservableState, Action, ElementState, ElementAction>(
-    state: WritableKeyPath<State, StackState<ElementState>>,
-    action: CaseKeyPath<Action, StackAction<ElementState, ElementAction>>
-  ) -> Binding<Store<StackState<ElementState>, StackAction<ElementState, ElementAction>>>
-  where Value == Store<State, Action> {
-    self[state: state, action: action]
-  }
-
-  @available(
-    *,
-    deprecated,
-    message: """
-      Scoped 'state' must be a writable key path. For more information on this change, see the migration guide: https://pointfreeco.github.io/swift-composable-architecture/main/documentation/composablearchitecture/migratingto1.19#TODO
-      """
-  )
-  @_documentation(visibility: private)
-  #if swift(>=5.10)
-    @preconcurrency@MainActor
-  #else
-    @MainActor(unsafe)
-  #endif
   public func scope<State: ObservableState, Action, ElementState, ElementAction>(
     state: KeyPath<State, StackState<ElementState>>,
     action: CaseKeyPath<Action, StackAction<ElementState, ElementAction>>
@@ -141,22 +99,6 @@ extension Perception.Bindable {
   ///
   /// See ``SwiftUI/Binding/scope(state:action:fileID:filePath:line:column:)`` defined on `Binding` for more
   /// information.
-  public func scope<State: ObservableState, Action, ElementState, ElementAction>(
-    state: WritableKeyPath<State, StackState<ElementState>>,
-    action: CaseKeyPath<Action, StackAction<ElementState, ElementAction>>
-  ) -> Binding<Store<StackState<ElementState>, StackAction<ElementState, ElementAction>>>
-  where Value == Store<State, Action> {
-    self[state: state, action: action]
-  }
-
-  @available(
-    *,
-    deprecated,
-    message: """
-      Scoped 'state' must be a writable key path. For more information on this change, see the migration guide: https://pointfreeco.github.io/swift-composable-architecture/main/documentation/composablearchitecture/migratingto1.19#TODO
-      """
-  )
-  @_documentation(visibility: private)
   public func scope<State: ObservableState, Action, ElementState, ElementAction>(
     state: KeyPath<State, StackState<ElementState>>,
     action: CaseKeyPath<Action, StackAction<ElementState, ElementAction>>
@@ -176,27 +118,6 @@ extension UIBindable {
   #else
     @MainActor(unsafe)
   #endif
-  public func scope<State: ObservableState, Action, ElementState, ElementAction>(
-    state: WritableKeyPath<State, StackState<ElementState>>,
-    action: CaseKeyPath<Action, StackAction<ElementState, ElementAction>>
-  ) -> UIBinding<Store<StackState<ElementState>, StackAction<ElementState, ElementAction>>>
-  where Value == Store<State, Action> {
-    self[state: state, action: action]
-  }
-
-  @available(
-    *,
-    deprecated,
-    message: """
-      Scoped 'state' must be a writable key path. For more information on this change, see the migration guide: https://pointfreeco.github.io/swift-composable-architecture/main/documentation/composablearchitecture/migratingto1.19#TODO
-      """
-  )
-  @_documentation(visibility: private)
-  #if swift(>=5.10)
-    @preconcurrency@MainActor
-  #else
-    @MainActor(unsafe)
-  #endif
   public func scope<State: ObservableState, Action, ElementState, ElementAction>(
     state: KeyPath<State, StackState<ElementState>>,
     action: CaseKeyPath<Action, StackAction<ElementState, ElementAction>>
@@ -463,24 +384,6 @@ public struct _NavigationLinkStoreContent<State, Label: View>: View {
 }
 
 extension Store where State: ObservableState {
-  fileprivate subscript<ElementState, ElementAction>(
-    state state: WritableKeyPath<State, StackState<ElementState>>,
-    action action: CaseKeyPath<Action, StackAction<ElementState, ElementAction>>,
-    isInViewBody isInViewBody: Bool = _isInPerceptionTracking
-  ) -> Store<StackState<ElementState>, StackAction<ElementState, ElementAction>> {
-    get {
-      #if DEBUG && !os(visionOS)
-        _PerceptionLocals.$isInPerceptionTracking.withValue(isInViewBody) {
-          self.scope(state: state, action: action)
-        }
-      #else
-        self.scope(state: state, action: action)
-      #endif
-    }
-    set {}
-  }
-
-  @available(*, deprecated)
   fileprivate subscript<ElementState, ElementAction>(
     state state: KeyPath<State, StackState<ElementState>>,
     action action: CaseKeyPath<Action, StackAction<ElementState, ElementAction>>,