fix crash deinit outside MainActor

Author: arnauddorgans

Sources/ComposableArchitecture/Core.swift

@@ -128,9 +128,7 @@ final class RootCore<Root: Reducer>: Core {
           }
           boxedTask.wrappedValue = task
           tasks.withValue { $0.append(task) }
-          self.effectCancellables[uuid] = AnyCancellable {
-            task.cancel()
-          }
+          self.effectCancellables[uuid] = self.effectCancellable(task: task)
         }
       case let .run(priority, operation):
         withEscapedDependencies { continuation in
@@ -169,9 +167,7 @@ final class RootCore<Root: Reducer>: Core {
             self?.effectCancellables[uuid] = nil
           }
           tasks.withValue { $0.append(task) }
-          self.effectCancellables[uuid] = AnyCancellable {
-            task.cancel()
-          }
+          self.effectCancellables[uuid] = self.effectCancellable(task: task)
         }
       }
     }
@@ -193,6 +189,11 @@ final class RootCore<Root: Reducer>: Core {
       }
     }
   }
+
+  nonisolated private func effectCancellable<Success, Failure>(task: Task<Success, Failure>) -> AnyCancellable {
+    AnyCancellable { task.cancel() }
+  }
+
   private actor DefaultIsolation {}
 }
 

Tests/ComposableArchitectureTests/StoreLifetimeTests.swift

@@ -69,7 +69,7 @@ final class StoreLifetimeTests: BaseTCATestCase {
     }
 
     @MainActor
-    func testStoreDeinit_RunningEffect() async {
+    func testStoreDeinit_RunningEffect_MainActor() async {
       Logger.shared.isEnabled = true
       let effectFinished = self.expectation(description: "Effect finished")
       do {
@@ -95,6 +95,24 @@ final class StoreLifetimeTests: BaseTCATestCase {
       await self.fulfillment(of: [effectFinished], timeout: 0.5)
     }
 
+  func testStoreDeinit_RunningEffect() async {
+    let effectFinished = self.expectation(description: "Effect finished")
+    do {
+      let store = await Store<Void, Void>(initialState: ()) {
+        Reduce { state, _ in
+          .run { _ in
+            try? await Task.never()
+            effectFinished.fulfill()
+          }
+        }
+      }
+      await store.send(())
+      _ = store
+    }
+
+    await self.fulfillment(of: [effectFinished], timeout: 0.5)
+  }
+
     @MainActor
     func testStoreDeinit_RunningCombineEffect() async {
       Logger.shared.isEnabled = true