Is it intentional that TCA is transitively dependent on OrderedCollections?

[kalupas226]

Hi.

TCA imports OrderedCollections in ForEachStore.swift.

However, TCA is only transitively dependent on OrderedCollections through IdentifiedCollections.

swift-composable-architecture/Package.swift

Line 38 in 09271d5

.product(name: "IdentifiedCollections", package: "swift-identified-collections"),

Is it intentional that TCA hasn't direct dependencies on OrderedCollections (swift-collections) ?

[mbrandonw]

I suppose it is intentional because we're not aware of a downside to depending on it transitively. Do you know of any?

[kalupas226]

Thank you for your quick response!

Here are downsides I can think of:

• You're depending on an other package's dependency so if that other package change its dependencies your code will break. Changing what a package depends on is not a breaking change (except when using types of a dependency in your public interface).
• From my understanding of apple/swift-package-manager#5297 it seems that being able to import a transitive dependency is a side effect of how SwiftPM currently works internally, not something that is explicitly allowed.

[stephencelis]

@kalupas226 Interesting, thanks for the clarification!

I don't think we're opposed to making the dependency explicit, it's just worked fine for now and hasn't been a priority to address (the SPM discussion is from 7 years ago, so I don't expect it to be addressed anytime soon 😅).

We'd happily take a pull request, though, if you'd like to submit one!

[davdroman]

the SPM discussion is from 7 years ago, so I don't expect it to be addressed anytime soon 😅

For context, I think it might be in the cards for Swift 6 to actually address it https://forums.swift.org/t/design-priorities-for-the-swift-6-language-mode/62408/1:

For example, Swift's module system might be improved to limit the effect of a module's implementation dependencies on its client modules, making modules and packages more resilient to change.

Anyway, Swift 6 is not expected to come in 2023 at all, so nothing to worry about just yet.

[kalupas226]

@stephencelis

I see, thanks for the clarification!

We'd happily take a pull request, though, if you'd like to submit one!

I'm happy to hear that 😄
I'd like to submit a pull request in a little bit.

@davdroman

For context, I think it might be in the cards for Swift 6 to actually address it https://forums.swift.org/t/design-priorities-for-the-swift-6-language-mode/62408/1:

I didn't know this information, thank you very much!

Anyway, Swift 6 is not expected to come in 2023 at all, so nothing to worry about just yet.

Now I also understand that there is nothing to worry about just yet.
Thank you again.