Navigation with ForEachStore issue

[imtooshy]

Hi. I'm facing the issue that when I'm navigating to a ShoppingListDetailedView and performed any action that changes state, I'm receiving action setNavigation(selection: nil). And this occurring only if in var lists: IdentifiedArrayOf<ShoppingListDetailedState> = [] more than 1 item.
Code below:

public struct ShoppingListFeatureView: View {
    private let store: Store<ShoppingListFeatureState, ShoppingListFeatureAction>
    
    public init(store: Store<ShoppingListFeatureState, ShoppingListFeatureAction>) {
        print("✅ ShoppingListFeatureView init")
        self.store = store
    }
    
    public var body: some View {
        WithViewStore(store) { (viewStore: ViewStore<ShoppingListFeatureState, ShoppingListFeatureAction>) in
            ZStack {
                ScrollView {
                    Spacer().frame(height: 16)
                    VStack {
                        ForEachStore(
                            store.scope(
                                state: \.lists,
                                action: ShoppingListFeatureAction.singleListViewAction
                            )
                        ) { listStore in
                            WithViewStore(listStore) { nestedViewStore in
                                NavigationLink(
                                    destination: ShoppingListDetailedView(store: listStore),
                                    tag: nestedViewStore.id,
                                    selection: viewStore.binding(
                                        get: \.selection,
                                        send: ShoppingListFeatureAction.setNavigation(selection:)
                                    ),
                                    label: {
                                        TextRow(text: nestedViewStore.name)
                                            .padding([.leading, .trailing], 16)
                                            .frame(height: 44)
                                    }
                                )
                            }
                        }
                        .transition(.fadeInFromBottomWithSpring)
                    }
                }
}
}

public struct ShoppingListFeatureState: Equatable, Hashable {
    var lists: IdentifiedArrayOf<ShoppingListDetailedState> = []
    var selection: Int?
    // other properties
    public init() {}
}

and reducing action (shoppingListReducer):

        case .setNavigation(selection: let selection):
            state.selection = selection
            return .none

// .......
    shoppingListDetailedReducer.forEach(
        state: \.lists,
        action: /ShoppingListFeatureAction.singleListViewAction,
        environment: { _ in .live }
    )

and detailed view

struct ShoppingListDetailedView: View {
    private let store: Store<ShoppingListDetailedState, ShoppingListDetailedAction>
    
    init(store: Store<ShoppingListDetailedState, ShoppingListDetailedAction>) {
        self.store = store
    }
    var body: some View {
        WithViewStore(store) { (viewStore: ViewStore<ShoppingListDetailedState, ShoppingListDetailedAction>) in
            ZStack {
                ScrollView {
                    Spacer().frame(height: 16)
                    LazyVStack(spacing: 8) {
                        ForEach(viewStore.items) { item in
                            ShoppingListItemView(
                                completed: item.completed,
                                units: item.value,
                                title: item.item.title
                            )
                            .padding(
                                EdgeInsets(
                                    top: 10,
                                    leading: 16,
                                    bottom: 10,
                                    trailing: 16
                                )
                            )
                            .onTapGesture {
                                viewStore.send(.onItemTap(id: item.id))
                            }
                            .swipeCell(
                                cellPosition: .right,
                                leftSlot: nil,
                                rightSlot: onSwipeSlots(
                                    with: viewStore,
                                    withId: item.id
                                )
                            )
                            .dismissSwipeCellForScrollViewForLazyVStack()
                        }
                        .transition(.fadeInFromBottomWithSpring)
                    }
                }
}
}

[renaudjenny]

I wonder if your issue isn't quite similar of mine: #575

I'm not using ForEachStore anymore though, previously, I used it, but it seems it's not working properly with NavigationLink when you want to use it with selection:. But it was working well without! Like my question mentioned in #575 I now really need NavigationLink with selection:. Perhaps in your case, you don't. So here is the code I used with ForEachStore that was working for me:
For the Core code https://github.com/renaudjenny/WeeklyRecipePlanning/blob/f7767c1796d3ab98313d62ce29b1d26ad757b589/Shared/Recipe/RecipeListCore.swift
and
The code from the ListView: https://github.com/renaudjenny/WeeklyRecipePlanning/blob/f7767c1796d3ab98313d62ce29b1d26ad757b589/Shared/Recipe/RecipeListView.swift#L9-L14
The code from the RecipeRow: https://github.com/renaudjenny/WeeklyRecipePlanning/blob/f7767c1796d3ab98313d62ce29b1d26ad757b589/Shared/Recipe/RecipeRowView.swift Note here that I'm not using the NavigationLink with selection:, but a simpler version of it, and it works well.

I hope this will help you, I'm not sure it's the right approach though, perhaps @mbrandonw or @stephencelis could confirm? But it works as soon as you don't have to control the navigation with selection:. Unfortunately, for my case, I have to control it... otherwise my + button won't navigate automatically to the new recipe.