Lock access to keyPathToName in key path printing. (#76)

* Lock access to keyPathToName for key path printing.

* slack release

* modernize

Author: mbrandonw

.github/workflows/ci.yml

@@ -9,6 +9,10 @@ on:
       - '*'
   workflow_dispatch:
 
+concurrency:
+  group: ci-${{ github.ref }}
+  cancel-in-progress: true
+
 jobs:
   macos:
     name: macOS (Xcode ${{ matrix.xcode }})

.github/workflows/documentation.yml

@@ -5,6 +5,10 @@ on:
       - published
   workflow_dispatch:
 
+concurrency:
+  group: documentation-${{ github.ref }}
+  cancel-in-progress: true
+
 jobs:
   build:
     runs-on: ubuntu-latest

.github/workflows/format.yml

@@ -5,6 +5,10 @@ on:
     branches:
       - main
 
+concurrency:
+  group: format-${{ github.ref }}
+  cancel-in-progress: true
+
 jobs:
   swift_format:
     name: swift-format

.github/workflows/release.yml

@@ -0,0 +1,83 @@
+name: Release
+on:
+  release:
+    types: [published]
+  workflow_dispatch:
+jobs:
+  project-channel:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Dump Github context
+        env:
+          GITHUB_CONTEXT: ${{ toJSON(github) }}
+        run: echo "$GITHUB_CONTEXT"
+      - name: Slack Notification on SUCCESS
+        if: success()
+        uses: tokorom/action-slack-incoming-webhook@main
+        env:
+          INCOMING_WEBHOOK_URL: ${{ secrets.SLACK_PROJECT_CHANNEL_WEBHOOK_URL }}
+        with:
+          text: swift-custom-dump ${{ github.event.release.tag_name }} has been released.
+          blocks: |
+            [
+              {
+                "type": "header",
+                "text": {
+                  "type": "plain_text",
+                  "text": "swift-custom-dump ${{ github.event.release.tag_name}}"
+                }
+              },
+              {
+                "type": "section",
+                "text": {
+                  "type": "mrkdwn",
+                  "text": ${{ toJSON(github.event.release.body) }}
+                }
+              },
+              {
+                "type": "section",
+                "text": {
+                  "type": "mrkdwn",
+                  "text": "${{ github.event.release.html_url }}"
+                }
+              }
+            ]
+
+  releases-channel:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Dump Github context
+        env:
+          GITHUB_CONTEXT: ${{ toJSON(github) }}
+        run: echo "$GITHUB_CONTEXT"
+      - name: Slack Notification on SUCCESS
+        if: success()
+        uses: tokorom/action-slack-incoming-webhook@main
+        env:
+          INCOMING_WEBHOOK_URL: ${{ secrets.SLACK_RELEASES_WEBHOOK_URL }}
+        with:
+          text: swift-custom-dump ${{ github.event.release.tag_name }} has been released.
+          blocks: |
+            [
+              {
+                "type": "header",
+                "text": {
+                  "type": "plain_text",
+                  "text": "swift-custom-dump ${{ github.event.release.tag_name}}"
+                }
+              },
+              {
+                "type": "section",
+                "text": {
+                  "type": "mrkdwn",
+                  "text": ${{ toJSON(github.event.release.body) }}
+                }
+              },
+              {
+                "type": "section",
+                "text": {
+                  "type": "mrkdwn",
+                  "text": "${{ github.event.release.html_url }}"
+                }
+              }
+            ]

Sources/CustomDump/Conformances/KeyPath.swift

@@ -1,3 +1,5 @@
+import Foundation
+
 extension AnyKeyPath: CustomDumpStringConvertible {
   public var customDumpDescription: String {
     #if swift(>=5.8)
@@ -6,6 +8,9 @@ extension AnyKeyPath: CustomDumpStringConvertible {
       }
     #endif
     #if os(iOS) || os(macOS) || os(tvOS) || os(watchOS)
+      keyPathToNameLock.lock()
+      defer { keyPathToNameLock.unlock() }
+    
       guard let name = keyPathToName[self] else {
         func reflectName() -> String {
           var namedKeyPaths = Reflection.allNamedKeyPaths(forUnderlyingTypeOf: Self.rootType)
@@ -36,6 +41,7 @@ extension AnyKeyPath: CustomDumpStringConvertible {
 }
 
 #if os(iOS) || os(macOS) || os(tvOS) || os(watchOS)
+  private var keyPathToNameLock = NSRecursiveLock()
   private var keyPathToName: [AnyKeyPath: String] = [:]
 
   // The source code below was extracted from the "KeyPath Reflection" branch of Apple's