Fix Runtime warning on pushing multiple items into NavigationStackController (TCA only) (#248)

loongallday · Chavin Panicharoen · web-flow · commit 7bf6bbf6ea50 · 2025-02-25T10:51:36.000-08:00
* fix, add if isEmpty condition on removing invalid indices

* fix wrong isEmptyPosition

---------

Co-authored-by: Chavin Panicharoen &lt;chavin.p@arise.tech&gt;
diff --git a/Sources/UIKitNavigation/Navigation/NavigationStackController.swift b/Sources/UIKitNavigation/Navigation/NavigationStackController.swift
@@ -148,7 +148,9 @@
               invalidIndices.insert(index)
             }
           }
-          path.remove(atOffsets: invalidIndices)
+          if !invalidIndices.isEmpty {
+              path.remove(atOffsets: invalidIndices)
+          }
           setViewControllers(newViewControllers, animated: !transaction.uiKit.disablesAnimations)
         }
       }

Original file line number	Diff line number	Diff line change
`@@ -148,7 +148,9 @@`
`148`	`148`	`invalidIndices.insert(index)`
`149`	`149`	`}`
`150`	`150`	`}`
`151`		`- path.remove(atOffsets: invalidIndices)`
	`151`	`+ if !invalidIndices.isEmpty {`
	`152`	`+ path.remove(atOffsets: invalidIndices)`
	`153`	`+ }`
`152`	`154`	`setViewControllers(newViewControllers, animated: !transaction.uiKit.disablesAnimations)`
`153`	`155`	`}`
`154`	`156`	`}`