Add More AnySnapshotStringConvertible Conformances (#115)

* Add More AnySnapshotStringConvertible Conformances

* Clean

* Fix

Author: stephencelis

Sources/SnapshotTesting/Snapshotting/Any.swift

@@ -69,6 +69,12 @@ extension AnySnapshotStringConvertible {
   }
 }
 
+extension Character: AnySnapshotStringConvertible {
+  public var snapshotDescription: String {
+    return self.debugDescription
+  }
+}
+
 extension Data: AnySnapshotStringConvertible {
   public var snapshotDescription: String {
     return self.debugDescription
@@ -99,6 +105,12 @@ extension String: AnySnapshotStringConvertible {
   }
 }
 
+extension Substring: AnySnapshotStringConvertible {
+  public var snapshotDescription: String {
+    return self.debugDescription
+  }
+}
+
 extension URL: AnySnapshotStringConvertible {
   public var snapshotDescription: String {
     return self.debugDescription

Tests/SnapshotTestingTests/SnapshotTestingTests.swift

@@ -26,12 +26,16 @@ class SnapshotTestingTests: TestCase {
     struct User { let id: Int, name: String, bio: String }
     let user = User(id: 1, name: "Blobby", bio: "Blobbed around the world.")
     assertSnapshot(matching: user, as: .dump)
-    assertSnapshot(matching: Data("Hello, world!".utf8), as: .dump)
-    assertSnapshot(matching: URL(string: "https://www.pointfree.co")!, as: .dump)
   }
 
-  func testDate() {
-    assertSnapshot(matching: Date(timeIntervalSinceReferenceDate: 0), as: .dump)
+  func testAnySnapshotStringConvertible() {
+    assertSnapshot(matching: "a" as Character, as: .dump, named: "character")
+    assertSnapshot(matching: Data("Hello, world!".utf8), as: .dump, named: "data")
+    assertSnapshot(matching: Date(timeIntervalSinceReferenceDate: 0), as: .dump, named: "date")
+    assertSnapshot(matching: NSObject(), as: .dump, named: "nsobject")
+    assertSnapshot(matching: "Hello, world!", as: .dump, named: "string")
+    assertSnapshot(matching: "Hello, world!".dropLast(8), as: .dump, named: "substring")
+    assertSnapshot(matching: URL(string: "https://www.pointfree.co")!, as: .dump, named: "url")
   }
 
   func testDeterministicDictionaryAndSetSnapshots() {
@@ -89,10 +93,6 @@ class SnapshotTestingTests: TestCase {
     assertSnapshot(matching: user, as: .dump, named: "named")
   }
 
-  func testNSObject() {
-    assertSnapshot(matching: NSObject(), as: .dump)
-  }
-
   func testNSView() {
     #if os(macOS)
     let button = NSButton()
@@ -472,13 +472,12 @@ extension SnapshotTestingTests {
   static var allTests : [(String, (SnapshotTestingTests) -> () throws -> Void)] {
     return [
       ("testAny", testAny),
-      ("testDate", testDate),
+      ("testAnySnapshotStringConvertible", testAnySnapshotStringConvertible),
       ("testDeterministicDictionaryAndSetSnapshots", testDeterministicDictionaryAndSetSnapshots),
       ("testEncodable", testEncodable),
       ("testMixedViews", testMixedViews),
       ("testMultipleSnapshots", testMultipleSnapshots),
       ("testNamedAssertion", testNamedAssertion),
-      ("testNSObject", testNSObject),
       ("testPrecision", testPrecision),
       ("testSCNView", testSCNView),
       ("testSKView", testSKView),

Tests/SnapshotTestingTests/__Snapshots__/SnapshotTestingTests/testAnySnapshotStringConvertible.character.txt

@@ -0,0 +1 @@
+- "a"

…ots__/SnapshotTestingTests/testAny.2.txt …estAnySnapshotStringConvertible.data.txtTests/SnapshotTestingTests/__Snapshots__/SnapshotTestingTests/testAny.2.txt renamed to Tests/SnapshotTestingTests/__Snapshots__/SnapshotTestingTests/testAnySnapshotStringConvertible.data.txt Tests/SnapshotTestingTests/__Snapshots__/SnapshotTestingTests/testAny.2.txt renamed to Tests/SnapshotTestingTests/__Snapshots__/SnapshotTestingTests/testAnySnapshotStringConvertible.data.txt

@@ -0,0 +1 @@
+- "Hello, world!"

…ts__/SnapshotTestingTests/testDate.1.txt …estAnySnapshotStringConvertible.date.txtTests/SnapshotTestingTests/__Snapshots__/SnapshotTestingTests/testDate.1.txt renamed to Tests/SnapshotTestingTests/__Snapshots__/SnapshotTestingTests/testAnySnapshotStringConvertible.date.txt Tests/SnapshotTestingTests/__Snapshots__/SnapshotTestingTests/testDate.1.txt renamed to Tests/SnapshotTestingTests/__Snapshots__/SnapshotTestingTests/testAnySnapshotStringConvertible.date.txt

@@ -0,0 +1 @@
+- "Hello"