Skip to content

Commit 0702428

Browse files
authored
Disfavor some operator overloads. (#62)
1 parent 42ddb5d commit 0702428

File tree

2 files changed

+7
-0
lines changed

2 files changed

+7
-0
lines changed

Sources/StructuredQueriesCore/Operators.swift

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -187,6 +187,7 @@ public func != <QueryValue>(
187187

188188
// NB: This overload is required due to an overload resolution bug of 'Updates[dynamicMember:]'.
189189
@_documentation(visibility: private)
190+
@_disfavoredOverload
190191
public func == <QueryValue: _OptionalProtocol>(
191192
lhs: any QueryExpression<QueryValue>,
192193
rhs: some QueryExpression<QueryValue.Wrapped>
@@ -196,6 +197,7 @@ public func == <QueryValue: _OptionalProtocol>(
196197

197198
// NB: This overload is required due to an overload resolution bug of 'Updates[dynamicMember:]'.
198199
@_documentation(visibility: private)
200+
@_disfavoredOverload
199201
public func != <QueryValue: _OptionalProtocol>(
200202
lhs: any QueryExpression<QueryValue>,
201203
rhs: some QueryExpression<QueryValue.Wrapped>

Tests/StructuredQueriesTests/SelectTests.swift

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,11 @@ extension SnapshotTests {
1616
_ = Reminder.where(\.isCompleted).select(\.id)
1717
_ = Reminder.where(\.isCompleted).select { $0.id }
1818
_ = Reminder.where(\.isCompleted).select { ($0.id, $0.isCompleted) }
19+
20+
let condition1 = Int?.some(1) == 2
21+
#expect(condition1 == false)
22+
let condition2 = Int?.some(1) != 2
23+
#expect(condition2 == true)
1924
}
2025

2126
@Test func selectAll() {

0 commit comments

Comments
 (0)