Fix enum associated value decoding (#220)

* Revert "Test array type columns in EnumTableTests (#216)"

This reverts commit 1447ea2.

* Enum decoding fixes

We had a bug in enum decoding that resulted in the decoder missing a few
columns along the way.

Author: stephencelis

Package.swift

@@ -156,9 +156,11 @@ let package = Package(
   swiftLanguageModes: [.v6]
 )
 
-// NB: For local testing in Xcode:
-// if true {
-if ProcessInfo.processInfo.environment["SPI_GENERATE_DOCS"] != nil {
+if ProcessInfo.processInfo.environment["SPI_GENERATE_DOCS"] != nil
+  || ProcessInfo.processInfo.environment["CI"] != nil
+  // NB: For local testing in Xcode:
+  // || true
+{
   package.traits.insert(
     .default(
       enabledTraits: [

Sources/StructuredQueriesMacros/TableMacro.swift

@@ -527,6 +527,7 @@ extension TableMacro: ExtensionMacro {
         """
     } else if declaration.is(EnumDeclSyntax.self) {
       var decodings: [String] = []
+      var decodingAssignments: [String] = []
       for member in declaration.memberBlock.members {
         guard let caseDecl = member.decl.as(EnumCaseDeclSyntax.self) else { continue }
         guard
@@ -685,7 +686,12 @@ extension TableMacro: ExtensionMacro {
         let decodedType = columnQueryValueType.asNonOptionalType()
         decodings.append(
           """
-          if let \(identifier) = try decoder.decode(\(decodedType).self) {
+          let \(identifier) = try decoder.decode(\(decodedType).self)
+          """
+        )
+        decodingAssignments.append(
+          """
+          if let \(identifier) {
           self = .\(identifier)(\(identifier))
           }
           """
@@ -694,7 +700,8 @@ extension TableMacro: ExtensionMacro {
       initDecoder = """
 
         public \(nonisolated)init(decoder: inout some \(moduleName).QueryDecoder) throws {
-        \(raw: decodings.joined(separator: " else ")) else {
+        \(raw: decodings.joined(separator: "\n"))
+        \(raw: decodingAssignments.joined(separator: " else ")) else {
         throw \(moduleName).QueryDecodingError.missingRequiredColumn
         }
         }

Tests/StructuredQueriesMacrosTests/TableMacroTests.swift

@@ -2575,9 +2575,11 @@ extension SnapshotTests {
             "posts"
           }
           public nonisolated init(decoder: inout some StructuredQueriesCore.QueryDecoder) throws {
-            if let photo = try decoder.decode(Photo.self) {
+            let photo = try decoder.decode(Photo.self)
+            let note = try decoder.decode(String.self)
+            if let photo {
               self = .photo(photo)
-            } else if let note = try decoder.decode(String.self) {
+            } else if let note {
               self = .note(note)
             } else {
               throw StructuredQueriesCore.QueryDecodingError.missingRequiredColumn
@@ -2682,9 +2684,11 @@ extension SnapshotTests {
             "posts"
           }
           public nonisolated init(decoder: inout some StructuredQueriesCore.QueryDecoder) throws {
-            if let photo = try decoder.decode(Photo.self) {
+            let photo = try decoder.decode(Photo.self)
+            let note = try decoder.decode(String.self)
+            if let photo {
               self = .photo(photo)
-            } else if let note = try decoder.decode(String.self) {
+            } else if let note {
               self = .note(note)
             } else {
               throw StructuredQueriesCore.QueryDecodingError.missingRequiredColumn
@@ -2785,9 +2789,11 @@ extension SnapshotTests {
             "posts"
           }
           public nonisolated init(decoder: inout some StructuredQueriesCore.QueryDecoder) throws {
-            if let photo = try decoder.decode(Photo.self) {
+            let photo = try decoder.decode(Photo.self)
+            let note = try decoder.decode(String.self)
+            if let photo {
               self = .photo(photo)
-            } else if let note = try decoder.decode(String.self) {
+            } else if let note {
               self = .note(note)
             } else {
               throw StructuredQueriesCore.QueryDecodingError.missingRequiredColumn
@@ -2873,9 +2879,11 @@ extension SnapshotTests {
             "posts"
           }
           public nonisolated init(decoder: inout some StructuredQueriesCore.QueryDecoder) throws {
-            if let photo = try decoder.decode(Photo.self) {
+            let photo = try decoder.decode(Photo.self)
+            let note = try decoder.decode(String.self)
+            if let photo {
               self = .photo(photo)
-            } else if let note = try decoder.decode(String.self) {
+            } else if let note {
               self = .note(note)
             } else {
               throw StructuredQueriesCore.QueryDecodingError.missingRequiredColumn
@@ -2947,7 +2955,8 @@ extension SnapshotTests {
             "posts"
           }
           public nonisolated init(decoder: inout some StructuredQueriesCore.QueryDecoder) throws {
-            if let note = try decoder.decode(String.self) {
+            let note = try decoder.decode(String.self)
+            if let note {
               self = .note(note)
             } else {
               throw StructuredQueriesCore.QueryDecodingError.missingRequiredColumn
@@ -3019,7 +3028,8 @@ extension SnapshotTests {
             "posts"
           }
           public nonisolated init(decoder: inout some StructuredQueriesCore.QueryDecoder) throws {
-            if let timestamp = try decoder.decode(Date.UnixTimeRepresentation.self) {
+            let timestamp = try decoder.decode(Date.UnixTimeRepresentation.self)
+            if let timestamp {
               self = .timestamp(timestamp)
             } else {
               throw StructuredQueriesCore.QueryDecodingError.missingRequiredColumn