Fix Swift compiler crash in release mode. (#31)

mbrandonw · stephencelis · web-flow · commit 71657e2f1d5b · 2025-04-30T09:50:11.000-07:00
* Fix Swift compiler crash in release mode.

* wip

* Update Sources/StructuredQueriesCore/Optional.swift

* Update .github/workflows/ci.yml

---------

Co-authored-by: Stephen Celis &lt;stephen@stephencelis.com&gt;
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -27,7 +27,7 @@ jobs:
       - name: Run tests
         run: swift test
       - name: Build release
-        run: swift build -c release
+        run: swift build -c release --build-tests
 
   linux:
     name: Linux
diff --git a/Sources/StructuredQueriesCore/Optional.swift b/Sources/StructuredQueriesCore/Optional.swift
@@ -100,11 +100,10 @@ extension Optional: Table where Wrapped: Table {
       )
     }
 
-    public subscript<QueryValue>(
-      dynamicMember keyPath: KeyPath<Wrapped.TableColumns, some QueryExpression<QueryValue>>
-    ) -> some QueryExpression<QueryValue?> {
-      let result: (some QueryExpression<QueryValue>)? = .some(Wrapped.columns[keyPath: keyPath])
-      return result
+    public subscript<Member: QueryExpression>(
+      dynamicMember keyPath: KeyPath<Wrapped.TableColumns, Member>
+    ) -> some QueryExpression<Member.QueryValue?> {
+      Member?.some(Wrapped.columns[keyPath: keyPath])
     }
 
     public subscript<QueryValue>(

Original file line number	Diff line number	Diff line change
`@@ -100,11 +100,10 @@ extension Optional: Table where Wrapped: Table {`
`100`	`100`	`)`
`101`	`101`	`}`
`102`	`102`
`103`		`- public subscript<QueryValue>(`
`104`		`- dynamicMember keyPath: KeyPath<Wrapped.TableColumns, some QueryExpression<QueryValue>>`
`105`		`- ) -> some QueryExpression<QueryValue?> {`
`106`		`- let result: (some QueryExpression<QueryValue>)? = .some(Wrapped.columns[keyPath: keyPath])`
`107`		`- return result`
	`103`	`+ public subscript<Member: QueryExpression>(`
	`104`	`+ dynamicMember keyPath: KeyPath<Wrapped.TableColumns, Member>`
	`105`	`+ ) -> some QueryExpression<Member.QueryValue?> {`
	`106`	`+ Member?.some(Wrapped.columns[keyPath: keyPath])`
`108`	`107`	`}`
`109`	`108`
`110`	`109`	`public subscript<QueryValue>(`