Update docs on temporary views. #182
Merged
+483
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrandonw
commented
Sep 19, 2025
|
|
||
| case .some(let label) where label.text == "primaryKey": | ||
| guard !declaration.hasMacroApplication("Table") | ||
| else { continue } |
Member
Author
There was a problem hiding this comment.
Unrelated to the core of this PR but something I noticed. We can allow @Selection types to have a primary key if it is also a @Table.
stephencelis
approved these changes
Sep 19, 2025
mbrandonw
commented
Sep 19, 2025
|
|
||
| The core functionality of this library is defined in | ||
| [`StructuredQueriesCore`](<doc:/StructuredQueriesCore>), which this module automatically exports. | ||
| [`StructuredQueriesCore`](structuredqueriescore), which this module automatically exports. |
Member
Author
There was a problem hiding this comment.
We previously made this change because it's supported when turning on an experimental docc feature that combines docs of multiple modules. But then it later turned out that setting didn't play nicely with SPI, but we forgot to revert this change.
coenttb
pushed a commit
to coenttb/swift-structured-queries-postgres
that referenced
this pull request
Oct 14, 2025
* Update docs on temporary views. * wip * wip * wip * wip * Allow table selections to have primary key. * wip * wip * wip * Fix formatting and syntax in Views.md documentation * Update Views.md * wip * wip --------- Co-authored-by: Stephen Celis <[email protected]>
coenttb
pushed a commit
to coenttb/swift-structured-queries-postgres
that referenced
this pull request
Oct 15, 2025
* Update docs on temporary views. * wip * wip * wip * wip * Allow table selections to have primary key. * wip * wip * wip * Fix formatting and syntax in Views.md documentation * Update Views.md * wip * wip --------- Co-authored-by: Stephen Celis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.