-
Notifications
You must be signed in to change notification settings - Fork 43
Update docs on temporary views. #182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from 12 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
f26e795
Update docs on temporary views.
mbrandonw 9374112
wip
mbrandonw 60ebfe7
wip
mbrandonw f65bdd7
wip
mbrandonw fdc7840
wip
mbrandonw 2cd531e
Allow table selections to have primary key.
mbrandonw 18bcbbf
wip
mbrandonw c60b0d6
wip
mbrandonw a7af302
wip
mbrandonw 0afba51
Fix formatting and syntax in Views.md documentation
stephencelis ddf4a21
Update Views.md
stephencelis 8aaddf9
wip
mbrandonw a226a2c
wip
mbrandonw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -98,6 +98,9 @@ extension SelectionMacro: ExtensionMacro { | |
| columnQueryValueType = "\(raw: base.trimmedDescription)" | ||
|
|
||
| case .some(let label) where label.text == "primaryKey": | ||
| guard !declaration.hasMacroApplication("Table") | ||
| else { continue } | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Unrelated to the core of this PR but something I noticed. We can allow |
||
|
|
||
| var newArguments = arguments | ||
| newArguments.remove(at: argumentIndex) | ||
| diagnostics.append( | ||
|
|
@@ -257,6 +260,9 @@ extension SelectionMacro: MemberMacro { | |
| columnQueryValueType = "\(raw: base.trimmedDescription)" | ||
|
|
||
| case .some(let label) where label.text == "primaryKey": | ||
| guard !declaration.hasMacroApplication("Table") | ||
| else { continue } | ||
|
|
||
| var newArguments = arguments | ||
| newArguments.remove(at: argumentIndex) | ||
| expansionFailed = true | ||
|
|
@@ -329,7 +335,7 @@ extension SelectionMacro: MemberMacro { | |
| """ | ||
| \($0): some \(moduleName).QueryExpression\ | ||
| \($1.map { "<\($0)>" } ?? "")\ | ||
| \($2.map { "= #bind(\($0))" } ?? "") | ||
| \($2.map { "= BindQueryExpression(\($0))" } ?? "") | ||
| """ | ||
| } | ||
| .joined(separator: ",\n") | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We previously made this change because it's supported when turning on an experimental docc feature that combines docs of multiple modules. But then it later turned out that setting didn't play nicely with SPI, but we forgot to revert this change.