-
Notifications
You must be signed in to change notification settings - Fork 44
Pre-load associations via JSON #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| assertQuery(Tag.select { $0.name.groupConcat() }.order(by: \.name)) { | ||
| assertQuery(Tag.select { $0.title.groupConcat() }.order(by: \.title)) { |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be annoying, but what do you think of extracting this rename to its own PR?
Member
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah agreed, can do!
Sources/StructuredQueriesCore/Documentation.docc/Articles/QueryCookbook.md
Outdated
Show resolved
Hide resolved
stephencelis
approved these changes
Apr 29, 2025
coenttb
pushed a commit
to coenttb/swift-structured-queries-postgres
that referenced
this pull request
Oct 14, 2025
* wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * Update QueryCookbook.md * remove jsonObject * wip * json encoder * revert name-to-title rename * update snaps * Update Sources/StructuredQueriesCore/Documentation.docc/Articles/QueryCookbook.md * rename * fix docs * wip * wip * cleanup * cleanup * wip * wip * Update QueryCookbook.md --------- Co-authored-by: Stephen Celis <[email protected]>
coenttb
pushed a commit
to coenttb/swift-structured-queries-postgres
that referenced
this pull request
Oct 15, 2025
* wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * Update QueryCookbook.md * remove jsonObject * wip * json encoder * revert name-to-title rename * update snaps * Update Sources/StructuredQueriesCore/Documentation.docc/Articles/QueryCookbook.md * rename * fix docs * wip * wip * cleanup * cleanup * wip * wip * Update QueryCookbook.md --------- Co-authored-by: Stephen Celis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tools to the library that allows loading associations for rows by converting the associated data to JSON and back into Swift types.