Skip to content

Generalize IN for any sequence of expressions #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephencelis merged 2 commits into from
Jun 18, 2025
Merged

Generalize IN for any sequence of expressions #87

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d021fd
Generalize `IN` for any sequence of expressions
stephencelis Jun 18, 2025
5715a1a
wip
stephencelis Jun 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions Sources/StructuredQueriesCore/Operators.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -832,8 +832,9 @@ extension QueryExpression where QueryValue: QueryBindable {
///
/// - Parameter expression: A sequence of expressions.
/// - Returns: A predicate expression indicating whether this expression is in the given sequence
public func `in`(_ expression: [some QueryExpression<QueryValue>]) -> some QueryExpression<Bool> {
BinaryOperator(lhs: self, operator: "IN", rhs: Array.Expression(elements: expression))
public func `in`<S: Sequence>(_ expression: S) -> some QueryExpression<Bool>
where S.Element: QueryExpression<QueryValue> {
BinaryOperator(lhs: self, operator: "IN", rhs: S.Expression(elements: expression))
}

/// Returns a predicate expression indicating whether the expression is in a subquery.
Expand Down Expand Up @@ -868,7 +869,7 @@ extension QueryExpression where QueryValue: QueryBindable {
}
}

extension Array where Element: QueryBindable {
extension Sequence where Element: QueryBindable {
/// Returns a predicate expression indicating whether the sequence contains the given expression.
///
/// An alias for ``QueryExpression/in(_:)``, flipped.
Expand Down Expand Up @@ -977,16 +978,15 @@ private struct LikeOperator<
}
}

extension Array where Element: QueryExpression, Element.QueryValue: QueryBindable {
fileprivate struct Expression: QueryExpression {
typealias QueryValue = Array
extension Sequence where Element: QueryExpression, Element.QueryValue: QueryBindable {
fileprivate typealias Expression = _SequenceExpression<Self>
}

let elements: [Element]
init(elements: [Element]) {
self.elements = elements
}
var queryFragment: QueryFragment {
"(\(elements.map(\.queryFragment).joined(separator: ", ")))"
}
fileprivate struct _SequenceExpression<S: Sequence>: QueryExpression
where S.Element: QueryExpression, S.Element.QueryValue: QueryBindable {
typealias QueryValue = S
let queryFragment: QueryFragment
init(elements: S) {
queryFragment = elements.map(\.queryFragment).joined(separator: ", ")
}
}
Loading