-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Open
Labels
P-lowPriority: lowPriority: lowacceptedReady for implementationReady for implementationinternalAn internal refactor or improvementAn internal refactor or improvementpythonRelated to Python PolarsRelated to Python Polars
Description
Currently, when @deprecated() is below @deprecate_renamed_parameter(), it does not issue (print) a deprecation warning. So, for example, this would not issue a warning (when it should):
@deprecate_renamed_parameter()
@deprecate_renamed_parameter()
@deprecated()
While moving @deprecated() to the top of the group will:
@deprecated()
@deprecate_renamed_parameter()
@deprecate_renamed_parameter()
This was outlined in #26479. A temporary fix was implemented in #26530.
The solution should allow the deprecation decorators to be applied in any order and still work.
Resources:
- The Polars deprecation functionality can be found at py-polars/src/polars/_utils/deprecation.py.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
P-lowPriority: lowPriority: lowacceptedReady for implementationReady for implementationinternalAn internal refactor or improvementAn internal refactor or improvementpythonRelated to Python PolarsRelated to Python Polars
Type
Projects
Status
Ready