feat: knock-knock joke

Author: polarhive

ash.go

@@ -10,6 +10,7 @@ import (
 	"encoding/base64"
 	"encoding/json"
 	"fmt"
+	grand "math/rand"
 	"net/http"
 	"os"
 	"os/signal"
@@ -560,6 +561,7 @@ type App struct {
 	BotCfg     *BotConfig
 	Client     *mautrix.Client
 	ReadyChan  <-chan bool
+	KnockKnock *KnockKnockState
 }
 
 // resolveReplyLabel returns the reply label with precedence:
@@ -615,6 +617,14 @@ func (app *App) handleMessage(evCtx context.Context, ev *event.Event) {
 		return
 	}
 
+	// Check for knock-knock joke reply continuations.
+	if app.KnockKnock != nil && msgData.Msg.RelatesTo != nil && msgData.Msg.RelatesTo.InReplyTo != nil {
+		if step, ok := app.KnockKnock.Get(msgData.Msg.RelatesTo.InReplyTo.EventID); ok {
+			go app.handleKnockKnockReply(evCtx, ev, step, msgData.Msg.RelatesTo.InReplyTo.EventID)
+			return
+		}
+	}
+
 	// Handle bot commands.
 	if currentRoom.AllowedCommands != nil && (strings.HasPrefix(msgData.Msg.Body, "/bot") || strings.HasPrefix(msgData.Msg.Body, "@gork")) {
 		app.dispatchBotCommand(evCtx, ev, msgData, currentRoom)
@@ -681,6 +691,12 @@ func (app *App) dispatchBotCommand(evCtx context.Context, ev *event.Event, msgDa
 		return
 	}
 
+	// Handle knockknock specially since it needs conversational state.
+	if cmdCfg.Type == "builtin" && cmdCfg.Command == "knockknock" {
+		go app.startKnockKnock(evCtx, ev, label)
+		return
+	}
+
 	// Run the command in a goroutine to avoid blocking other messages.
 	go func() {
 		resp, err := FetchBotCommand(evCtx, &cmdCfg, app.Cfg.LinkstashURL, ev, app.Client, app.Cfg.GroqAPIKey, label, app.MessagesDB)
@@ -697,6 +713,69 @@ func (app *App) dispatchBotCommand(evCtx context.Context, ev *event.Event, msgDa
 	}()
 }
 
+// startKnockKnock begins a knock-knock joke conversation.
+func (app *App) startKnockKnock(ctx context.Context, ev *event.Event, label string) {
+	joke := knockKnockJokes[grand.Intn(len(knockKnockJokes))]
+
+	body := label + "Knock knock! (reply to this message)"
+	content := event.MessageEventContent{
+		MsgType:   event.MsgText,
+		Body:      body,
+		RelatesTo: &event.RelatesTo{InReplyTo: &event.InReplyTo{EventID: ev.ID}},
+	}
+	resp, err := app.Client.SendMessageEvent(ctx, ev.RoomID, event.EventMessage, &content)
+	if err != nil {
+		log.Error().Err(err).Msg("failed to send knock knock opener")
+		return
+	}
+
+	app.KnockKnock.Set(resp.EventID, &knockKnockStep{
+		Joke:  joke,
+		Step:  0,
+		Label: label,
+	})
+
+	// Clean up after 5 minutes if no reply.
+	go func() {
+		time.Sleep(5 * time.Minute)
+		app.KnockKnock.Delete(resp.EventID)
+	}()
+}
+
+// handleKnockKnockReply continues a knock-knock joke conversation.
+func (app *App) handleKnockKnockReply(ctx context.Context, ev *event.Event, step *knockKnockStep, origEventID id.EventID) {
+	app.KnockKnock.Delete(origEventID)
+
+	if step.Step == 0 {
+		// User replied to "Knock knock!" — send the name.
+		body := fmt.Sprintf("%s%s (reply to this message)", step.Label, step.Joke.Name)
+		content := event.MessageEventContent{
+			MsgType:   event.MsgText,
+			Body:      body,
+			RelatesTo: &event.RelatesTo{InReplyTo: &event.InReplyTo{EventID: ev.ID}},
+		}
+		resp, err := app.Client.SendMessageEvent(ctx, ev.RoomID, event.EventMessage, &content)
+		if err != nil {
+			log.Error().Err(err).Msg("failed to send knock knock name")
+			return
+		}
+		app.KnockKnock.Set(resp.EventID, &knockKnockStep{
+			Joke:  step.Joke,
+			Step:  1,
+			Label: step.Label,
+		})
+		// Clean up after 5 minutes.
+		go func() {
+			time.Sleep(5 * time.Minute)
+			app.KnockKnock.Delete(resp.EventID)
+		}()
+	} else {
+		// User replied to the name — send the punchline!
+		body := step.Label + step.Joke.Punchline
+		sendBotReply(ctx, app.Client, ev.RoomID, ev.ID, body, "knockknock")
+	}
+}
+
 // processLinks handles link extraction, hooks, and snapshot exports.
 func (app *App) processLinks(_ context.Context, ev *event.Event, msgData *MessageData, room RoomIDEntry) {
 	if len(msgData.URLs) == 0 {
@@ -822,6 +901,7 @@ func run(ctx context.Context, metaDB *sql.DB, messagesDB *sql.DB, cfg *Config) e
 		BotCfg:     botCfg,
 		Client:     client,
 		ReadyChan:  readyChan,
+		KnockKnock: NewKnockKnockState(),
 	}
 	syncer.OnEventType(event.EventMessage, app.handleMessage)
 

ash_test.go

@@ -262,7 +262,7 @@ func TestLoadBotConfig(t *testing.T) {
 			continue
 		}
 		switch cmd.Type {
-		case "http", "exec", "ai":
+		case "http", "exec", "ai", "builtin":
 		default:
 			t.Errorf("command %q has invalid type %q", name, cmd.Type)
 		}
@@ -412,8 +412,8 @@ func TestQueryTopYappers(t *testing.T) {
 	if !strings.Contains(result, "alice") {
 		t.Errorf("expected alice in result, got: %s", result)
 	}
-	if !strings.Contains(result, "5 msgs") {
-		t.Errorf("expected '5 msgs' for alice, got: %s", result)
+	if !strings.Contains(result, "10 words") {
+		t.Errorf("expected '10 words' for alice, got: %s", result)
 	}
 	if !strings.Contains(result, "bob") {
 		t.Errorf("expected bob in result, got: %s", result)
@@ -445,3 +445,87 @@ func TestQueryTopYappers(t *testing.T) {
 		t.Errorf("messages from other rooms should be excluded, got: %s", result)
 	}
 }
+
+func TestQueryYapGuess(t *testing.T) {
+	db, err := sql.Open("sqlite3", ":memory:")
+	if err != nil {
+		t.Fatalf("open db: %v", err)
+	}
+	defer db.Close()
+
+	_, err = db.Exec(`CREATE TABLE IF NOT EXISTS messages (
+		id TEXT PRIMARY KEY,
+		room_id TEXT,
+		sender TEXT,
+		ts_ms INTEGER,
+		body TEXT,
+		msgtype TEXT,
+		raw_json TEXT
+	)`)
+	if err != nil {
+		t.Fatalf("create table: %v", err)
+	}
+
+	now := time.Now().UnixMilli()
+	room := "!testroom:example.com"
+
+	// alice=10 words (rank 1), bob=6 words (rank 2), carol=1 word (rank 3)
+	for i := 0; i < 5; i++ {
+		_, _ = db.Exec(`INSERT INTO messages(id, room_id, sender, ts_ms, body, msgtype) VALUES (?, ?, ?, ?, ?, ?)`,
+			fmt.Sprintf("alice-%d", i), room, "@alice:example.com", now-int64(i*1000), fmt.Sprintf("hello %d", i), "m.text")
+	}
+	for i := 0; i < 3; i++ {
+		_, _ = db.Exec(`INSERT INTO messages(id, room_id, sender, ts_ms, body, msgtype) VALUES (?, ?, ?, ?, ?, ?)`,
+			fmt.Sprintf("bob-%d", i), room, "@bob:example.com", now-int64(i*1000), fmt.Sprintf("hey %d", i), "m.text")
+	}
+	_, _ = db.Exec(`INSERT INTO messages(id, room_id, sender, ts_ms, body, msgtype) VALUES (?, ?, ?, ?, ?, ?)`,
+		"carol-0", room, "@carol:example.com", now, "sup", "m.text")
+
+	ctx := context.Background()
+
+	// Bob guesses rank 1 but is actually rank 2.
+	ev := &event.Event{
+		RoomID: id.RoomID(room),
+	}
+	ev.Sender = "@bob:example.com"
+	result, err := queryTopYappers(ctx, db, nil, ev, "guess 1", "", false)
+	if err != nil {
+		t.Fatalf("queryYapGuess: %v", err)
+	}
+	if !strings.Contains(result, "guessed #1") || !strings.Contains(result, "actually #2") {
+		t.Errorf("expected bob at #2 with guess #1, got: %s", result)
+	}
+	if !strings.Contains(result, "1 position(s) higher") {
+		t.Errorf("expected 'higher than you thought', got: %s", result)
+	}
+
+	// Alice guesses rank 1 — exactly right.
+	ev.Sender = "@alice:example.com"
+	result, err = queryTopYappers(ctx, db, nil, ev, "guess 1", "", false)
+	if err != nil {
+		t.Fatalf("queryYapGuess exact: %v", err)
+	}
+	if !strings.Contains(result, "exactly right") {
+		t.Errorf("expected exact match for alice guessing #1, got: %s", result)
+	}
+
+	// Carol guesses rank 1 but is actually rank 3.
+	ev.Sender = "@carol:example.com"
+	result, err = queryTopYappers(ctx, db, nil, ev, "guess 1", "", false)
+	if err != nil {
+		t.Fatalf("queryYapGuess carol: %v", err)
+	}
+	if !strings.Contains(result, "guessed #1") || !strings.Contains(result, "actually #3") {
+		t.Errorf("expected carol at #3, got: %s", result)
+	}
+
+	// Unknown sender has no messages.
+	ev.Sender = "@nobody:example.com"
+	result, err = queryTopYappers(ctx, db, nil, ev, "guess 1", "", false)
+	if err != nil {
+		t.Fatalf("queryYapGuess nobody: %v", err)
+	}
+	if !strings.Contains(result, "no messages") {
+		t.Errorf("expected no messages for unknown sender, got: %s", result)
+	}
+}