server/event: Handle filters with incompatible types

Author: Yopi

server/polar/meter/filter.py

@@ -145,23 +145,26 @@ def matches(self, event: Event) -> bool:
         return self._compare(actual_value, self.value)
 
     def _compare(self, actual: Any, expected: str | int | bool) -> bool:
-        if self.operator == FilterOperator.eq:
-            return actual == expected
-        elif self.operator == FilterOperator.ne:
-            return actual != expected
-        elif self.operator == FilterOperator.gt:
-            return actual > expected
-        elif self.operator == FilterOperator.gte:
-            return actual >= expected
-        elif self.operator == FilterOperator.lt:
-            return actual < expected
-        elif self.operator == FilterOperator.lte:
-            return actual <= expected
-        elif self.operator == FilterOperator.like:
-            return str(expected) in str(actual)
-        elif self.operator == FilterOperator.not_like:
-            return str(expected) not in str(actual)
-        return False
+        try:
+            if self.operator == FilterOperator.eq:
+                return actual == expected
+            elif self.operator == FilterOperator.ne:
+                return actual != expected
+            elif self.operator == FilterOperator.gt:
+                return actual > expected
+            elif self.operator == FilterOperator.gte:
+                return actual >= expected
+            elif self.operator == FilterOperator.lt:
+                return actual < expected
+            elif self.operator == FilterOperator.lte:
+                return actual <= expected
+            elif self.operator == FilterOperator.like:
+                return str(expected) in str(actual)
+            elif self.operator == FilterOperator.not_like:
+                return str(expected) not in str(actual)
+            return False
+        except TypeError:
+            return False
 
 
 class FilterConjunction(StrEnum):

server/tests/meter/test_filter.py

@@ -354,6 +354,18 @@ def test_matches_metadata_number_gt(self, organization: Organization) -> None:
         )
         assert clause.matches(event) is True
 
+    def test_matches_type_mismatch_returns_false(
+        self, organization: Organization
+    ) -> None:
+        clause = FilterClause(property="name", operator=FilterOperator.gte, value=1)
+        event = Event(
+            name="test.event",
+            organization_id=organization.id,
+            source=EventSource.user,
+            user_metadata={},
+        )
+        assert clause.matches(event) is False
+
 
 class TestFilterMatches:
     def test_matches_and_conjunction_all_true(self, organization: Organization) -> None: