Skip to content
This repository was archived by the owner on Dec 16, 2024. It is now read-only.

Sequence type is improperly defined #162

@Stoops-ML

Description

@Stoops-ML

The Sequence type (link) is too broadly defined as it accepts as input list[Any]. It isn't defined in the CZML wiki, and the only use case I can see for it is for defining a list of TimeIntervals (e.g. here) or a list of IntervalValues (e.g. here).

It seems more appropriate to replace the Sequence class with either:

  1. SequenceTime (or something similar) class that accepts list[TimeInterval] | list[IntervalValue]
  2. SequenceTimeInterval class and SequenceIntervalValue class

My preference is for option 1.

As a side note I think many people will get this class confused with the Sequence class from collections.abc.

@astrojuanlu let me know your thoughts and I'll submit a PR (along with some other bug fixes I've found recently).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions