Skip to content

Commit 12d6cf8

Browse files
authored
Don't want on resolvable Lookup* types (#4524)
1 parent aa7e5ea commit 12d6cf8

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44

55
Changes:
66

7+
- Don't warn on `Lookup*` types missing (these are resolvable)
78
- Don't clear injected `PortableRegistry` types on runtime upgrade
89

910

packages/types/src/metadata/util/validateTypes.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,10 @@ const l = logger('metadata');
1313
/** @internal */
1414
export function validateTypes (registry: Registry, throwError: boolean, types: string[]): string[] {
1515
const missing = flattenUniq(extractTypes(types))
16-
.filter((type) => !registry.hasType(type))
16+
.filter((type) =>
17+
!registry.hasType(type) &&
18+
!registry.isLookupType(type)
19+
)
1720
.sort();
1821

1922
if (missing.length !== 0) {

0 commit comments

Comments
 (0)