Skip to content

Feat/add daemon version to status #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Feat/add daemon version to status #404

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2678a4f
feat: add version field to daemon status
tfrere Nov 14, 2025
6d855ee
refactor: simplify version retrieval logic
tfrere Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/reachy_mini/daemon/daemon.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
import time
from dataclasses import asdict, dataclass
from enum import Enum
from importlib.metadata import version
from threading import Event, Thread
from typing import Any, Optional

Expand Down Expand Up @@ -41,13 +42,22 @@ def __init__(self, log_level: str = "INFO", wireless_version: bool = False) -> N
self.wireless_version = wireless_version

self.backend: "RobotBackend | MujocoBackend | None" = None
# Get package version
try:
package_version = version("reachy_mini")
self.logger.info(f"Daemon version: {package_version}")
except Exception:
package_version = None
self.logger.warning("Could not determine daemon version")
Comment on lines +46 to +51
Copy link

Copilot AI Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The exception handling is too broad. importlib.metadata.version() specifically raises PackageNotFoundError when a package is not found. Consider catching the specific exception type instead of a bare Exception:

from importlib.metadata import PackageNotFoundError, version

# ...

try:
    package_version = version("reachy_mini")
    self.logger.info(f"Daemon version: {package_version}")
except PackageNotFoundError:
    package_version = None
    self.logger.warning("Could not determine daemon version")

This makes the error handling more precise and explicit about what failure case is being handled.

Copilot uses AI. Check for mistakes.

Copy link

Copilot AI Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing whitespace detected. Please remove the trailing whitespace at the end of this line.

Suggested change

Copilot uses AI. Check for mistakes.
self._status = DaemonStatus(
state=DaemonState.NOT_INITIALIZED,
wireless_version=wireless_version,
simulation_enabled=None,
backend_status=None,
error=None,
wlan_ip=None,
version=package_version,
)
self._thread_event_publish_status = Event()

Expand Down Expand Up @@ -463,3 +473,4 @@ class DaemonStatus:
backend_status: Optional[RobotBackendStatus | MujocoBackendStatus]
error: Optional[str] = None
wlan_ip: Optional[str] = None
version: Optional[str] = None
Loading