Use target-typed new

The analyzer now correctly works even with
target-typed new expressions.

Author: tautropfli

Funcky.Analyzers/Funcky.Analyzers/AlternativeMonadAnalyzer/AlternativeMonadAnalyzer.GetOrElse.cs

@@ -7,7 +7,7 @@ namespace Funcky.Analyzers;
 
 public partial class AlternativeMonadAnalyzer
 {
-    public static readonly DiagnosticDescriptor PreferGetOrElse = new DiagnosticDescriptor(
+    public static readonly DiagnosticDescriptor PreferGetOrElse = new(
         id: $"{DiagnosticName.Prefix}{DiagnosticName.Usage}05",
         title: $"Prefer {GetOrElseMethodName} over {MatchMethodName}",
         messageFormat: $"Prefer {GetOrElseMethodName} over {MatchMethodName}",

Funcky.Analyzers/Funcky.Analyzers/AlternativeMonadAnalyzer/AlternativeMonadAnalyzer.OrElse.cs

@@ -7,7 +7,7 @@ namespace Funcky.Analyzers;
 
 public partial class AlternativeMonadAnalyzer
 {
-    public static readonly DiagnosticDescriptor PreferOrElse = new DiagnosticDescriptor(
+    public static readonly DiagnosticDescriptor PreferOrElse = new(
         id: $"{DiagnosticName.Prefix}{DiagnosticName.Usage}06",
         title: $"Prefer {OrElseMethodName} over {MatchMethodName}",
         messageFormat: $"Prefer {OrElseMethodName} over {MatchMethodName}",

Funcky.Analyzers/Funcky.Analyzers/AlternativeMonadAnalyzer/AlternativeMonadAnalyzer.SelectMany.cs

@@ -7,7 +7,7 @@ namespace Funcky.Analyzers;
 
 public partial class AlternativeMonadAnalyzer
 {
-    public static readonly DiagnosticDescriptor PreferSelectMany = new DiagnosticDescriptor(
+    public static readonly DiagnosticDescriptor PreferSelectMany = new(
         id: $"{DiagnosticName.Prefix}{DiagnosticName.Usage}07",
         title: $"Prefer {SelectManyMethodName} over {MatchMethodName}",
         messageFormat: $"Prefer {SelectManyMethodName} over {MatchMethodName}",

Funcky.Analyzers/Funcky.Analyzers/AlternativeMonadAnalyzer/AlternativeMonadAnalyzer.ToNullable.cs

@@ -8,7 +8,7 @@ namespace Funcky.Analyzers;
 
 public partial class AlternativeMonadAnalyzer
 {
-    public static readonly DiagnosticDescriptor PreferToNullable = new DiagnosticDescriptor(
+    public static readonly DiagnosticDescriptor PreferToNullable = new(
         id: $"{DiagnosticName.Prefix}{DiagnosticName.Usage}08",
         title: $"Prefer {ToNullableMethodName} over {MatchMethodName}",
         messageFormat: $"Prefer {ToNullableMethodName} over {MatchMethodName}",

Funcky.Analyzers/Funcky.Analyzers/EnumerableRepeatNeverAnalyzer.cs

@@ -21,7 +21,7 @@ public sealed class EnumerableRepeatNeverAnalyzer : DiagnosticAnalyzer
     private static readonly LocalizableString MessageFormat = LoadFromResource(nameof(EnumerableRepeatNeverAnalyzerMessageFormat));
     private static readonly LocalizableString Description = LoadFromResource(nameof(EnumerableRepeatNeverAnalyzerDescription));
 
-    private static readonly DiagnosticDescriptor Rule = new DiagnosticDescriptor(DiagnosticId, Title, MessageFormat, Category, DiagnosticSeverity.Warning, isEnabledByDefault: true, description: Description);
+    private static readonly DiagnosticDescriptor Rule = new(DiagnosticId, Title, MessageFormat, Category, DiagnosticSeverity.Warning, isEnabledByDefault: true, description: Description);
 
     public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics => ImmutableArray.Create(Rule);
 

Funcky.Analyzers/Funcky.Analyzers/EnumerableRepeatOnceAnalyzer.cs

@@ -21,7 +21,7 @@ public sealed class EnumerableRepeatOnceAnalyzer : DiagnosticAnalyzer
     private static readonly LocalizableString MessageFormat = LoadFromResource(nameof(EnumerableRepeatOnceAnalyzerMessageFormat));
     private static readonly LocalizableString Description = LoadFromResource(nameof(EnumerableRepeatOnceAnalyzerDescription));
 
-    private static readonly DiagnosticDescriptor Rule = new DiagnosticDescriptor(DiagnosticId, Title, MessageFormat, Category, DiagnosticSeverity.Warning, isEnabledByDefault: true, description: Description);
+    private static readonly DiagnosticDescriptor Rule = new(DiagnosticId, Title, MessageFormat, Category, DiagnosticSeverity.Warning, isEnabledByDefault: true, description: Description);
 
     public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics => ImmutableArray.Create(Rule);
 

Funcky.Analyzers/Funcky.Analyzers/JoinToStringEmptyAnalyzer.cs

@@ -22,7 +22,7 @@ public sealed class JoinToStringEmptyAnalyzer : DiagnosticAnalyzer
 
     private static readonly LocalizableString Description = LoadFromResource(nameof(JoinToStringEmptyAnalyzerDescription));
 
-    private static readonly DiagnosticDescriptor Rule = new DiagnosticDescriptor(DiagnosticId, Title, MessageFormat, Category, DiagnosticSeverity.Warning, isEnabledByDefault: true, description: Description);
+    private static readonly DiagnosticDescriptor Rule = new(DiagnosticId, Title, MessageFormat, Category, DiagnosticSeverity.Warning, isEnabledByDefault: true, description: Description);
 
     public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics => ImmutableArray.Create(Rule);
 

Funcky.Analyzers/Funcky.Analyzers/NonDefaultableAnalyzer.cs

@@ -8,7 +8,7 @@ namespace Funcky.Analyzers;
 [DiagnosticAnalyzer(LanguageNames.CSharp)]
 public sealed class NonDefaultableAnalyzer : DiagnosticAnalyzer
 {
-    public static readonly DiagnosticDescriptor DoNotUseDefault = new DiagnosticDescriptor(
+    public static readonly DiagnosticDescriptor DoNotUseDefault = new(
         id: $"{DiagnosticName.Prefix}{DiagnosticName.Usage}09",
         title: "Do not use default to instantiate this type",
         messageFormat: "Do not use default(...) to instantiate '{0}'",

Funcky.Analyzers/Funcky.Analyzers/UseWithArgumentNamesAnalyzer.cs

@@ -14,7 +14,7 @@ public sealed class UseWithArgumentNamesAnalyzer : DiagnosticAnalyzer
 
     private const string AttributeFullName = "Funcky.CodeAnalysis.UseWithArgumentNamesAttribute";
 
-    private static readonly DiagnosticDescriptor Descriptor = new DiagnosticDescriptor(
+    private static readonly DiagnosticDescriptor Descriptor = new(
         id: DiagnosticId,
         title: Resources.UseWithArgumentNamesAnalyzerAnalyzerTitle,
         messageFormat: Resources.UseWithArgumentNamesAnalyzerMessageFormat,

Funcky.Analyzers/Funcky.BuiltinAnalyzers/TryGetValueAnalyzer.cs

@@ -9,7 +9,7 @@ namespace Funcky.BuiltinAnalyzers;
 [DiagnosticAnalyzer(LanguageNames.CSharp)]
 public sealed class TryGetValueAnalyzer : DiagnosticAnalyzer
 {
-    private static readonly DiagnosticDescriptor Descriptor = new DiagnosticDescriptor(
+    private static readonly DiagnosticDescriptor Descriptor = new(
         id: "λ0001",
         title: "Disallowed use of TryGetValue",
         messageFormat: "Disallowed use of TryGetValue",