File tree Expand file tree Collapse file tree 3 files changed +23
-26
lines changed Expand file tree Collapse file tree 3 files changed +23
-26
lines changed Original file line number Diff line number Diff line change 2
2
3
3
# Sometimes it's a README fix, or something like that - which isn't relevant for
4
4
# including in a project's CHANGELOG for example
5
- declared_trivial = github . pr_title . include? "#trivial"
5
+ declared_trivial = ( github . pr_title + github . pr_body ) . include? "#trivial"
6
6
7
7
# Make it more obvious that a PR is a work in progress and shouldn't be merged yet
8
- warn ( "PR is classed as Work in Progress" ) if github . pr_title . include? "[WIP]"
8
+ warn "PR is classed as Work in Progress" if github . pr_title . include? "[WIP]"
9
9
10
10
# Warn when there is a big PR
11
- warn ( "Big PR" ) if git . lines_of_code > 500
11
+ warn "Big PR" if git . lines_of_code > 500
12
+
13
+ # Ensure there is a summary for a PR
14
+ fail "Please provide a summary in the Pull Request description" if github . pr_body . length < 5
12
15
13
16
# Add a CHANGELOG entry for app changes
14
17
if git . lines_of_code > 50 && !git . modified_files . include? ( "CHANGELOG.md" ) && !declared_trivial
15
- fail ( "Please update [CHANGELOG.md](https://github.com/polydice/ICInputAccessory/blob/develop/CHANGELOG.md)." )
18
+ fail "Please update [CHANGELOG.md](https://github.com/polydice/ICInputAccessory/blob/develop/CHANGELOG.md)." , sticky : true
16
19
end
17
20
18
21
# Ensure a clean commits history
19
22
if git . commits . any? { |c | c . message =~ /^Merge branch/ }
20
- fail ( ' Please rebase to get rid of the merge commits in this PR' )
23
+ fail " Please rebase to get rid of the merge commits in this PR" , sticky : true
21
24
end
Original file line number Diff line number Diff line change @@ -2,7 +2,7 @@ source "http://rubygems.org"
2
2
ruby "2.3.1"
3
3
4
4
gem "cocoapods" , "~> 1.1.0"
5
- gem "danger" , "~> 3.5 .0"
5
+ gem "danger" , "~> 4.0 .0"
6
6
gem "jazzy" , "~> 0.7.0"
7
7
gem "pry"
8
8
gem "rake"
Original file line number Diff line number Diff line change 7
7
minitest (~> 5.1 )
8
8
thread_safe (~> 0.3 , >= 0.3.4 )
9
9
tzinfo (~> 1.1 )
10
- addressable (2.4.0 )
10
+ addressable (2.5.0 )
11
+ public_suffix (~> 2.0 , >= 2.0.2 )
11
12
claide (1.0.1 )
12
13
claide-plugins (0.9.2 )
13
14
cork
49
50
colored (1.2 )
50
51
cork (0.2.0 )
51
52
colored (~> 1.2 )
52
- danger (3.5.5 )
53
+ danger (4.0.3 )
53
54
claide (~> 1.0 )
54
55
claide-plugins (>= 0.9.2 )
55
56
colored (~> 1.2 )
56
57
cork (~> 0.1 )
57
58
faraday (~> 0.9 )
58
59
faraday-http-cache (~> 1.0 )
59
60
git (~> 1 )
60
- gitlab (~> 3.7.0 )
61
61
kramdown (~> 1.5 )
62
62
octokit (~> 4.2 )
63
63
terminal-table (~> 1 )
64
64
escape (0.0.4 )
65
- faraday (0.9.2 )
65
+ faraday (0.10.0 )
66
66
multipart-post (>= 1.2 , < 3 )
67
67
faraday-http-cache (1.3.1 )
68
68
faraday (~> 0.8 )
69
69
fourflusher (2.0.1 )
70
70
fuzzy_match (2.0.4 )
71
71
gh_inspector (1.0.2 )
72
72
git (1.3.0 )
73
- gitlab (3.7.0 )
74
- httparty (~> 0.13.0 )
75
- terminal-table
76
- httparty (0.13.7 )
77
- json (~> 1.8 )
78
- multi_xml (>= 0.5.2 )
79
73
i18n (0.7.0 )
80
74
jazzy (0.7.2 )
81
75
cocoapods (~> 1.0 )
87
81
sqlite3 (~> 1.3 )
88
82
xcinvoke (~> 0.2.1 )
89
83
json (1.8.3 )
90
- kramdown (1.12.0 )
84
+ kramdown (1.13.1 )
91
85
liferaft (0.0.4 )
92
86
method_source (0.8.2 )
93
87
minitest (5.9.1 )
94
88
molinillo (0.5.2 )
95
- multi_xml (0.5.5 )
96
89
multipart-post (2.0.0 )
97
90
mustache (0.99.8 )
98
91
nap (1.1.0 )
99
92
netrc (0.7.8 )
100
- octokit (4.4.0 )
101
- sawyer (~> 0.7 .0 , >= 0.5.3 )
93
+ octokit (4.6.2 )
94
+ sawyer (~> 0.8 .0 , >= 0.5.3 )
102
95
open4 (1.3.4 )
103
96
pry (0.10.4 )
104
97
coderay (~> 1.1.0 )
105
98
method_source (~> 0.8.1 )
106
99
slop (~> 3.4 )
100
+ public_suffix (2.0.4 )
107
101
rake (11.3.0 )
108
102
redcarpet (3.3.4 )
109
103
rouge (1.11.1 )
110
104
sass (3.4.22 )
111
- sawyer (0.7.0 )
112
- addressable (>= 2.3.5 , < 2.5 )
113
- faraday (~> 0.8 , < 0.10 )
105
+ sawyer (0.8.1 )
106
+ addressable (>= 2.3.5 , < 2.6 )
107
+ faraday (~> 0.8 , < 1.0 )
114
108
slop (3.6.0 )
115
109
sqlite3 (1.3.11 )
116
110
terminal-table (1.7.3 )
117
111
unicode-display_width (~> 1.1.1 )
118
112
thread_safe (0.3.5 )
119
113
tzinfo (1.2.2 )
120
114
thread_safe (~> 0.1 )
121
- unicode-display_width (1.1.1 )
115
+ unicode-display_width (1.1.2 )
122
116
xcinvoke (0.2.1 )
123
117
liferaft (~> 0.0.4 )
124
118
xcodeproj (1.3.3 )
@@ -133,7 +127,7 @@ PLATFORMS
133
127
134
128
DEPENDENCIES
135
129
cocoapods (~> 1.1.0 )
136
- danger (~> 3.5 .0 )
130
+ danger (~> 4.0 .0 )
137
131
jazzy (~> 0.7.0 )
138
132
pry
139
133
rake
@@ -143,4 +137,4 @@ RUBY VERSION
143
137
ruby 2.3.1p112
144
138
145
139
BUNDLED WITH
146
- 1.12.5
140
+ 1.13.6
You can’t perform that action at this time.
0 commit comments