Resolve SwiftLint errors

Author: bcylin

.swiftlint.yml

@@ -2,6 +2,7 @@ disabled_rules:
   - force_try
   - line_length
   - nesting
+  - variable_name
   - vertical_whitespace
 type_name:
   excluded:

iCookTV.xcworkspace/xcshareddata/IDEWorkspaceChecks.plist

@@ -0,0 +1,8 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
+<plist version="1.0">
+<dict>
+	<key>IDEDidComputeMac32BitWarning</key>
+	<true/>
+</dict>
+</plist>

iCookTV/AppDelegate.swift

@@ -57,9 +57,9 @@ class AppDelegate: UIResponder, UIApplicationDelegate {
 
       TreasureData.sharedInstance().uploadEvents(callback: { [weak self] in
         self?.endBackgroundTask(inApplication: application)
-      }) { [weak self] _ in
+      }, onError: { [weak self] _ in
         self?.endBackgroundTask(inApplication: application)
-      }
+      })
     #endif
   }
 

iCookTV/Controllers/HistoryViewController.swift

@@ -59,7 +59,7 @@ class HistoryViewController: UIViewController,
     get {
       return R.string.localizable.history()
     }
-    set {}
+    set {}  // swiftlint:disable:this unused_setter_value
   }
 
   override func loadView() {

iCookTV/Controllers/LaunchViewController.swift

@@ -122,10 +122,10 @@ class LaunchViewController: UIViewController, DataFetching {
         self.lowerTaglineConstraint?.constant = 0
         self.view.layoutIfNeeded()
       }
-    }) { _ in
+    }, completion: { _ in
       self.semaphore.signal()
       self.isAnimating = false
-    }
+    })
   }
 
   // MARK: - Private Methods

iCookTV/Extensions/DataRequest+Result.swift

@@ -41,7 +41,7 @@ enum Result<T> {
 
   func mapError(_ transform: (Error) -> Void) -> Result<T> {
     switch self {
-    case .success(_): break
+    case .success: break
     case .failure(let error): transform(error)
     }
     return self

iCookTV/Helpers/HistoryManager.swift

@@ -75,11 +75,9 @@ struct HistoryManager {
       var records = history
 
       // Keep the latest video at top.
-      for (index, element) in self.history.enumerated() {
-        if element["id"] == json["id"] {
-          records.remove(at: index)
-          break
-        }
+      for (index, element) in self.history.enumerated() where element["id"] == json["id"] {
+        records.remove(at: index)
+        break
       }
       records.insert(json, at: 0)
       Debug.print("records.count =", records.count)

iCookTV/Protocols/OverlayViewPresentable.swift

@@ -68,7 +68,7 @@ extension OverlayViewPresentable where Self: UIViewController {
   }
 
   private func layoutOverlayViewIfNeeded() {
-    if let _ = overlayView.superview {
+    if overlayView.superview != nil {
       return
     }
 

iCookTV/Protocols/Reusable.swift

@@ -48,23 +48,23 @@ extension UICollectionReusableView: Reusable {}
 
 extension UICollectionView {
 
-  func register<T: UICollectionViewCell>(cell type: T.Type) where T: Reusable {
+  func register<T: UICollectionViewCell>(cell type: T.Type) {
     register(type, forCellWithReuseIdentifier: type.reuseIdentifier)
   }
 
-  func register<T: UICollectionReusableView>(supplementaryView type: T.Type, ofKind kind: String) where T: Reusable {
+  func register<T: UICollectionReusableView>(supplementaryView type: T.Type, ofKind kind: String) {
     register(type, forSupplementaryViewOfKind: kind, withReuseIdentifier: type.reuseIdentifier)
   }
 
-  func dequeueReusableCell<T: UICollectionViewCell>(type: T.Type = T.self, for indexPath: IndexPath) -> T where T: Reusable {
+  func dequeueReusableCell<T: UICollectionViewCell>(type: T.Type = T.self, for indexPath: IndexPath) -> T {
     if let cell = dequeueReusableCell(withReuseIdentifier: type.reuseIdentifier, for: indexPath) as? T {
       return cell
     } else {
       return type.init()
     }
   }
 
-  func dequeueReusableSupplementaryView<T: UICollectionReusableView>(type: T.Type = T.self, ofKind kind: String, for indexPath: IndexPath) -> T where T: Reusable {
+  func dequeueReusableSupplementaryView<T: UICollectionReusableView>(type: T.Type = T.self, ofKind kind: String, for indexPath: IndexPath) -> T {
     if let view = dequeueReusableSupplementaryView(ofKind: kind, withReuseIdentifier: type.reuseIdentifier, for: indexPath) as? T {
       return view
     } else {