New solution for publishing python packages that does not require env var

Author: vogti

.github/workflows/publish-pypi.yml

@@ -10,10 +10,7 @@ jobs:
         permissions:
             contents: write
             packages: write
-            id-token: write 
-#        environment:
-#            name: testpypi
-#            url: https://test.pypi.org/p/polypheny-prism-api
+            id-token: write
         steps:
             - uses: actions/checkout@v4
             - name: Set up Python 3.8
@@ -24,11 +21,12 @@ jobs:
               id: version
               run: |
                   if [[ "${{ github.event_name }}" == "release" && "${{ github.event.action }}" == "published" ]]; then
-                      echo "VERSION=${GITHUB_REF#refs/tags/}" >> $GITHUB_ENV
+                      echo "${GITHUB_REF#refs/tags/}" > prism-api-version.txt
                   else
                       TIMESTAMP=$(date +'%Y%m%d%H%M%S')
-                      echo "VERSION=0.0.dev${TIMESTAMP}" >> $GITHUB_ENV
-                  fi
+                      echo "0.0.dev${TIMESTAMP}" > prism-api-version.txt
+            - name: Create MANIFEST.in
+              run: echo "include prism-api-version.txt" > MANIFEST.in
             - name: Download protobuf for Linux
               run: |
                   curl -LO https://github.com/protocolbuffers/protobuf/releases/download/v26.0/protoc-26.0-linux-x86_64.zip
@@ -37,11 +35,5 @@ jobs:
               run: bin/protoc --experimental_allow_proto3_optional -I . --python_out . org/polypheny/prism/*.proto
             - name: Build package
               run: python setup.py sdist bdist_wheel
-              env:
-                  VERSION: ${{ env.VERSION }}
-#            - name: Publish distribution 📦 to Test PyPI
-#              uses: pypa/gh-action-pypi-publish@release/v1
-#              with:
-#                  repository-url: https://test.pypi.org/legacy/
             - name: Publish distribution 📦 to PyPI
               uses: pypa/gh-action-pypi-publish@release/v1

setup.py

@@ -1,46 +1,48 @@
 import os
-import sys
-
 from setuptools import setup
 
-# Retrieve 'VERSION' environment variable, default to '0.0' if not found.
-version = os.getenv('VERSION', '0.0')
+version_file = 'prism-api-version.txt'
+
+if not os.path.exists(version_file):
+    raise ValueError(f"Version file '{version_file}' not found. Please create the file with the version number.")
+
+with open(version_file, 'r') as f:
+    version = f.read().strip()
 
 print(f"Building version: {version}")
 
 if version == '0.0':
-    raise ValueError("Version not set or defaulting to '0.0'. Please set the VERSION environment variable.")
+    raise ValueError("Version is set to '0.0'. Please set a valid version number in the version file.")
 
 # Attempt to split the version number, default to '0' for both if it fails
 try:
     major, minor = version.split('.')
 except ValueError:
     raise ValueError(f"Invalid version format: {version}. Expected 'major.minor' format.")
 
-
 with open('org/polypheny/prism/version.py', 'w') as f:
     f.write(f'MAJOR_VERSION = {major}\n')
     f.write(f'MINOR_VERSION = {minor}\n')
 
-
 with open('README.md', 'r', encoding='utf-8') as f:
     long_description = f.read()
 
-setup(name='polypheny-prism-api',
-      version=version,
-      description='Polypheny Prism API files for Python',
-      long_description=long_description,
-      long_description_content_type='text/markdown',
-      author="The Polypheny Project",
-      author_email="[email protected]",
-      url="https://polypheny.com/",
-      project_urls={
+setup(
+    name='polypheny-prism-api',
+    version=version,
+    description='Polypheny Prism API files for Python',
+    long_description=long_description,
+    long_description_content_type='text/markdown',
+    author="The Polypheny Project",
+    author_email="[email protected]",
+    url="https://polypheny.com/",
+    project_urls={
         "Documentation": "https://docs.polypheny.com/en/latest/query_interfaces/prism/protocol",
         "Code": "https://github.com/polypheny/Polypheny-Prism-API"
-      },
-      license="Apache License, Version 2.0",
-      packages=['org/polypheny/prism'],
-      install_requires=[
-          "protobuf==4.24.3",
-      ],
+    },
+    license="Apache License, Version 2.0",
+    packages=['org/polypheny/prism'],
+    install_requires=[
+        "protobuf==4.24.3",
+    ],
 )