Skip to content

Commit 028e777

Browse files
committed
Add option for using implicit test entrypoints.
1 parent ba69029 commit 028e777

File tree

3 files changed

+31
-11
lines changed

3 files changed

+31
-11
lines changed

edu.cuny.hunter.streamrefactoring.core/src/edu/cuny/hunter/streamrefactoring/core/refactorings/ConvertToParallelStreamRefactoringProcessor.java

Lines changed: 15 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -138,23 +138,26 @@ public static void setLoggingLevel(int level) {
138138

139139
private boolean useImplicitEntrypoints = true;
140140

141+
private boolean useImplicitTestEntrypoints = false;
142+
141143
public ConvertToParallelStreamRefactoringProcessor() throws JavaModelException {
142-
this(null, null, false, true, Optional.empty());
144+
this(null, null, false, true, false, Optional.empty());
143145
}
144146

145147
public ConvertToParallelStreamRefactoringProcessor(final CodeGenerationSettings settings,
146148
Optional<IProgressMonitor> monitor) throws JavaModelException {
147-
this(null, settings, false, true, monitor);
149+
this(null, settings, false, true, false, monitor);
148150
}
149151

150152
public ConvertToParallelStreamRefactoringProcessor(IJavaProject[] javaProjects,
151153
final CodeGenerationSettings settings, boolean layer, boolean useImplicitEntrypoints,
152-
Optional<IProgressMonitor> monitor) throws JavaModelException {
154+
boolean useImplicitTestEntrypoints, Optional<IProgressMonitor> monitor) throws JavaModelException {
153155
try {
154156
this.javaProjects = javaProjects;
155157
this.settings = settings;
156158
this.layer = layer;
157159
this.useImplicitEntrypoints = useImplicitEntrypoints;
160+
this.useImplicitTestEntrypoints = useImplicitTestEntrypoints;
158161
} finally {
159162
monitor.ifPresent(IProgressMonitor::done);
160163
}
@@ -163,16 +166,16 @@ public ConvertToParallelStreamRefactoringProcessor(IJavaProject[] javaProjects,
163166
public ConvertToParallelStreamRefactoringProcessor(IJavaProject[] javaProjects,
164167
final CodeGenerationSettings settings, boolean useImplicitJoinpoints, Optional<IProgressMonitor> monitor)
165168
throws JavaModelException {
166-
this(javaProjects, settings, false, useImplicitJoinpoints, monitor);
169+
this(javaProjects, settings, false, useImplicitJoinpoints, false, monitor);
167170
}
168171

169172
public ConvertToParallelStreamRefactoringProcessor(IJavaProject[] javaProjects,
170173
final CodeGenerationSettings settings, Optional<IProgressMonitor> monitor) throws JavaModelException {
171-
this(javaProjects, settings, false, true, monitor);
174+
this(javaProjects, settings, false, true, false, monitor);
172175
}
173176

174177
public ConvertToParallelStreamRefactoringProcessor(Optional<IProgressMonitor> monitor) throws JavaModelException {
175-
this(null, null, false, true, monitor);
178+
this(null, null, false, true, false, monitor);
176179
}
177180

178181
private RefactoringStatus checkExistence(IMember member, PreconditionFailure failure) {
@@ -189,7 +192,8 @@ public RefactoringStatus checkFinalConditions(final IProgressMonitor monitor, fi
189192
SubMonitor subMonitor = SubMonitor.convert(monitor, Messages.CheckingPreconditions,
190193
this.getJavaProjects().length * 1000);
191194
final RefactoringStatus status = new RefactoringStatus();
192-
StreamAnalyzer analyzer = new StreamAnalyzer(false, this.getUseImplicitEntrypoints());
195+
StreamAnalyzer analyzer = new StreamAnalyzer(false, this.getUseImplicitEntrypoints(),
196+
this.getUseImplicitTestEntrypoints());
193197
this.setStreamSet(analyzer.getStreamSet());
194198

195199
for (IJavaProject jproj : this.getJavaProjects()) {
@@ -449,6 +453,10 @@ private boolean getUseImplicitEntrypoints() {
449453
return this.useImplicitEntrypoints;
450454
}
451455

456+
private boolean getUseImplicitTestEntrypoints() {
457+
return this.useImplicitTestEntrypoints;
458+
}
459+
452460
@Override
453461
public boolean isApplicable() throws CoreException {
454462
// return

edu.cuny.hunter.streamrefactoring.core/src/edu/cuny/hunter/streamrefactoring/core/utils/Util.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,11 +52,11 @@ public static ConvertToParallelStreamRefactoringProcessor createConvertToParalle
5252
}
5353

5454
public static ConvertToParallelStreamRefactoringProcessor createConvertToParallelStreamRefactoringProcessor(
55-
IJavaProject[] projects, boolean useImplicitJoinpoints, Optional<IProgressMonitor> monitor)
56-
throws JavaModelException {
55+
IJavaProject[] projects, boolean useImplicitEntrypoints, boolean useImplicitTestEntrypoints,
56+
Optional<IProgressMonitor> monitor) throws JavaModelException {
5757
CodeGenerationSettings settings = JavaPreferencesSettings.getCodeGenerationSettings(projects[0]);
5858
ConvertToParallelStreamRefactoringProcessor processor = new ConvertToParallelStreamRefactoringProcessor(
59-
projects, settings, useImplicitJoinpoints, monitor);
59+
projects, settings, false, useImplicitEntrypoints, useImplicitTestEntrypoints, monitor);
6060
return processor;
6161
}
6262

edu.cuny.hunter.streamrefactoring.eval/src/edu/cuny/hunter/streamrefactoring/eval/handlers/EvaluateConvertToParallelStreamRefactoringHandler.java

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,8 @@
7474
public class EvaluateConvertToParallelStreamRefactoringHandler extends AbstractHandler {
7575

7676
private static final boolean BUILD_WORKSPACE = false;
77+
private static final boolean FIND_IMPLICIT_TEST_ENTRYPOINTS_DEFAULT = false;
78+
private static final String FIND_IMPLICIT_TEST_ENTRYPOINTS_PROPERTY_KEY = "edu.cuny.hunter.streamrefactoring.eval.findImplicitTestEntrypoints";
7779
private static final boolean FIND_IMPLICIT_ENTRYPOINTS_DEFAULT = true;
7880
private static final String FIND_IMPLICIT_ENTRYPOINTS_PROPERTY_KEY = "edu.cuny.hunter.streamrefactoring.eval.findImplicitEntrypoints";
7981
private static final int LOGGING_LEVEL = IStatus.INFO;
@@ -242,7 +244,8 @@ public Object execute(ExecutionEvent event) throws ExecutionException {
242244

243245
resultsTimeCollector.start();
244246
processor = createConvertToParallelStreamRefactoringProcessor(new IJavaProject[] { javaProject },
245-
this.shouldFindImplicitEntrypoints(), Optional.of(monitor));
247+
this.shouldFindImplicitEntrypoints(), this.shouldFindImplicitTestEntrypoints(),
248+
Optional.of(monitor));
246249
resultsTimeCollector.stop();
247250
ConvertToParallelStreamRefactoringProcessor.setLoggingLevel(LOGGING_LEVEL);
248251

@@ -479,6 +482,15 @@ private boolean shouldFindImplicitEntrypoints() {
479482
return Boolean.valueOf(findImplicitEntrypoits);
480483
}
481484

485+
private boolean shouldFindImplicitTestEntrypoints() {
486+
String findImplicitTestEntrypoints = System.getenv(FIND_IMPLICIT_TEST_ENTRYPOINTS_PROPERTY_KEY);
487+
488+
if (findImplicitTestEntrypoints == null)
489+
return FIND_IMPLICIT_TEST_ENTRYPOINTS_DEFAULT;
490+
else
491+
return Boolean.valueOf(findImplicitTestEntrypoints);
492+
}
493+
482494
private boolean shouldPerformChange() {
483495
String performChangePropertyValue = System.getenv(PERFORM_CHANGE_PROPERTY_KEY);
484496

0 commit comments

Comments
 (0)