Default ROM to true if we can't find possible return types.

Author: khatchad

edu.cuny.hunter.streamrefactoring.core/src/edu/cuny/hunter/streamrefactoring/core/analysis/StreamStateMachine.java

@@ -683,6 +683,7 @@ private void discoverIfReduceOrderingPossiblyMatters(EclipseProjectAnalysisEngin
 				assert numOfRetVals <= 1 : "How could you possibly return " + numOfRetVals + " values?";
 
 				Collection<TypeAbstraction> possibleReturnTypes = null;
+				Boolean rom = null;
 
 				// if it's a non-void method.
 				if (numOfRetVals > 0) {
@@ -691,49 +692,62 @@ private void discoverIfReduceOrderingPossiblyMatters(EclipseProjectAnalysisEngin
 					possibleReturnTypes = Util.getPossibleTypesInterprocedurally(block.getNode(), returnValue, engine,
 							orderingInference);
 
+					// if no return types can be found.
+					if (possibleReturnTypes.isEmpty()) {
+						// default to true.
+						rom = true;
+
+						LOGGER.warning("Number of returned values are: " + numOfRetVals
+								+ " but cannot find possible return types for node: " + block.getNode()
+								+ " and return value:" + returnValue + ". Defaulting ROM to: " + rom + " for block: "
+								+ block + ".");
+					}
+
 					LOGGER.fine("Possible reduce types are: " + possibleReturnTypes);
 				} else {
 					// it's a void method.
 					possibleReturnTypes = Collections.singleton(JavaPrimitiveType.VOID);
 				}
 
-				Boolean rom = null;
-
-				if (isVoid(possibleReturnTypes))
-					rom = deriveRomForVoidMethod(invokeInstruction);
-				else {
-					boolean scalar = Util.isScalar(possibleReturnTypes);
-					if (scalar)
-						try {
-							rom = deriveRomForScalarMethod(invokeInstruction);
-						} catch (UnknownIfReduceOrderMattersException e) {
-							// for each possible receiver associated with the terminal block.
-							OrdinalSet<InstanceKey> receivers = terminalBlockToPossibleReceivers.get(block);
-
-							for (InstanceKey instanceKey : receivers) {
-								// get the stream for the instance key.
-								Set<InstanceKey> originStreams = computePossibleOriginStreams(instanceKey);
-
-								// for each origin stream.
-								for (InstanceKey origin : originStreams) {
-									// get the "Stream" representing it.
-									Stream stream = instanceToStreamMap.get(origin);
-
-									if (stream == null)
-										LOGGER.warning(() -> "Can't find Stream instance for instance key: "
-												+ instanceKey + " using origin: " + origin);
-									else {
-										LOGGER.log(Level.WARNING, "Unable to derive ROM for : " + stream.getCreation(),
-												e);
-										stream.addStatusEntry(PreconditionFailure.NON_DETERMINABLE_REDUCTION_ORDERING,
-												"Cannot derive reduction ordering for stream: " + stream.getCreation()
-														+ ".");
+				// if we haven't determined ROM yet.
+				if (rom == null) {
+					if (isVoid(possibleReturnTypes))
+						rom = deriveRomForVoidMethod(invokeInstruction);
+					else {
+						boolean scalar = Util.isScalar(possibleReturnTypes);
+						if (scalar)
+							try {
+								rom = deriveRomForScalarMethod(invokeInstruction);
+							} catch (UnknownIfReduceOrderMattersException e) {
+								// for each possible receiver associated with the terminal block.
+								OrdinalSet<InstanceKey> receivers = terminalBlockToPossibleReceivers.get(block);
+
+								for (InstanceKey instanceKey : receivers) {
+									// get the stream for the instance key.
+									Set<InstanceKey> originStreams = computePossibleOriginStreams(instanceKey);
+
+									// for each origin stream.
+									for (InstanceKey origin : originStreams) {
+										// get the "Stream" representing it.
+										Stream stream = instanceToStreamMap.get(origin);
+
+										if (stream == null)
+											LOGGER.warning(() -> "Can't find Stream instance for instance key: "
+													+ instanceKey + " using origin: " + origin);
+										else {
+											LOGGER.log(Level.WARNING,
+													"Unable to derive ROM for : " + stream.getCreation(), e);
+											stream.addStatusEntry(
+													PreconditionFailure.NON_DETERMINABLE_REDUCTION_ORDERING,
+													"Cannot derive reduction ordering for stream: "
+															+ stream.getCreation() + ".");
+										}
 									}
 								}
 							}
-						}
-					else // !scalar
-						rom = deriveRomForNonScalarMethod(possibleReturnTypes, orderingInference);
+						else // !scalar
+							rom = deriveRomForNonScalarMethod(possibleReturnTypes, orderingInference);
+					}
 				}
 
 				// if reduce ordering matters.