Ensure pony-lsp emits diagnostics for all documents (#4891)

Author: mfelsche

.release-notes/4891.md

@@ -0,0 +1,3 @@
+## Fix pony-lsp issue not emitting diagnostics for some documents
+
+Pony-lsp now is no longer randomly swallowing diagnostics and not emitting them to the lsp client, the editor.

tools/corral.json

@@ -1,18 +1,11 @@
 {
-  "packages": [
-    "pony-lsp",
-    "pony-lsp/workspace",
-    "pony-lsp/test"
-  ],
+  "packages": ["pony-lsp", "pony-lsp/workspace", "pony-lsp/test"],
   "deps": [
     {
-      "locator": "./lib/mfelsche/pony-immutable-json"
-    },
-    {
-      "locator": "./lib/mfelsche/pony-ast"
+      "locator": "./lib/ponylang/json-ng"
     },
     {
-      "locator": "./lib/mfelsche/pony-binarysearch"
+      "locator": "./lib/ponylang/pony_compiler"
     },
     {
       "locator": "./lib/ponylang/peg"

tools/pony-lsp/lsp_document.pony

@@ -205,7 +205,7 @@ actor WorkspaceManager
       if this._client.supports_publish_diagnostics() then
         for file in errors_by_file.keys() do
           try
-            let file_errors: pc.Vec[JsonValue] = recover val errors_by_file.remove(file)?._2 end
+            let file_errors: pc.Vec[JsonValue] = errors_by_file(file)?
             let msg = Notification.create(
               Methods.text_document().publish_diagnostics(),
               JsonObject
@@ -237,6 +237,9 @@ actor WorkspaceManager
         // to make sure we don't see any old diagnostics anymore
         this._request_sender.send_request(Methods.workspace().diagnostic().refresh(), None)
       end
+    else
+      this._channel.log("Received compilation result for run " + run.string() +
+      " but already received results for run " + this._compile_run.string())
     end