refactor: align property deletion implementation

jerome-benoit · jerome-benoit · commit 2aed691aba92 · 2025-07-06T21:18:18.000+02:00
Signed-off-by: Jérôme Benoit &lt;jerome.benoit@piment-noir.org&gt;
diff --git a/src/pools/selection-strategies/fair-share-worker-choice-strategy.ts b/src/pools/selection-strategies/fair-share-worker-choice-strategy.ts
@@ -81,8 +81,8 @@ export class FairShareWorkerChoiceStrategy<
       this.pool.workerNodes[workerNodeKey]?.strategyData
         ?.virtualTaskEndTimestamp != null
     ) {
-      delete this.pool.workerNodes[workerNodeKey].strategyData
-        .virtualTaskEndTimestamp
+      this.pool.workerNodes[workerNodeKey].strategyData
+        .virtualTaskEndTimestamp = undefined
     }
     return true
   }

Original file line number	Diff line number	Diff line change
`@@ -81,8 +81,8 @@ export class FairShareWorkerChoiceStrategy<`
`81`	`81`	`this.pool.workerNodes[workerNodeKey]?.strategyData`
`82`	`82`	`?.virtualTaskEndTimestamp != null`
`83`	`83`	`) {`
`84`		`- delete this.pool.workerNodes[workerNodeKey].strategyData`
`85`		`- .virtualTaskEndTimestamp`
	`84`	`+ this.pool.workerNodes[workerNodeKey].strategyData`
	`85`	`+ .virtualTaskEndTimestamp = undefined`
`86`	`86`	`}`
`87`	`87`	`return true`
`88`	`88`	`}`