refactor: refine waitWorkerNodeEvents() API

Signed-off-by: Jérôme Benoit <[email protected]>

Author: jerome-benoit

src/pools/abstract-pool.ts

@@ -1395,6 +1395,7 @@ export abstract class AbstractPool<
         getDefaultTasksQueueOptions(
           this.maximumNumberOfWorkers ?? this.minimumNumberOfWorkers,
         ).tasksFinishedTimeout,
+      false,
     )
     await this.sendKillMessageToWorker(workerNodeKey)
     workerNode.terminate()

src/pools/utils.ts

@@ -462,6 +462,7 @@ export const waitWorkerNodeEvents = async <
   workerNodeEvent: string,
   numberOfEventsToWait: number,
   timeout: number,
+  timeoutRejection: boolean = true,
 ): Promise<number> => {
   return await new Promise<number>((resolve, reject) => {
     let events = 0
@@ -480,7 +481,13 @@ export const waitWorkerNodeEvents = async <
     const timeoutHandle = timeout >= 0
       ? setTimeout(() => {
         workerNode.removeEventListener(workerNodeEvent, listener)
-        resolve(events)
+        timeoutRejection
+          ? reject(
+            new Error(
+              `Timed out after ${timeout.toString()}ms waiting for ${numberOfEventsToWait.toString()} '${workerNodeEvent}' events. Received ${events.toString()} events`,
+            ),
+          )
+          : resolve(events)
       }, timeout)
       : undefined
     switch (workerNodeEvent) {

tests/test-utils.mjs

@@ -19,7 +19,7 @@ export const waitWorkerNodeEvents = async (
       })
       reject(
         new Error(
-          `Timed out after ${timeoutMs}ms waiting for ${numberOfEventsToWait} '${workerNodeEvent}' events. Received ${events}.`,
+          `Timed out after ${timeoutMs.toString()}ms waiting for ${numberOfEventsToWait.toString()} '${workerNodeEvent}' events. Received ${events.toString()} events`,
         ),
       )
     }, timeoutMs)